From: Jakub Kicinski <kuba@kernel.org>
To: luoguangfei <15388634752@163.com>
Cc: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux@armlinux.org.uk, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: macb: fix unregister_netdev call order in macb_remove()
Date: Mon, 18 Aug 2025 09:58:52 -0700 [thread overview]
Message-ID: <20250818095852.52b94214@kernel.org> (raw)
In-Reply-To: <20250817003925.3362-1-15388634752@163.com>
On Sun, 17 Aug 2025 08:39:25 +0800 luoguangfei wrote:
> The warning happens because the PHY is being exited while the netdev
> is still registered. The correct order is to unregister the netdev
> before shutting down the PHY and cleaning up the MDIO bus.
>
> Fix this by moving unregister_netdev() ahead of phy_exit() in
> macb_remove().
>
> Signed-off-by: luoguangfei <15388634752@163.com>
Please add an appropriate Fixes tag, pointing to the oldest commit
where issues could be reproduced.
--
pw-bot: cr
next prev parent reply other threads:[~2025-08-18 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-17 0:39 [PATCH] net: macb: fix unregister_netdev call order in macb_remove() luoguangfei
2025-08-18 16:58 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-08-17 0:29 luoguangfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250818095852.52b94214@kernel.org \
--to=kuba@kernel.org \
--cc=15388634752@163.com \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.