Re: [PATCH 0/5] btrfs-progs: enhance --subvol/--inode-flags options

[David Sterba <dsterba@suse.cz>]

On Mon, Aug 18, 2025 at 10:01:42AM +0930, Qu Wenruo wrote:
> Currently both --subvol and --inode-flags save the full path into their
> structures, and check each inode against those full path.
> 
> For long paths it can be time consuming, and this introduces extra
> memory for each structure.
> 
> This series enhance the handling of those options by:
> 
> - Extract the validation part into a dedicated helper inside
>   rootdir.[ch]
> 
> - Use st_dev/st_ino to replace full_path
>   This reduces runtime and memory usage for the involved structures.
> 
> - Remove the memory usage warning note
>   Even with the old 8K per structure memory usage, 1024 options will
>   only 8M memory, that's accetable even for a lot of micro-controllers,
>   not to mention modern desktop/servers.
> 
>   I'm a little paranoid at that time, with the memory usage almost
>   halved, we can safely remove that warning note.
> 
> Qu Wenruo (5):
>   btrfs-progs: mkfs/rootdir: extract subvol validation code into a
>     helper
>   btrfs-progs: mkfs/rootdir: extract inode flags validation code into a
>     helper
>   btrfs-progs: mkfs/rootdir: enhance subvols detection
>   btrfs-progs: mkfs/rootdir: enhance inode flags detection
>   btrfs-progs: doc/mkfs: remove the note about memory usage

Looks good thanks, please add it do devel.