From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87A892FF664 for ; Mon, 18 Aug 2025 08:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755505362; cv=none; b=Vlh1oyMO71VdC2lf//Kk9wCfawc8UpD4n8/9cSstxEhSVGcZ22qcyoRut1wPt0uQR0sPeRbqvEZwl11bhnzh5qR7LERmvNKP1L2m4FtKetVktKUdMJv+2RlD5x8lDMSfkXl0gYy8V9yMdMPmO42EEAZzl4w9B6mHMmEHGStHAP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755505362; c=relaxed/simple; bh=HHKSAd/Mjx/o01GkdkMFhWBqYzjpMHK11Lxy/trHy2Q=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=RDzHmuqpnv2YpKfJ0hZYKCUohfe6ldvfkwGgUn24ZIujjnh+KrwwzrduwZ0FOzHnyJQyGPvGjHyL25HU/9jiorDiDTWApPbUZ8PBtf1oCaYcJFum9/rF71o4w+kFz79jmkqH6BbKG1SWJLj6dSVZfyK0Kr6ruGuOOFLKd8/qSsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RgzI3KC6; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RgzI3KC6" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-45a1ac7c066so21040155e9.1 for ; Mon, 18 Aug 2025 01:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755505359; x=1756110159; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DfM3OUic4SP+kzMyP8kHHqITaKkedG37VBt2aK4wKj0=; b=RgzI3KC6kuAgvudTcS0RqmV1JE8JzJvYNKGD5+genPP/LuilJCjCaxmX+kyOq0KzYG 4pTK0E7p8r4jb/PESv7xiAtcteH2QeZQ7kVI7+k8ZR3UjT1tDl43V8MvWSHm9bVej+Pi tF/Bh3lqfDlZPuz7hrTT/JiGrtiupmbeXx+rmQt5jEuSoFEs0EE2CNlO4XGXpcd6Zxjy 7hd3GAuEiy/+a9fg1CI4+4ZTNb5fTAX9BJrvOSGraxS927xSZp/JSzuo0bBW0Z3wZzyq Zox7CMAIu4Xk70mg2AwOfuGzkpfWPmta/U1xj4K6ibnWNN6dkDAx+mmtwfjNjgojxtu1 MNDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755505359; x=1756110159; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DfM3OUic4SP+kzMyP8kHHqITaKkedG37VBt2aK4wKj0=; b=niM+qEMQrN/tgyIFoRmLK+QmkS6ZSp3JuLuhTWP83G/ChRsSrFk1TZTZi1D4FWgfUF TQ4UgxGnp8S5R+SM0y9d+ac/BQ45YvXem7/9sOjSRRnUlaUNZWizQgl3xMDlFwttj99s DkJ6lt3J8qsxiSt7I/uYrbVx5QQ1sRcK9wfEIvfgfpc3Q4Y810RkO8fIuCSQgeyhnwQd faWRX/iIfWGPNyndHzNLuXUfXmaufnz/rKAbqqeP0jZZg23ZHU6MCin4bWCg0iO7YgJo 2Ih4KzMEHQar7Vz6DjTzPsmC83Is4LLTBL+lqXcEJvX0SR1Rdrqx42UXWD/CgmIEXiRj R9kw== X-Forwarded-Encrypted: i=1; AJvYcCWatRa8yxVkBOLVkAOrCHyfUar1TghAcZtbL0zS0hv6PiF1bdR5gshagxWT1GlrsAN6I1X9eKjITw==@vger.kernel.org X-Gm-Message-State: AOJu0YzyHRip1lsP+kdKiFbdeoh+vDzSWK6/DhRTenJj8WNraWykRiyX NzPsFZrNT3ypVgWx3uxS2gabtfbqLHEHM9XiNA5OZy/Rf7RmfQkQIO0mdFsQiB6f7uY= X-Gm-Gg: ASbGncse2ld3eUduCYCLLltk1Lh0CX03Rg4No0EPX2JAjcMV6n81fg7JqmxR07G11DW kB3U8PlFYcWm24fdjAZxNaYkRlB5cNZ6X8Y7cTAfFT8y8OlobyqxcOPQPH12izPi8Ykq9umvYmG GexrYgTLGbq+eZ446rQqwlQxiHh+/XLpv2cVsioK3av/AbCSMU/NYdJT17EHh0EAqBWihQVrcbb iZ0YlHyv5J31N9UDfKK0Y5kycjOSSqsh6jLPp4o0dg6B9AwfeyMmubZnzgTMXo4N2hUSSU8dvqY 0MzY+NkzG8kREYdX4hfkCGqz6XoHByBmL4T/1fWGlt3GmbmIToHI2YP2JdG+9gauzt0xxCJmt1E 5lLWf/+N6nzlKzQnXD5H2MI1VxErmRagJgUuCUXoRf5Q= X-Google-Smtp-Source: AGHT+IGwnL7IszKslS4RMmOckl7pctBDP8Ycuqwcw2vG42+4+Q5iaY+TBsZa0MdI4VtsEKOZ6UKuug== X-Received: by 2002:a05:600c:35d3:b0:458:bf15:689c with SMTP id 5b1f17b1804b1-45a1b65c6c6mr115855795e9.2.1755505358701; Mon, 18 Aug 2025 01:22:38 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45a22210ab4sm122737435e9.3.2025.08.18.01.22.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Aug 2025 01:22:38 -0700 (PDT) Date: Mon, 18 Aug 2025 11:22:35 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Chris Morgan , linux-rockchip@lists.infradead.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, broonie@kernel.org, lee@kernel.org, lgirdwood@gmail.com, sre@kernel.org, heiko@sntech.de, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, Chris Morgan , Sebastian Reichel Subject: Re: [PATCH V6 3/5] power: supply: bq257xx: Add support for BQ257XX charger Message-ID: <202508181503.GrRD2T4C-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250812214300.123129-4-macroalpha82@gmail.com> Hi Chris, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Chris-Morgan/dt-bindings-mfd-ti-bq25703a-Add-TI-BQ25703A-Charger/20250813-054704 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next patch link: https://lore.kernel.org/r/20250812214300.123129-4-macroalpha82%40gmail.com patch subject: [PATCH V6 3/5] power: supply: bq257xx: Add support for BQ257XX charger config: parisc-randconfig-r072-20250818 (https://download.01.org/0day-ci/archive/20250818/202508181503.GrRD2T4C-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 8.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202508181503.GrRD2T4C-lkp@intel.com/ smatch warnings: drivers/power/supply/bq257xx_charger.c:392 bq25703_hw_init() warn: potential ! vs ~ typo vim +392 drivers/power/supply/bq257xx_charger.c 7f3b6f1e51a925 Chris Morgan 2025-08-12 365 static int bq25703_hw_init(struct bq257xx_chg *pdata) 7f3b6f1e51a925 Chris Morgan 2025-08-12 366 { 7f3b6f1e51a925 Chris Morgan 2025-08-12 367 struct regmap *regmap = pdata->bq->regmap; 7f3b6f1e51a925 Chris Morgan 2025-08-12 368 int ret = 0; 7f3b6f1e51a925 Chris Morgan 2025-08-12 369 7f3b6f1e51a925 Chris Morgan 2025-08-12 370 regmap_update_bits(regmap, BQ25703_CHARGE_OPTION_0, 7f3b6f1e51a925 Chris Morgan 2025-08-12 371 BQ25703_WDTMR_ADJ_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 372 FIELD_PREP(BQ25703_WDTMR_ADJ_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 373 BQ25703_WDTMR_DISABLE)); 7f3b6f1e51a925 Chris Morgan 2025-08-12 374 7f3b6f1e51a925 Chris Morgan 2025-08-12 375 ret = pdata->chip->bq257xx_set_ichg(pdata, pdata->ichg_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 376 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 377 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 378 7f3b6f1e51a925 Chris Morgan 2025-08-12 379 ret = pdata->chip->bq257xx_set_vbatreg(pdata, pdata->vbat_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 380 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 381 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 382 7f3b6f1e51a925 Chris Morgan 2025-08-12 383 ret = bq25703_set_min_vsys(pdata, pdata->vsys_min); 7f3b6f1e51a925 Chris Morgan 2025-08-12 384 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 385 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 386 7f3b6f1e51a925 Chris Morgan 2025-08-12 387 ret = pdata->chip->bq257xx_set_iindpm(pdata, pdata->iindpm_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 388 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 389 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 390 7f3b6f1e51a925 Chris Morgan 2025-08-12 391 regmap_update_bits(regmap, BQ25703_CHARGE_OPTION_0, 7f3b6f1e51a925 Chris Morgan 2025-08-12 @392 BQ25703_EN_LWPWR, !BQ25703_EN_LWPWR); Yeah. This really looks like it should be bitwise negate ~ instead of logical negate !. 7f3b6f1e51a925 Chris Morgan 2025-08-12 393 7f3b6f1e51a925 Chris Morgan 2025-08-12 394 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 395 BQ25703_ADC_CONV_EN, BQ25703_ADC_CONV_EN); 7f3b6f1e51a925 Chris Morgan 2025-08-12 396 7f3b6f1e51a925 Chris Morgan 2025-08-12 397 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 398 BQ25703_ADC_START, BQ25703_ADC_START); 7f3b6f1e51a925 Chris Morgan 2025-08-12 399 7f3b6f1e51a925 Chris Morgan 2025-08-12 400 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 401 BQ25703_ADC_FULL_SCALE, BQ25703_ADC_FULL_SCALE); 7f3b6f1e51a925 Chris Morgan 2025-08-12 402 7f3b6f1e51a925 Chris Morgan 2025-08-12 403 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 404 BQ25703_ADC_CH_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 405 (BQ25703_ADC_CMPIN_EN | BQ25703_ADC_VBUS_EN | 7f3b6f1e51a925 Chris Morgan 2025-08-12 406 BQ25703_ADC_PSYS_EN | BQ25703_ADC_IIN_EN | 7f3b6f1e51a925 Chris Morgan 2025-08-12 407 BQ25703_ADC_IDCHG_EN | BQ25703_ADC_ICHG_EN | 7f3b6f1e51a925 Chris Morgan 2025-08-12 408 BQ25703_ADC_VSYS_EN | BQ25703_ADC_VBAT_EN)); 7f3b6f1e51a925 Chris Morgan 2025-08-12 409 7f3b6f1e51a925 Chris Morgan 2025-08-12 410 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 411 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34FFECA0ED1 for ; Mon, 18 Aug 2025 13:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=F6ke3wFFJb/YQO/P7fMrr2p+e/ubHKo/jHmvHlkKT5s=; b=y8ainZ2SC8C/t6 XrBl9TJBLPbGwaq2MzhgRSZ3XkTQ9VpfHuBBR5HKwiW5hpO0YUmrRbfNb474LcXFa6fqBwAtLjym+ JN8b4eR6JcxHjZU37rz1A/VLLn8YBe6beZY73oETlZf6ClXV82KnM2sjKnZfC8U4ROlK9TEdS/jQd wTv7hSdDs79irPYAoLkLs2AkRrnhTzMKdMyBs/B2KwLxBsLoTITDYDetgg47H8lNOrCJgl5aWoqUi C0WwyPD/AHHPiSMGccz1HwcnMJKr1E8l+io2qMG+3XqWefOHqivoJnG1TYcmXoi2MeMDHQRuvivX7 +DCAa2X1TkHMv8NX/KCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uo03K-00000007U5b-3XxQ; Mon, 18 Aug 2025 13:37:34 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1unv8a-00000006vkR-2IGY for linux-rockchip@lists.infradead.org; Mon, 18 Aug 2025 08:22:41 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-45a1ac7c066so21040175e9.1 for ; Mon, 18 Aug 2025 01:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755505359; x=1756110159; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DfM3OUic4SP+kzMyP8kHHqITaKkedG37VBt2aK4wKj0=; b=dbCoCiAeZD4Ja4KLxDZXDatDJSzx3v1y28oUQCf/BwtnGfrWOzeQ7JVRMeJryH575C j9tJDC+6Mr6kBiRqXCpavzgvEV7zKmNjJfSgunLQrKpKDLJerx4ygtVDKcUAlMfUewFy V0/y0dbr/lC+ArohaQlYOlHiK3PXwMaOVgWrYSWx8lbr4wFY05BgCpv5lRPIR1IyF0SE lQ5FPcw/anZz1bMEvr6wJy8YPkM2KEFAUQViVpNoPov0Xs0LiPNNc28y1crpaSY8lgNB gXta9wMmcqs6XBFOufiKQMDLJCN38zBcI69kjuL8sWU/uixbBVO0t/XWEq5yhkEyV796 bAsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755505359; x=1756110159; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DfM3OUic4SP+kzMyP8kHHqITaKkedG37VBt2aK4wKj0=; b=cnhBVgpEd+q7Q2376uEn/4i+xy9+HwNekAgI1zPhkSEH0QAR0y17hc23hSjqd/yR7c WdFwYw0cj6go1lc46YlzdFmVqzAvKQYPWSpeh+yaDdBKQQR1wgBniEU9/urBZL4QJGP9 hYHhKsQ5NmCSC+lRfDN8XYlkzFXPeeS8CznHEIIUv3nn4wiHodnv9k/v1z1ACX9V+ojj LC0Etjg1+VBLDKg+DduXOXviejRJqasenI/tpB21SwusAP0YxGLC9/mLFfR+qYVHl29w N8NYlOHnocXPnfE7axOqwLx/EpyQVrvvRBFObBFhKMwePo1lNoQRG2Xe/9YUQ91bGfqu EpRw== X-Forwarded-Encrypted: i=1; AJvYcCWAcdQPlDZuCaCpSQe5x0hOLORCZFS1UoOefRxGq3cC9cDNRn07NSntTROVuFteBFyzBzQCP4G5FoHP8aXHMA==@lists.infradead.org X-Gm-Message-State: AOJu0YyFovVr7891/Dw6y+1dsdwemm9We0FWZ0YVZpdTwBJhqdnRlcAT JkfRUEcVgcdL1bu9bbJHMoIOxcmZsvOkchXfODeipEiK1Z2oG0TbcBKLvEjeEAlxr4g= X-Gm-Gg: ASbGncuuCXk8c6VizIqH78cqJe5onJVHGDpNivjQZP3w7e5htQ9QYKCr4jRJA75vrhA CvUXkqFpj7b0Qmc72NXbzfI0vCsWatYhnoQ2BWqiDyh5MvbFFP3/AHHPSMG5CCZA7ihEOj8nYbZ rMygukLtlHowa7jT7ntlZ0E31dXAoyH7Mm26668oyedZqxsnMs1GLvnFqwAl9+GY/fBhICAuX3s ICICzPS5r5DBbrxdkjVCN2kLQrU9uKw319rhteaXc0UM/M+6D6p6cPbZ3FWIBMQcum1vdCGLVPV O9g61Fe487C9h7unT9GOmBxWK2q59sbVbdw4GMJ1KjgAQYoBC7DHKzBjm/AHXyYSgBFz4V1Phxy Fw281WXZ+XNLP2kr9FzjTn1wo6mP7tljZAK+Nkfpbjvk= X-Google-Smtp-Source: AGHT+IGwnL7IszKslS4RMmOckl7pctBDP8Ycuqwcw2vG42+4+Q5iaY+TBsZa0MdI4VtsEKOZ6UKuug== X-Received: by 2002:a05:600c:35d3:b0:458:bf15:689c with SMTP id 5b1f17b1804b1-45a1b65c6c6mr115855795e9.2.1755505358701; Mon, 18 Aug 2025 01:22:38 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45a22210ab4sm122737435e9.3.2025.08.18.01.22.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Aug 2025 01:22:38 -0700 (PDT) Date: Mon, 18 Aug 2025 11:22:35 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Chris Morgan , linux-rockchip@lists.infradead.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, broonie@kernel.org, lee@kernel.org, lgirdwood@gmail.com, sre@kernel.org, heiko@sntech.de, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, Chris Morgan , Sebastian Reichel Subject: Re: [PATCH V6 3/5] power: supply: bq257xx: Add support for BQ257XX charger Message-ID: <202508181503.GrRD2T4C-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250812214300.123129-4-macroalpha82@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250818_012240_592432_32098C3C X-CRM114-Status: UNSURE ( 7.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Chris, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Chris-Morgan/dt-bindings-mfd-ti-bq25703a-Add-TI-BQ25703A-Charger/20250813-054704 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next patch link: https://lore.kernel.org/r/20250812214300.123129-4-macroalpha82%40gmail.com patch subject: [PATCH V6 3/5] power: supply: bq257xx: Add support for BQ257XX charger config: parisc-randconfig-r072-20250818 (https://download.01.org/0day-ci/archive/20250818/202508181503.GrRD2T4C-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 8.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202508181503.GrRD2T4C-lkp@intel.com/ smatch warnings: drivers/power/supply/bq257xx_charger.c:392 bq25703_hw_init() warn: potential ! vs ~ typo vim +392 drivers/power/supply/bq257xx_charger.c 7f3b6f1e51a925 Chris Morgan 2025-08-12 365 static int bq25703_hw_init(struct bq257xx_chg *pdata) 7f3b6f1e51a925 Chris Morgan 2025-08-12 366 { 7f3b6f1e51a925 Chris Morgan 2025-08-12 367 struct regmap *regmap = pdata->bq->regmap; 7f3b6f1e51a925 Chris Morgan 2025-08-12 368 int ret = 0; 7f3b6f1e51a925 Chris Morgan 2025-08-12 369 7f3b6f1e51a925 Chris Morgan 2025-08-12 370 regmap_update_bits(regmap, BQ25703_CHARGE_OPTION_0, 7f3b6f1e51a925 Chris Morgan 2025-08-12 371 BQ25703_WDTMR_ADJ_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 372 FIELD_PREP(BQ25703_WDTMR_ADJ_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 373 BQ25703_WDTMR_DISABLE)); 7f3b6f1e51a925 Chris Morgan 2025-08-12 374 7f3b6f1e51a925 Chris Morgan 2025-08-12 375 ret = pdata->chip->bq257xx_set_ichg(pdata, pdata->ichg_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 376 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 377 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 378 7f3b6f1e51a925 Chris Morgan 2025-08-12 379 ret = pdata->chip->bq257xx_set_vbatreg(pdata, pdata->vbat_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 380 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 381 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 382 7f3b6f1e51a925 Chris Morgan 2025-08-12 383 ret = bq25703_set_min_vsys(pdata, pdata->vsys_min); 7f3b6f1e51a925 Chris Morgan 2025-08-12 384 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 385 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 386 7f3b6f1e51a925 Chris Morgan 2025-08-12 387 ret = pdata->chip->bq257xx_set_iindpm(pdata, pdata->iindpm_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 388 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 389 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 390 7f3b6f1e51a925 Chris Morgan 2025-08-12 391 regmap_update_bits(regmap, BQ25703_CHARGE_OPTION_0, 7f3b6f1e51a925 Chris Morgan 2025-08-12 @392 BQ25703_EN_LWPWR, !BQ25703_EN_LWPWR); Yeah. This really looks like it should be bitwise negate ~ instead of logical negate !. 7f3b6f1e51a925 Chris Morgan 2025-08-12 393 7f3b6f1e51a925 Chris Morgan 2025-08-12 394 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 395 BQ25703_ADC_CONV_EN, BQ25703_ADC_CONV_EN); 7f3b6f1e51a925 Chris Morgan 2025-08-12 396 7f3b6f1e51a925 Chris Morgan 2025-08-12 397 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 398 BQ25703_ADC_START, BQ25703_ADC_START); 7f3b6f1e51a925 Chris Morgan 2025-08-12 399 7f3b6f1e51a925 Chris Morgan 2025-08-12 400 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 401 BQ25703_ADC_FULL_SCALE, BQ25703_ADC_FULL_SCALE); 7f3b6f1e51a925 Chris Morgan 2025-08-12 402 7f3b6f1e51a925 Chris Morgan 2025-08-12 403 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 404 BQ25703_ADC_CH_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 405 (BQ25703_ADC_CMPIN_EN | BQ25703_ADC_VBUS_EN | 7f3b6f1e51a925 Chris Morgan 2025-08-12 406 BQ25703_ADC_PSYS_EN | BQ25703_ADC_IIN_EN | 7f3b6f1e51a925 Chris Morgan 2025-08-12 407 BQ25703_ADC_IDCHG_EN | BQ25703_ADC_ICHG_EN | 7f3b6f1e51a925 Chris Morgan 2025-08-12 408 BQ25703_ADC_VSYS_EN | BQ25703_ADC_VBAT_EN)); 7f3b6f1e51a925 Chris Morgan 2025-08-12 409 7f3b6f1e51a925 Chris Morgan 2025-08-12 410 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 411 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C50B27AC4B for ; Mon, 18 Aug 2025 07:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755503965; cv=none; b=RtONdI2C5CgVijpcqLdSn/fn8TkumURB+or/GHMQkFYQIUyLh0nAEdkWKW2Lc6kvkOCBXILzthjvmNYUxanh/FaaNccIO3M2zSmrCbpjtQWzT5W3jjYjkgqHjWKWF9EvWFYDiSR9/b5YDoVI0pISKhfg+YQWja4T7EC2KygOnOA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755503965; c=relaxed/simple; bh=MfSFRO4fwgI5JfPXoYeuRYin5NKHNdboepmuc08czUI=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=K2hNbW+QV6Msop6Q1XrGZiDe2E180c0dc7jHAsDR7e2QtEfsXSZ42M0pwHqPn4kYswpBPlup/fJOD9VUEQNRJn2ehM0KAUPh1i1LfVFqfoOfxCkMc4DD5SumvfZm7eG5j+SkFwuHJZq9nyo5F3qzco65uIzsfzp+5YXd2Kk/yy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hvT1paLL; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hvT1paLL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1755503963; x=1787039963; h=date:from:to:cc:subject:message-id:mime-version; bh=MfSFRO4fwgI5JfPXoYeuRYin5NKHNdboepmuc08czUI=; b=hvT1paLLhJ5BBfXxw7Z7l2x+iKWdWkOEi9wg6gQO5leJKVJ+lgfGejsy +kdLdEM8VkYDZ8gh4k8qz2mk+khJOAJan0ONNxAgWysgFXtAx63kIk5O+ 0NGga9Uvix6mY4o/sJ+TtBlbF7RV6Z34EbcM8IazyQ7waT/xDjVZP//HJ 9dVDK/2oyDQB+RMvR/nCXA6lJ5+fBOxnfkZpvvEpm9bWiAEXb2P1AWH8Z 9VaFjWntLRxV9oekqYzJXgPCweVfxzVjz3czjmQYqoC9hdAMfUhZSEVyT gG2IyMawQqyfT3HiYGzkpDltZmBW1AvNJ8EX+Wna861+VIZmV1ILkradE Q==; X-CSE-ConnectionGUID: E2tVmSA8TguyvoqUi11jeA== X-CSE-MsgGUID: lVok18QzTnKkbqbjeypwLg== X-IronPort-AV: E=McAfee;i="6800,10657,11524"; a="57632470" X-IronPort-AV: E=Sophos;i="6.17,293,1747724400"; d="scan'208";a="57632470" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2025 00:59:22 -0700 X-CSE-ConnectionGUID: P2fJM2DnS0Os3KYjVajFIQ== X-CSE-MsgGUID: kJVyEI4sR8WFhfwIL7TimA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,293,1747724400"; d="scan'208";a="198364755" Received: from lkp-server02.sh.intel.com (HELO 4ea60e6ab079) ([10.239.97.151]) by fmviesa001.fm.intel.com with ESMTP; 18 Aug 2025 00:59:21 -0700 Received: from kbuild by 4ea60e6ab079 with local (Exim 4.96) (envelope-from ) id 1unuli-000E23-0B; Mon, 18 Aug 2025 07:59:02 +0000 Date: Mon, 18 Aug 2025 15:58:29 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: Re: [PATCH V6 3/5] power: supply: bq257xx: Add support for BQ257XX charger Message-ID: <202508181503.GrRD2T4C-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev In-Reply-To: <20250812214300.123129-4-macroalpha82@gmail.com> References: <20250812214300.123129-4-macroalpha82@gmail.com> TO: Chris Morgan TO: linux-rockchip@lists.infradead.org CC: linux-pm@vger.kernel.org CC: devicetree@vger.kernel.org CC: broonie@kernel.org CC: lee@kernel.org CC: lgirdwood@gmail.com CC: sre@kernel.org CC: heiko@sntech.de CC: conor+dt@kernel.org CC: krzk+dt@kernel.org CC: robh@kernel.org CC: Chris Morgan CC: Sebastian Reichel Hi Chris, kernel test robot noticed the following build warnings: [auto build test WARNING on broonie-regulator/for-next] [also build test WARNING on sre-power-supply/for-next rockchip/for-next linus/master v6.17-rc2 next-20250818] [cannot apply to lee-mfd/for-mfd-next lee-mfd/for-mfd-fixes] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Chris-Morgan/dt-bindings-mfd-ti-bq25703a-Add-TI-BQ25703A-Charger/20250813-054704 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next patch link: https://lore.kernel.org/r/20250812214300.123129-4-macroalpha82%40gmail.com patch subject: [PATCH V6 3/5] power: supply: bq257xx: Add support for BQ257XX charger :::::: branch date: 5 days ago :::::: commit date: 5 days ago config: parisc-randconfig-r072-20250818 (https://download.01.org/0day-ci/archive/20250818/202508181503.GrRD2T4C-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 8.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202508181503.GrRD2T4C-lkp@intel.com/ smatch warnings: drivers/power/supply/bq257xx_charger.c:392 bq25703_hw_init() warn: potential ! vs ~ typo vim +392 drivers/power/supply/bq257xx_charger.c 7f3b6f1e51a925 Chris Morgan 2025-08-12 351 7f3b6f1e51a925 Chris Morgan 2025-08-12 352 /** 7f3b6f1e51a925 Chris Morgan 2025-08-12 353 * bq25703_hw_init() - Set all the required registers to init the charger 7f3b6f1e51a925 Chris Morgan 2025-08-12 354 * @pdata: driver platform data 7f3b6f1e51a925 Chris Morgan 2025-08-12 355 * 7f3b6f1e51a925 Chris Morgan 2025-08-12 356 * Initialize the BQ25703 by first disabling the watchdog timer (which 7f3b6f1e51a925 Chris Morgan 2025-08-12 357 * shuts off the charger in the absence of periodic writes). Then, set 7f3b6f1e51a925 Chris Morgan 2025-08-12 358 * the charge current, charge voltage, minimum system voltage, and 7f3b6f1e51a925 Chris Morgan 2025-08-12 359 * input current limit. Disable low power mode to allow ADCs and 7f3b6f1e51a925 Chris Morgan 2025-08-12 360 * interrupts. Enable the ADC, start the ADC, set the ADC scale to 7f3b6f1e51a925 Chris Morgan 2025-08-12 361 * full, and enable each individual ADC channel. 7f3b6f1e51a925 Chris Morgan 2025-08-12 362 * 7f3b6f1e51a925 Chris Morgan 2025-08-12 363 * Return: Returns 0 on success or error code on error. 7f3b6f1e51a925 Chris Morgan 2025-08-12 364 */ 7f3b6f1e51a925 Chris Morgan 2025-08-12 365 static int bq25703_hw_init(struct bq257xx_chg *pdata) 7f3b6f1e51a925 Chris Morgan 2025-08-12 366 { 7f3b6f1e51a925 Chris Morgan 2025-08-12 367 struct regmap *regmap = pdata->bq->regmap; 7f3b6f1e51a925 Chris Morgan 2025-08-12 368 int ret = 0; 7f3b6f1e51a925 Chris Morgan 2025-08-12 369 7f3b6f1e51a925 Chris Morgan 2025-08-12 370 regmap_update_bits(regmap, BQ25703_CHARGE_OPTION_0, 7f3b6f1e51a925 Chris Morgan 2025-08-12 371 BQ25703_WDTMR_ADJ_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 372 FIELD_PREP(BQ25703_WDTMR_ADJ_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 373 BQ25703_WDTMR_DISABLE)); 7f3b6f1e51a925 Chris Morgan 2025-08-12 374 7f3b6f1e51a925 Chris Morgan 2025-08-12 375 ret = pdata->chip->bq257xx_set_ichg(pdata, pdata->ichg_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 376 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 377 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 378 7f3b6f1e51a925 Chris Morgan 2025-08-12 379 ret = pdata->chip->bq257xx_set_vbatreg(pdata, pdata->vbat_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 380 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 381 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 382 7f3b6f1e51a925 Chris Morgan 2025-08-12 383 ret = bq25703_set_min_vsys(pdata, pdata->vsys_min); 7f3b6f1e51a925 Chris Morgan 2025-08-12 384 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 385 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 386 7f3b6f1e51a925 Chris Morgan 2025-08-12 387 ret = pdata->chip->bq257xx_set_iindpm(pdata, pdata->iindpm_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 388 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 389 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 390 7f3b6f1e51a925 Chris Morgan 2025-08-12 391 regmap_update_bits(regmap, BQ25703_CHARGE_OPTION_0, 7f3b6f1e51a925 Chris Morgan 2025-08-12 @392 BQ25703_EN_LWPWR, !BQ25703_EN_LWPWR); 7f3b6f1e51a925 Chris Morgan 2025-08-12 393 7f3b6f1e51a925 Chris Morgan 2025-08-12 394 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 395 BQ25703_ADC_CONV_EN, BQ25703_ADC_CONV_EN); 7f3b6f1e51a925 Chris Morgan 2025-08-12 396 7f3b6f1e51a925 Chris Morgan 2025-08-12 397 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 398 BQ25703_ADC_START, BQ25703_ADC_START); 7f3b6f1e51a925 Chris Morgan 2025-08-12 399 7f3b6f1e51a925 Chris Morgan 2025-08-12 400 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 401 BQ25703_ADC_FULL_SCALE, BQ25703_ADC_FULL_SCALE); 7f3b6f1e51a925 Chris Morgan 2025-08-12 402 7f3b6f1e51a925 Chris Morgan 2025-08-12 403 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 404 BQ25703_ADC_CH_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 405 (BQ25703_ADC_CMPIN_EN | BQ25703_ADC_VBUS_EN | 7f3b6f1e51a925 Chris Morgan 2025-08-12 406 BQ25703_ADC_PSYS_EN | BQ25703_ADC_IIN_EN | 7f3b6f1e51a925 Chris Morgan 2025-08-12 407 BQ25703_ADC_IDCHG_EN | BQ25703_ADC_ICHG_EN | 7f3b6f1e51a925 Chris Morgan 2025-08-12 408 BQ25703_ADC_VSYS_EN | BQ25703_ADC_VBAT_EN)); 7f3b6f1e51a925 Chris Morgan 2025-08-12 409 7f3b6f1e51a925 Chris Morgan 2025-08-12 410 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 411 } 7f3b6f1e51a925 Chris Morgan 2025-08-12 412 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki