From: Jakub Kicinski <kuba@kernel.org>
To: Alex Tran <alex.t.tran@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, shuah@kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests net/socket.c: removed warnings from unused returns
Date: Mon, 18 Aug 2025 17:35:15 -0700 [thread overview]
Message-ID: <20250818173515.1845a785@kernel.org> (raw)
In-Reply-To: <20250815060631.144471-1-alex.t.tran@gmail.com>
On Thu, 14 Aug 2025 23:06:31 -0700 Alex Tran wrote:
> + char *err_message1;
> + char *err_message2;
nit, how about:
const char *msg1, *msg2;
? And then please wrap the lines at 80 chars.
> int i, err;
>
> err = 0;
> @@ -56,13 +58,13 @@ static int run_tests(void)
> errno == -s->expect)
> continue;
>
> - strerror_r(-s->expect, err_string1, ERR_STRING_SZ);
> - strerror_r(errno, err_string2, ERR_STRING_SZ);
> + err_message1 = strerror_r(-s->expect, err_string1, ERR_STRING_SZ);
> + err_message2 = strerror_r(errno, err_string2, ERR_STRING_SZ);
next prev parent reply other threads:[~2025-08-19 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 6:06 [PATCH] selftests net/socket.c: removed warnings from unused returns Alex Tran
2025-08-19 0:35 ` Jakub Kicinski [this message]
2025-08-19 2:27 ` Alex Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250818173515.1845a785@kernel.org \
--to=kuba@kernel.org \
--cc=alex.t.tran@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.