All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Collins <bcollins@kernel.org>
To: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Andrew Hepp" <andrew.hepp@ahepp.dev>
Cc: Ben Collins <bcollins@watter.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/6] dt-bindings: iio: mcp9600: Add microchip,mcp9601 and add constraints
Date: Mon, 18 Aug 2025 14:32:10 -0400	[thread overview]
Message-ID: <20250818183214.380847-3-bcollins@kernel.org> (raw)
In-Reply-To: <20250818183214.380847-1-bcollins@kernel.org>

From: Ben Collins <bcollins@watter.com>

Add microchip,mcp9601 compatible in addition to the original
microchip,mcp9600 to designate support between these two chips.

The current dt-binding has open-circuit and short-circuit as interrupt
names, but these are only supported in mcp9601.

The OC and SC detection requires that mcp9601 VSENSE be wired up, which
not only enables the OC SC interrupts, but also the OC and SC status
register bits.

Add a microchip,vsense boolean to show the chip is wired for this
support.

Add constraints so this feature only applies if the mcp9601 compatible
is selected.

Signed-off-by: Ben Collins <bcollins@watter.com>
---
 .../iio/temperature/microchip,mcp9600.yaml    | 60 ++++++++++++++++++-
 1 file changed, 57 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml b/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml
index 57b387a1accc..c22edb4ab852 100644
--- a/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml
+++ b/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml
@@ -4,7 +4,7 @@
 $id: http://devicetree.org/schemas/iio/temperature/microchip,mcp9600.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Microchip MCP9600 thermocouple EMF converter
+title: Microchip MCP9600 and similar thermocouple EMF converters
 
 maintainers:
   - Andrew Hepp <andrew.hepp@ahepp.dev>
@@ -14,7 +14,11 @@ description:
 
 properties:
   compatible:
-    const: microchip,mcp9600
+    oneOf:
+      - const: microchip,mcp9600
+      - items:
+          - const: microchip,mcp9601
+          - const: microchip,mcp9600
 
   reg:
     maxItems: 1
@@ -34,6 +38,8 @@ properties:
         - alert2
         - alert3
         - alert4
+        - open-circuit
+        - short-circuit
 
   thermocouple-type:
     $ref: /schemas/types.yaml#/definitions/uint32
@@ -43,8 +49,37 @@ properties:
       Use defines in dt-bindings/iio/temperature/thermocouple.h.
       Supported types are B, E, J, K, N, R, S, T.
 
+  microchip,vsense:
+    type: boolean
+    description:
+      This flag indicates that the chip has been wired with VSENSE to
+      enable open and short circuit detect.
+
   vdd-supply: true
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          not:
+            contains:
+              const: microchip,mcp9601
+    then:
+      properties:
+        interrupts:
+          minItems: 1
+          maxItems: 4
+        interrupt-names:
+          minItems: 1
+          maxItems: 4
+          items:
+            enum:
+              - alert1
+              - alert2
+              - alert3
+              - alert4
+        microchip,vsense: false
+
 required:
   - compatible
   - reg
@@ -64,8 +99,27 @@ examples:
             reg = <0x60>;
             interrupt-parent = <&gpio>;
             interrupts = <25 IRQ_TYPE_EDGE_RISING>;
-            interrupt-names = "open-circuit";
+            interrupt-names = "alert1";
             thermocouple-type = <THERMOCOUPLE_TYPE_K>;
             vdd-supply = <&vdd>;
         };
     };
+  - |
+    #include <dt-bindings/iio/temperature/thermocouple.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        temperature-sensor@62 {
+            compatible = "microchip,mcp9601",
+                         "microchip,mcp9600";
+            microchip,vsense;
+            reg = <0x62>;
+            interrupt-parent = <&gpio>;
+            interrupts = <22 IRQ_TYPE_EDGE_RISING
+                          23 IRQ_TYPE_EDGE_RISING>;
+            interrupt-names = "open-circuit", "short-circuit";
+            vdd-supply = <&vdd>;
+        };
+    };
-- 
2.39.5


  parent reply	other threads:[~2025-08-18 18:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 18:32 [PATCH v5 0/5] iio: mcp9600: Features and improvements Ben Collins
2025-08-18 18:32 ` [PATCH 1/6] dt-bindings: iio: mcp9600: Set default 3 for thermocouple-type Ben Collins
2025-08-19  6:56   ` Krzysztof Kozlowski
2025-08-18 18:32 ` Ben Collins [this message]
2025-08-18 20:40   ` [PATCH 2/6] dt-bindings: iio: mcp9600: Add microchip,mcp9601 and add constraints Rob Herring (Arm)
2025-08-19  6:57   ` Krzysztof Kozlowski
2025-08-18 18:32 ` [PATCH 3/6] iio: mcp9600: White space and fixed width cleanup Ben Collins
2025-08-19 14:55   ` David Lechner
2025-08-19 15:02     ` David Lechner
2025-08-18 18:32 ` [PATCH 4/6] iio: mcp9600: Recognize chip id for mcp9601 Ben Collins
2025-08-19 14:57   ` David Lechner
2025-08-18 18:32 ` [PATCH 5/6] iio: mcp9600: Add support for thermocouple-type Ben Collins
2025-08-19 14:59   ` David Lechner
2025-08-18 18:32 ` [PATCH 6/6] iio: mcp9600: Add support for IIR filter Ben Collins
2025-08-19 14:05   ` David Lechner
2025-08-19 14:11     ` Ben Collins
2025-08-19 14:15       ` David Lechner
2025-08-19 14:32         ` Ben Collins
2025-08-19 14:43           ` David Lechner
2025-08-19 18:40             ` Jonathan Cameron
2025-08-19  6:55 ` [PATCH v5 0/5] iio: mcp9600: Features and improvements Krzysztof Kozlowski
2025-08-19 18:24   ` Jonathan Cameron
2025-08-19 20:44     ` Ben Collins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250818183214.380847-3-bcollins@kernel.org \
    --to=bcollins@kernel.org \
    --cc=andrew.hepp@ahepp.dev \
    --cc=andy@kernel.org \
    --cc=bcollins@watter.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.