From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: rtnetlink: fix addrlft test flakiness on power-saving systems
Date: Mon, 18 Aug 2025 19:08:03 -0700 [thread overview]
Message-ID: <20250818190803.19a43fae@kernel.org> (raw)
In-Reply-To: <aKPYe8t7kR_u7DZ7@fedora>
On Tue, 19 Aug 2025 01:50:51 +0000 Hangbin Liu wrote:
> Hmm, I think we need to know what's the current preferred_lft and valid_lft
> on failed test. Would you please add a debug line so we can get the info
> after failed?
>
> slowwait 5 check_addr_not_exist "$devdummy" "10.23.11."
> if [ $? -eq 1 ]; then
> + ip addr show dev "$devdummy"
> check_err 1
> end_test "FAIL: preferred_lft addresses remaining"
> return
Given that this is 2nd or 3rd time we're massaging this test case
I think we should just add the appropriate debug information to the
test itself. Please post a real patch?
prev parent reply other threads:[~2025-08-19 2:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 4:34 [PATCH net] selftests: rtnetlink: fix addrlft test flakiness on power-saving systems Hangbin Liu
2025-07-16 22:10 ` patchwork-bot+netdevbpf
2025-08-19 1:30 ` Jakub Kicinski
2025-08-19 1:50 ` Hangbin Liu
2025-08-19 2:08 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250818190803.19a43fae@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.