Re: [PATCH 3/3] generic/450: don't hang when running on devices with protection information

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Aug 18, 2025 at 09:27:18AM +0200, Christoph Hellwig wrote:
> The dm thinp target does not work on devices with protection information,
> and the udevadm settle command simply hangs when lvcreate failed because
> of that.  Avoid that by doing a strategic _notrun when lvcreate fails.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks fine,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  tests/generic/459 | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/generic/459 b/tests/generic/459
> index 3f5f0f2b7dc1..48520f9f4af0 100755
> --- a/tests/generic/459
> +++ b/tests/generic/459
> @@ -93,12 +93,14 @@ $LVM_PROG vgcreate -f $vgname $SCRATCH_DEV >>$seqres.full 2>&1
>  
>  $LVM_PROG lvcreate  --thinpool $poolname  --errorwhenfull y \
>  		    --zero n -L $origpsize \
> -		    --poolmetadatasize 4M $vgname >>$seqres.full 2>&1
> +		    --poolmetadatasize 4M $vgname >>$seqres.full 2>&1 || \
> +	_notrun "Can't create thin pool"
>  
>  # Create a overprovisioned 300MB dm-thin virt. device
>  $LVM_PROG lvcreate  --virtualsize $virtsize \
>  		    -T $vgname/$poolname \
> -		    -n $lvname >>$seqres.full 2>&1
> +		    -n $lvname >>$seqres.full 2>&1 || \
> +	_notrun "Can't create thin volume"
>  _udev_wait /dev/mapper/$vgname-$lvname
>  _mkfs_dev /dev/mapper/$vgname-$lvname >>$seqres.full 2>&1
>  
> -- 
> 2.47.2
> 
>