From: Nathan Chancellor <nathan@kernel.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Alexey Gladkov <legion@kernel.org>,
Nicolas Schier <nicolas.schier@linux.dev>,
Masahiro Yamada <masahiroy@kernel.org>,
Petr Pavlu <petr.pavlu@suse.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
Daniel Gomez <da.gomez@samsung.com>,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
linux-kbuild@vger.kernel.org, Khalid Aziz <khalid@gonehiking.org>,
linux-scsi@vger.kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Arnd Bergmann <arnd@arndb.de>,
Damien Le Moal <dlemoal@kernel.org>
Subject: Re: [PATCH v6 4/9] scsi: Always define blogic_pci_tbl structure
Date: Tue, 19 Aug 2025 00:18:17 -0700 [thread overview]
Message-ID: <20250819071817.GA1540193@ax162> (raw)
In-Reply-To: <yq1v7mkxe2h.fsf@ca-mkp.ca.oracle.com>
Hi Martin,
On Mon, Aug 18, 2025 at 10:04:02PM -0400, Martin K. Petersen wrote:
>
> Alexey,
>
> > The blogic_pci_tbl structure is used by the MODULE_DEVICE_TABLE macro.
> > There is no longer a need to protect it with the MODULE condition,
> > since this no longer causes the compiler to warn about an unused
> > variable.
> >
> > To avoid warnings when -Wunused-const-variable option is used, mark it
> > as __maybe_unused for such configuration.
>
> Applied to 6.18/scsi-staging, thanks!
I think I will need this change to apply patch 7 [1] to kbuild-next
without any issues [2]. If there is little risk of conflict, could I
take it with your Ack? Another option would be getting it into 6.17 as a
fix so that I could back merge Linus's tree and apply the series on top.
I am already going to have to do that for the pinctrl change that Linus
W took [3].
[1]: https://lore.kernel.org/22b36a5807d943a84431298c18b41d093e01c371.1755170493.git.legion@kernel.org/
[2]: https://lore.kernel.org/aDWoCU2YrxaCBi42@example.org/
[3]: https://lore.kernel.org/CACRpkdZ9oyJ4aJ5Dcp_Dtv5qoiSo+g5cO7Uf4PmHgv_Z423onQ@mail.gmail.com/
Cheers,
Nathan
next prev parent reply other threads:[~2025-08-19 7:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 13:07 [PATCH v6 0/9] Add generated modalias to modules.builtin.modinfo Alexey Gladkov
2025-08-14 13:07 ` [PATCH v6 1/9] kbuild: always create intermediate vmlinux.unstripped Alexey Gladkov
2025-08-14 13:07 ` [PATCH v6 2/9] kbuild: keep .modinfo section in vmlinux.unstripped Alexey Gladkov
2025-08-14 13:07 ` [PATCH v6 3/9] kbuild: extract modules.builtin.modinfo from vmlinux.unstripped Alexey Gladkov
2025-08-17 12:34 ` Masahiro Yamada
2025-08-17 12:52 ` Alexey Gladkov
2025-08-18 6:43 ` Nathan Chancellor
2025-08-14 13:07 ` [PATCH v6 4/9] scsi: Always define blogic_pci_tbl structure Alexey Gladkov
2025-08-19 2:04 ` Martin K. Petersen
2025-08-19 7:18 ` Nathan Chancellor [this message]
2025-08-20 1:52 ` Martin K. Petersen
2025-08-20 16:11 ` Nathan Chancellor
2025-08-25 10:09 ` Alexey Gladkov
2025-08-25 16:56 ` Nathan Chancellor
2025-08-14 13:07 ` [PATCH v6 5/9] pinctrl: meson: Fix typo in device table macro Alexey Gladkov
2025-08-14 13:07 ` Alexey Gladkov
2025-08-18 9:11 ` Linus Walleij
2025-08-18 9:11 ` Linus Walleij
2025-08-14 13:07 ` [PATCH v6 6/9] modpost: Add modname to mod_device_table alias Alexey Gladkov
2025-08-14 13:26 ` Danilo Krummrich
2025-08-14 13:54 ` Alexey Gladkov
2025-08-14 14:03 ` Danilo Krummrich
2025-08-14 21:46 ` Alexey Gladkov
2025-08-14 22:17 ` Danilo Krummrich
2025-08-14 13:07 ` [PATCH v6 7/9] modpost: Create modalias for builtin modules Alexey Gladkov
2025-08-14 13:07 ` [PATCH v6 8/9] kbuild: vmlinux.unstripped should always depend on .vmlinux.export.o Alexey Gladkov
2025-08-14 13:07 ` [PATCH v6 9/9] s390: vmlinux.lds.S: Reorder sections Alexey Gladkov
2025-08-14 14:16 ` Heiko Carstens
2025-08-14 21:51 ` Alexey Gladkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250819071817.GA1540193@ax162 \
--to=nathan@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arnd@arndb.de \
--cc=da.gomez@samsung.com \
--cc=dlemoal@kernel.org \
--cc=khalid@gonehiking.org \
--cc=legion@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=nicolas.schier@linux.dev \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.