All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael Roth" <michael.roth@amd.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Mads Ynddal" <mads@ynddal.dk>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v4 3/7] tracetool: avoid space after "*" in arg types
Date: Tue, 19 Aug 2025 17:10:49 +0100	[thread overview]
Message-ID: <20250819161053.464641-4-berrange@redhat.com> (raw)
In-Reply-To: <20250819161053.464641-1-berrange@redhat.com>

QEMU code style is to have no whitespace between "*" and the
arg name. Since generated trace code will soon be added to
git, make it comply with code style.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 scripts/tracetool/__init__.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
index 2ae2e562d6..0f33758870 100644
--- a/scripts/tracetool/__init__.py
+++ b/scripts/tracetool/__init__.py
@@ -170,10 +170,16 @@ def __len__(self):
 
     def __str__(self):
         """String suitable for declaring function arguments."""
+        def onearg(t, n):
+            if t[-1] == '*':
+                return "".join([t, n])
+            else:
+                return " ".join([t, n])
+
         if len(self._args) == 0:
             return "void"
         else:
-            return ", ".join([ " ".join([t, n]) for t,n in self._args ])
+            return ", ".join([ onearg(t, n) for t,n in self._args ])
 
     def __repr__(self):
         """Evaluable string representation for this object."""
-- 
2.50.1



  parent reply	other threads:[~2025-08-19 16:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-19 16:10 [PATCH v4 0/7] tracetool: add test suite to improve reviewability Daniel P. Berrangé
2025-08-19 16:10 ` [PATCH v4 1/7] checkpatch: cull trailing '*/' in SPDX check Daniel P. Berrangé
2025-08-19 16:10 ` [PATCH v4 2/7] tracetool: eliminate trailing whitespace in C format Daniel P. Berrangé
2025-08-19 16:10 ` Daniel P. Berrangé [this message]
2025-08-19 16:10 ` [PATCH v4 4/7] tracetool: include SPDX-License-Identifier in generated files Daniel P. Berrangé
2025-08-19 16:10 ` [PATCH v4 5/7] tracetool: add test suite for tracetool with reference output Daniel P. Berrangé
2025-08-21 14:28   ` Stefan Hajnoczi
2025-08-19 16:10 ` [PATCH v4 6/7] tracetool: drop the probe "__nocheck__" wrapping Daniel P. Berrangé
2025-08-19 16:10 ` [PATCH v4 7/7] qapi: switch to use QEMU_TEST_REGENERATE env var Daniel P. Berrangé
2025-08-30  8:20   ` Markus Armbruster
2025-08-21 14:29 ` [PATCH v4 0/7] tracetool: add test suite to improve reviewability Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250819161053.464641-4-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=mads@ynddal.dk \
    --cc=michael.roth@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.