From: Jakub Kicinski <kuba@kernel.org>
To: Dragos Tatulea <dtatulea@nvidia.com>
Cc: cpaasch@openai.com, Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Gal Pressman <gal@nvidia.com>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net/mlx5: Avoid copying payload to the skb's linear part
Date: Tue, 19 Aug 2025 17:15:05 -0700 [thread overview]
Message-ID: <20250819171505.4ebbac36@kernel.org> (raw)
In-Reply-To: <6dguqontvbisoypbfxw5xyscyqhvskk5avf7gwqgwajc4ic75a@id3pume2f4hw>
On Tue, 19 Aug 2025 09:58:54 +0000 Dragos Tatulea wrote:
> > @@ -2009,10 +2040,14 @@ mlx5e_skb_from_cqe_mpwrq_nonlinear(struct mlx5e_rq *rq, struct mlx5e_mpw_info *w
> > u32 linear_frame_sz;
> > u16 linear_data_len;
> > u16 linear_hr;
> > + u16 headlen;
> > void *va;
> >
> > prog = rcu_dereference(rq->xdp_prog);
> >
> > + headlen = min3(mlx5e_cqe_estimate_hdr_len(cqe), cqe_bcnt,
> > + (u16)MLX5E_RX_MAX_HEAD);
> > +
> How about keeping the old calculation for XDP and do this one for
> non-xdp in the following if/else block?
>
> This way XDP perf will not be impacted by the extra call to
> mlx5e_cqe_estimate_hdr_len().
Perhaps move it further down for XDP?
Ideally attaching a program which returns XDP_PASS shouldn't impact
normal TCP perf.
next prev parent reply other threads:[~2025-08-20 0:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-16 15:39 [PATCH net-next v2 0/2] net/mlx5: Avoid payload in skb's linear part for better GRO-processing Christoph Paasch
2025-08-16 15:39 ` Christoph Paasch via B4 Relay
2025-08-16 15:39 ` [PATCH net-next v2 1/2] net/mlx5: Bring back get_cqe_l3_hdr_type Christoph Paasch
2025-08-16 15:39 ` Christoph Paasch via B4 Relay
2025-08-16 15:39 ` [PATCH net-next v2 2/2] net/mlx5: Avoid copying payload to the skb's linear part Christoph Paasch
2025-08-16 15:39 ` Christoph Paasch via B4 Relay
2025-08-19 9:58 ` Dragos Tatulea
2025-08-20 0:15 ` Jakub Kicinski [this message]
2025-08-21 22:59 ` Christoph Paasch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250819171505.4ebbac36@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=cpaasch@openai.com \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.