From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Richard Gobert <richardbgobert@gmail.com>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, corbet@lwn.net,
shenjian15@huawei.com, salil.mehta@huawei.com,
shaojijie@huawei.com, andrew+netdev@lunn.ch, saeedm@nvidia.com,
tariqt@nvidia.com, mbloch@nvidia.com, leon@kernel.org,
ecree.xilinx@gmail.com, dsahern@kernel.org, ncardwell@google.com,
kuniyu@google.com, shuah@kernel.org, sdf@fomichev.me,
ahmed.zaki@intel.com, aleksander.lobakin@intel.com,
florian.fainelli@broadcom.com, linux-kernel@vger.kernel.org,
linux-net-drivers@amd.com
Subject: Re: [PATCH net-next v2 2/5] net: gro: only merge packets with incrementing or fixed outer ids
Date: Tue, 19 Aug 2025 17:30:05 -0700 [thread overview]
Message-ID: <20250819173005.6b560779@kernel.org> (raw)
In-Reply-To: <willemdebruijn.kernel.a8507becb441@gmail.com>
On Tue, 19 Aug 2025 10:46:01 -0400 Willem de Bruijn wrote:
> It's a bit unclear what the meaning of inner and outer are in the
> unencapsulated (i.e., normal) case. In my intuition outer only exists
> if encapsulated, but it seems you reason the other way around: inner
> is absent unless encapsulated.
+1, whether the header in unencapsulted packet is inner or outer
is always a source of unnecessary confusion. I would have also
preferred your suggestion on v1 to use _ENCAP in the name.
next prev parent reply other threads:[~2025-08-20 0:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 6:32 [PATCH net-next v2 0/5] net: gso: restore outer ip ids correctly Richard Gobert
2025-08-19 6:32 ` [PATCH net-next v2 1/5] net: gro: remove is_ipv6 from napi_gro_cb Richard Gobert
2025-08-19 8:47 ` Eric Dumazet
2025-08-19 12:26 ` Richard Gobert
2025-08-19 6:32 ` [PATCH net-next v2 2/5] net: gro: only merge packets with incrementing or fixed outer ids Richard Gobert
2025-08-19 14:46 ` Willem de Bruijn
2025-08-20 0:30 ` Jakub Kicinski [this message]
2025-08-20 12:27 ` Richard Gobert
2025-08-20 15:04 ` Jakub Kicinski
2025-08-20 0:30 ` Jakub Kicinski
2025-08-19 6:32 ` [PATCH net-next v2 3/5] net: gso: restore ids of outer ip headers correctly Richard Gobert
2025-08-19 6:32 ` [PATCH net-next v2 4/5] net: gro: remove unnecessary df checks Richard Gobert
2025-08-20 11:24 ` Willem de Bruijn
2025-08-19 6:32 ` [PATCH net-next v2 5/5] selftests/net: test ipip packets in gro.sh Richard Gobert
2025-08-20 11:21 ` Willem de Bruijn
2025-08-20 12:21 ` Richard Gobert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250819173005.6b560779@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=horms@kernel.org \
--cc=kuniyu@google.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=mbloch@nvidia.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=sdf@fomichev.me \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.