All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Rohan G Thomas via B4 Relay
	<devnull+rohan.g.thomas.altera.com@kernel.org>
Cc: rohan.g.thomas@altera.com, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Serge Semin <fancer.lancer@gmail.com>,
	Romain Gantois <romain.gantois@bootlin.com>,
	Jose Abreu <Jose.Abreu@synopsys.com>,
	Ong Boon Leong <boon.leong.ong@intel.com>,
	netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Matthew Gerlach <matthew.gerlach@altera.com>
Subject: Re: [PATCH net-next v2 2/3] net: stmmac: xgmac: Correct supported speed modes
Date: Tue, 19 Aug 2025 18:19:20 -0700	[thread overview]
Message-ID: <20250819181920.275f2827@kernel.org> (raw)
In-Reply-To: <20250816-xgmac-minor-fixes-v2-2-699552cf8a7f@altera.com>

On Sat, 16 Aug 2025 00:55:24 +0800 Rohan G Thomas via B4 Relay wrote:
>  {
>  	u32 hw_cap;
>  
> +	struct stmmac_priv *priv = container_of(dma_cap, struct stmmac_priv,
> +						dma_cap);
> +
>  	/* MAC HW feature 0 */

nit: no empty lines between variable declarations and longest to
shortest, so:

 {
+	struct stmmac_priv *priv = container_of(dma_cap, struct stmmac_priv,
+						dma_cap);
 	u32 hw_cap;


  reply	other threads:[~2025-08-20  1:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-15 16:55 [PATCH net-next v2 0/3] net: stmmac: xgmac: Minor fixes Rohan G Thomas
2025-08-15 16:55 ` Rohan G Thomas via B4 Relay
2025-08-15 16:55 ` [PATCH net-next v2 1/3] net: stmmac: xgmac: Do not enable RX FIFO Overflow interrupts Rohan G Thomas
2025-08-15 16:55   ` Rohan G Thomas via B4 Relay
2025-08-15 16:55 ` [PATCH net-next v2 2/3] net: stmmac: xgmac: Correct supported speed modes Rohan G Thomas
2025-08-15 16:55   ` Rohan G Thomas via B4 Relay
2025-08-20  1:19   ` Jakub Kicinski [this message]
2025-08-20  6:57     ` G Thomas, Rohan
2025-08-15 16:55 ` [PATCH net-next v2 3/3] net: stmmac: Set CIC bit only for TX queues with COE Rohan G Thomas
2025-08-15 16:55   ` Rohan G Thomas via B4 Relay
2025-08-20  1:22   ` Jakub Kicinski
2025-08-20  7:14     ` G Thomas, Rohan
2025-08-20 15:54       ` Jakub Kicinski
2025-08-20 15:56         ` Jakub Kicinski
2025-08-21 13:50           ` G Thomas, Rohan
2025-08-21 14:17             ` Jakub Kicinski
2025-08-22 12:49               ` G Thomas, Rohan
2025-08-22 14:00                 ` Jakub Kicinski
2025-08-20  1:20 ` [PATCH net-next v2 0/3] net: stmmac: xgmac: Minor fixes Jakub Kicinski
2025-08-20  7:17   ` G Thomas, Rohan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250819181920.275f2827@kernel.org \
    --to=kuba@kernel.org \
    --cc=Jose.Abreu@synopsys.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=boon.leong.ong@intel.com \
    --cc=davem@davemloft.net \
    --cc=devnull+rohan.g.thomas.altera.com@kernel.org \
    --cc=edumazet@google.com \
    --cc=fancer.lancer@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=matthew.gerlach@altera.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rohan.g.thomas@altera.com \
    --cc=romain.gantois@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.