Re: [PATCH v2] serial: 8250 dw: clear FIFO before writting LCR

[kernel test robot <lkp@intel.com>]

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on tty/tty-next tty/tty-linus linus/master v6.17-rc2 next-20250819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/adriana-arista-com/serial-8250-dw-clear-FIFO-before-writting-LCR/20250820-031410
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link:    https://lore.kernel.org/r/20250819191314.3452283-1-adriana%40arista.com
patch subject: [PATCH v2] serial: 8250 dw: clear FIFO before writting LCR
config: i386-randconfig-002-20250820 (https://download.01.org/0day-ci/archive/20250820/202508201459.9CiUfUhb-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250820/202508201459.9CiUfUhb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508201459.9CiUfUhb-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/tty/serial/8250/8250_dw.c: In function 'dw8250_serial_outapb':
>> drivers/tty/serial/8250/8250_dw.c:267:17: error: too few arguments to function 'dw8250_check_lcr'
     267 |                 dw8250_check_lcr(p, value);
         |                 ^~~~~~~~~~~~~~~~
   drivers/tty/serial/8250/8250_dw.c:155:13: note: declared here
     155 | static void dw8250_check_lcr(struct uart_port *p, unsigned int offset, u32 value)
         |             ^~~~~~~~~~~~~~~~
   drivers/tty/serial/8250/8250_dw.c: In function 'dw8250_quirks':
>> drivers/tty/serial/8250/8250_dw.c:571:22: error: 'DW_UART_QUIRK_DWAPB' undeclared (first use in this function); did you mean 'DW_UART_QUIRK_APB'?
     571 |         if (quirks & DW_UART_QUIRK_DWAPB) {
         |                      ^~~~~~~~~~~~~~~~~~~
         |                      DW_UART_QUIRK_APB
   drivers/tty/serial/8250/8250_dw.c:571:22: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/tty/serial/8250/8250_dw.c:574:31: error: assignment to 'void (*)(struct uart_port *, unsigned int,  u32)' {aka 'void (*)(struct uart_port *, unsigned int,  unsigned int)'} from incompatible pointer type 'void (*)(struct uart_port *, int,  int)' [-Werror=incompatible-pointer-types]
     574 |                 p->serial_out = dw8250_serial_outapb;
         |                               ^
   cc1: some warnings being treated as errors


vim +/dw8250_check_lcr +267 drivers/tty/serial/8250/8250_dw.c

   254	
   255	static void dw8250_serial_outapb(struct uart_port *p, int offset, int value)
   256	{
   257	       struct dw8250_data *d = to_dw8250_data(p->private_data);
   258	
   259		if(offset == UART_LCR && !d->uart_16550_compatible)
   260			dw8250_tx_wait_empty_apb(p);
   261	
   262		writel(value, DW8250_REG(p, offset));
   263	
   264		if (offset == UART_LCR && !d->uart_16550_compatible) {
   265			/* Check FIFO is left enabled and LCR was written */
   266			writel(UART_FCR_ENABLE_FIFO, DW8250_REG(p, UART_FCR));
 > 267			dw8250_check_lcr(p, value);
   268		}
   269	}
   270	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki