From: Jisheng Zhang <jszhang@kernel.org>
To: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>, Michael Buesch <m@bues.ch>,
Hoan Tran <hoan@os.amperecomputing.com>,
Andy Shevchenko <andy@kernel.org>,
Daniel Palmer <daniel@thingy.jp>,
Romain Perier <romain.perier@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
Srinivas Neeli <srinivas.neeli@amd.com>,
Michal Simek <michal.simek@amd.com>
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux@ew.tq-group.com
Subject: [PATCH 03/16] gpio: bt8xx: Use modern PM macros
Date: Wed, 20 Aug 2025 23:40:24 +0800 [thread overview]
Message-ID: <20250820154037.22228-4-jszhang@kernel.org> (raw)
In-Reply-To: <20250820154037.22228-1-jszhang@kernel.org>
Use the modern PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.
This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
drivers/gpio/gpio-bt8xx.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/gpio/gpio-bt8xx.c b/drivers/gpio/gpio-bt8xx.c
index 05401da03ca3..5e120c4dfea5 100644
--- a/drivers/gpio/gpio-bt8xx.c
+++ b/drivers/gpio/gpio-bt8xx.c
@@ -52,10 +52,8 @@ struct bt8xxgpio {
struct pci_dev *pdev;
struct gpio_chip gpio;
-#ifdef CONFIG_PM
u32 saved_outen;
u32 saved_data;
-#endif
};
#define bgwrite(dat, adr) writel((dat), bg->mmio+(adr))
@@ -224,7 +222,6 @@ static void bt8xxgpio_remove(struct pci_dev *pdev)
pci_disable_device(pdev);
}
-#ifdef CONFIG_PM
static int bt8xxgpio_suspend(struct pci_dev *pdev, pm_message_t state)
{
struct bt8xxgpio *bg = pci_get_drvdata(pdev);
@@ -267,10 +264,6 @@ static int bt8xxgpio_resume(struct pci_dev *pdev)
return 0;
}
-#else
-#define bt8xxgpio_suspend NULL
-#define bt8xxgpio_resume NULL
-#endif /* CONFIG_PM */
static const struct pci_device_id bt8xxgpio_pci_tbl[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_BROOKTREE, PCI_DEVICE_ID_BT848) },
@@ -286,8 +279,8 @@ static struct pci_driver bt8xxgpio_pci_driver = {
.id_table = bt8xxgpio_pci_tbl,
.probe = bt8xxgpio_probe,
.remove = bt8xxgpio_remove,
- .suspend = bt8xxgpio_suspend,
- .resume = bt8xxgpio_resume,
+ .suspend = pm_ptr(bt8xxgpio_suspend),
+ .resume = pm_ptr(bt8xxgpio_resume),
};
module_pci_driver(bt8xxgpio_pci_driver);
--
2.50.1
next prev parent reply other threads:[~2025-08-20 20:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 15:40 [PATCH 00/16] gpio: Use modern PM macros Jisheng Zhang
2025-08-20 15:40 ` [PATCH 01/16] gpio: dwapb: " Jisheng Zhang
2025-08-20 16:54 ` Andy Shevchenko
2025-08-20 17:10 ` Michael Büsch
2025-08-20 19:04 ` Andy Shevchenko
2025-08-21 16:44 ` Jisheng Zhang
2025-08-21 19:32 ` Andy Shevchenko
2025-08-22 0:42 ` Jisheng Zhang
2025-08-20 15:40 ` [PATCH 02/16] gpio: brcmstb: " Jisheng Zhang
2025-08-26 21:47 ` Doug Berger
2025-08-20 15:40 ` Jisheng Zhang [this message]
2025-08-20 17:08 ` [PATCH 03/16] gpio: bt8xx: " Michael Büsch
2025-08-20 15:40 ` [PATCH 04/16] gpio: htc-egpio: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 05/16] gpio: pl061: " Jisheng Zhang
2025-08-21 11:52 ` Linus Walleij
2025-08-21 12:50 ` Andy Shevchenko
2025-08-20 15:40 ` [PATCH 06/16] gpio: pxa: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 07/16] gpio: ml-ioh: " Jisheng Zhang
2025-08-20 16:56 ` Andy Shevchenko
2025-08-20 15:40 ` [PATCH 08/16] gpio: mlxbf2: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 09/16] gpio: msc313: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 10/16] gpio: omap: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 11/16] gpio: pch: " Jisheng Zhang
2025-08-20 16:55 ` Andy Shevchenko
2025-08-20 15:40 ` [PATCH 12/16] gpio: tqmx86: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 13/16] gpio: uniphier: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 14/16] gpio: xgene: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 15/16] gpio: xilinx: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 16/16] gpio: zynq: " Jisheng Zhang
2025-08-28 13:39 ` [PATCH 00/16] gpio: " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820154037.22228-4-jszhang@kernel.org \
--to=jszhang@kernel.org \
--cc=andy@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=daniel@thingy.jp \
--cc=florian.fainelli@broadcom.com \
--cc=grygorii.strashko@ti.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=hoan@os.amperecomputing.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=m@bues.ch \
--cc=mhiramat@kernel.org \
--cc=michal.simek@amd.com \
--cc=opendmb@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=romain.perier@gmail.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.neeli@amd.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.