Re: [PATCH v7 2/6] dt-bindings: thermal: r9a09g047-tsu: Document the TSU unit

[Rob Herring <robh@kernel.org>]

On Mon, Aug 18, 2025 at 06:28:48PM +0200, John Madieu wrote:
> The Renesas RZ/G3E SoC includes a Thermal Sensor Unit (TSU) block designed
> to measure the junction temperature. The device provides real-time
> temperature measurements for thermal management, utilizing a single
> dedicated channel (channel 1) for temperature sensing.
> 
> Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>
> ---
> 
> Changes:
> 
> v1 -> v2:
>  * Fixes reg property specifier to get rid of yamlint warnings
>  * Fixes IRQ name to reflect TSU expectations
> 
> v2 -> v3:
>  * Removees useless 'renesas,tsu-operating-mode' property 
> 
> v3 -> v4:
>  * Fixes commit message
>  * Fixes interrupt description
>  * Removes trip point definition
> 
> v5: no changes
> v6: no changes
> v7: Adds documentation for 'renesas,tsu-trim' and removes Rb tag from Krzysztof
>     due to this change
> 
>  .../thermal/renesas,r9a09g047-tsu.yaml        | 87 +++++++++++++++++++
>  1 file changed, 87 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/renesas,r9a09g047-tsu.yaml
> 
> diff --git a/Documentation/devicetree/bindings/thermal/renesas,r9a09g047-tsu.yaml b/Documentation/devicetree/bindings/thermal/renesas,r9a09g047-tsu.yaml
> new file mode 100644
> index 000000000000..70d2af6fcd78
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/renesas,r9a09g047-tsu.yaml
> @@ -0,0 +1,87 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/renesas,r9a09g047-tsu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas RZ/G3E Temperature Sensor Unit (TSU)
> +
> +maintainers:
> +  - John Madieu <john.madieu.xa@bp.renesas.com>
> +
> +description:
> +  The Temperature Sensor Unit (TSU) is an integrated thermal sensor that
> +  monitors the chip temperature on the Renesas RZ/G3E SoC. The TSU provides
> +  real-time temperature measurements for thermal management.
> +
> +properties:
> +  compatible:
> +    const: renesas,r9a09g047-tsu
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +  power-domains:
> +    maxItems: 1
> +
> +  interrupts:
> +    items:
> +      - description: Conversion complete interrupt signal (pulse)
> +      - description: Comparison result interrupt signal (level)
> +
> +  interrupt-names:
> +    items:
> +      - const: adi
> +      - const: adcmpi
> +
> +  "#thermal-sensor-cells":
> +    const: 0
> +
> +  renesas,tsu-trim:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    items:
> +      - items:
> +          - description: phandle to system controller
> +          - description: offset of trim registers
> +    description: |

Don't need '|' and wrap at 80 char.

> +      Phandle and offset to the system controller containing the TSU
> +      calibration trim values. The offset points to the first trim
> +      register (OTPTSU1TRMVAL0), with the second trim register
> +      (OTPTSU1TRMVAL1) located at offset + 4.
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - resets
> +  - power-domains
> +  - interrupts
> +  - interrupt-names
> +  - "#thermal-sensor-cells"
> +  - renesas,tsu-trim
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/renesas,r9a09g047-cpg.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    tsu: thermal@14002000 {

Drop unused labels.

The prefered node name is 'thermal-sensor'.

With those,

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>