From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28B222E8B83 for ; Thu, 21 Aug 2025 07:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755760678; cv=none; b=rIAbQ3Kb27Kss98wunwICS6mcv7U8WHebf1qIb0PVMQltzLWZJhTqMtZfJcZdsvy2xwJgJJpzREdC5wF5ASSkeVDr2KcDP1YiS+1FT7TE5xnn19oQkYgmCQn3YCYVW6f/aLGaCA5k6PG/P34cyxJsyQgayvrhcH9JciPnHJCuR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755760678; c=relaxed/simple; bh=JvEAmy7Jlkc5V+Vnd1agyO6c2e8/ldDsDOAnzIwmDSE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=X4fIx8v5Jgd7js7E7aHorAva7EqV9iA+4tvIDM5CHWDg9bxzyg70oWMDhBTEqr03HvdqNdpPynNCfIImK0Mo+oB+BIHy6Hw6PUpgBtaptER8AEJnMjHfX05ZOiSlFP5RAeZfrjtrAkyKJnhBDhLO4/6AfLoKECF74h/zGpUY4iE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Lud6hz/g; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Lud6hz/g" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3c4e9efb88aso102770f8f.2 for ; Thu, 21 Aug 2025 00:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755760674; x=1756365474; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=H3tAtOi04xs7pQD42uV+iRrcb/K5gV7/3jestZ8bCUo=; b=Lud6hz/g782nx7xcdpld64iXpomaEN05vz4LuzB45RTti9ZtSGjztEvYHtttyMsFVC aArSDmMXCTOreqA7G356tSsU0SzUuMBgoyZbv03vhuB3WN953egPmc+Q/M3V+ZZRl0Og xh2GpeIIl2vsAd01BzKzU1oO0RGmG0GT2zGcx0QM0dj+Ml4MgGdqcx1z0b1m+q26pGHk 6tmJlXBWKx93GYozFjmteaWhFnZT1PKr31YZP/5iobKtk0wfcFrl8gqajcRjZvojUMe2 Z9xtZLp+SFEZBF9ggWrxYK8Nyynp9vAk3k1JNFE/HsR2JvjTvAuT5poo+XN6jRetQxB0 6imA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755760674; x=1756365474; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=H3tAtOi04xs7pQD42uV+iRrcb/K5gV7/3jestZ8bCUo=; b=lq59vp/nRlz8JAk3GrcFtjE1SlGZSBZZzT29DGj7SwOY0l3JX8DICEIP69vrl3TTRC Uad5Y/d5t/knJpRLqamIq2hiyPrex+QPcLcOs2mbxdfdRKGePLhDTqKwxAMDU9rm3nA1 y+wnJmnWALEym7orHfPmXDD758VydsZ84PazR8oVcEWN07yi0XOtUQnKBWQHrgoqokI2 WfcibwHad96Un95lc+xtoe564wsa4e/k9k4ubBXbkwOlH1lqFwPsCiHl7leS3SbfYayk WFvGyxxefUGXmL8oXOHKj4cb/Au2vFFARfIKhpoAH/gOnvQ9SDORSZEVbpwAkjhSJs3A PsHQ== X-Forwarded-Encrypted: i=1; AJvYcCUZAsYwnXb4kizzcZfJLa3ACWcWe+991Yf+1kxRqlKttz4NebF1kd/BSUC+VRLAlbt7mnLVD4Mnf3chHkjd@lists.linux.dev X-Gm-Message-State: AOJu0Yyt25TudypAol/G9nh7CjFagoPyOIJFjUhMITTxwxgHRESx2+iM LVNsZojWmIbvh0egVtzUi4Fu21GV8CXMMeaI/OLHdnUD+3PmOq2EJS/aVW1fRBNeYLg= X-Gm-Gg: ASbGncuRgR+h9YaTmx92R+rwrZEtkBzjVKmKfudYCt4YRefDaVC0MslqzrNsK4IYtLD w5cWZEiGO1494nS7IxXMG+gwrwlG1hu9cjN7OBEuIv/+FoKsTkgWVIsRmfeD9U0QB5f6IBpi+Lu ZEDz2KEtLU3OFmPhsO0Mk513GZUkUC1fIPBdiTJYj6RA3faJCVpAQkB++ygEy3Vo0y/ymD1VgBl EcEDujgNvXG6Jat4Rwy3AFV091Iq1zrlw0hlsEEwMFHCXZYyNLKkaVMrtcB5LsGh8wJtB9SnabW /477WfbBhSyFM6jWXjqT5chMs5eTjhaCR9YzEvXauPMLkabQNQA/wpNfQx6ABarkaWGkfRj1MFI uKnBectlM9Cxj8//t4iaYHZNqh0A= X-Google-Smtp-Source: AGHT+IG63iMqN7wTtRiIXVZbSCze5rPWQlrS04IFAuyrUFZ9haZV4BHRyggzdxUPlHVMATR9Za+YDA== X-Received: by 2002:a05:6000:2411:b0:3b7:8146:4640 with SMTP id ffacd0b85a97d-3c4977414d6mr1081489f8f.56.1755760674518; Thu, 21 Aug 2025 00:17:54 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45b4db29878sm15276145e9.6.2025.08.21.00.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Aug 2025 00:17:53 -0700 (PDT) Date: Thu, 21 Aug 2025 10:17:50 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Chris Morgan , linux-rockchip@lists.infradead.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, broonie@kernel.org, lee@kernel.org, lgirdwood@gmail.com, sre@kernel.org, heiko@sntech.de, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, Chris Morgan Subject: Re: [PATCH V6 4/5] regulator: bq257xx: Add bq257xx boost regulator driver Message-ID: <202508210308.Lw2Klipk-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild-all@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250812214300.123129-5-macroalpha82@gmail.com> Hi Chris, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Chris-Morgan/dt-bindings-mfd-ti-bq25703a-Add-TI-BQ25703A-Charger/20250813-054704 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next patch link: https://lore.kernel.org/r/20250812214300.123129-5-macroalpha82%40gmail.com patch subject: [PATCH V6 4/5] regulator: bq257xx: Add bq257xx boost regulator driver config: xtensa-randconfig-r073-20250819 (https://download.01.org/0day-ci/archive/20250821/202508210308.Lw2Klipk-lkp@intel.com/config) compiler: xtensa-linux-gcc (GCC) 9.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202508210308.Lw2Klipk-lkp@intel.com/ smatch warnings: drivers/regulator/bq257xx-regulator.c:132 bq257xx_reg_dt_parse_gpio() warn: passing zero to 'PTR_ERR' vim +/PTR_ERR +132 drivers/regulator/bq257xx-regulator.c d6db7dce7cd965 Chris Morgan 2025-08-12 107 static void bq257xx_reg_dt_parse_gpio(struct platform_device *pdev) d6db7dce7cd965 Chris Morgan 2025-08-12 108 { d6db7dce7cd965 Chris Morgan 2025-08-12 109 struct device_node *child, *subchild; d6db7dce7cd965 Chris Morgan 2025-08-12 110 struct bq257xx_reg_data *pdata = platform_get_drvdata(pdev); d6db7dce7cd965 Chris Morgan 2025-08-12 111 d6db7dce7cd965 Chris Morgan 2025-08-12 112 child = of_get_child_by_name(pdev->dev.of_node, d6db7dce7cd965 Chris Morgan 2025-08-12 113 pdata->desc.regulators_node); d6db7dce7cd965 Chris Morgan 2025-08-12 114 if (!child) d6db7dce7cd965 Chris Morgan 2025-08-12 115 return; d6db7dce7cd965 Chris Morgan 2025-08-12 116 d6db7dce7cd965 Chris Morgan 2025-08-12 117 subchild = of_get_child_by_name(child, pdata->desc.of_match); d6db7dce7cd965 Chris Morgan 2025-08-12 118 if (!subchild) d6db7dce7cd965 Chris Morgan 2025-08-12 119 return; d6db7dce7cd965 Chris Morgan 2025-08-12 120 d6db7dce7cd965 Chris Morgan 2025-08-12 121 of_node_put(child); d6db7dce7cd965 Chris Morgan 2025-08-12 122 d6db7dce7cd965 Chris Morgan 2025-08-12 123 pdata->otg_en_gpio = devm_fwnode_gpiod_get_index(&pdev->dev, d6db7dce7cd965 Chris Morgan 2025-08-12 124 of_fwnode_handle(subchild), d6db7dce7cd965 Chris Morgan 2025-08-12 125 "enable", 0, d6db7dce7cd965 Chris Morgan 2025-08-12 126 GPIOD_OUT_LOW, d6db7dce7cd965 Chris Morgan 2025-08-12 127 pdata->desc.of_match); d6db7dce7cd965 Chris Morgan 2025-08-12 128 d6db7dce7cd965 Chris Morgan 2025-08-12 129 of_node_put(subchild); d6db7dce7cd965 Chris Morgan 2025-08-12 130 d6db7dce7cd965 Chris Morgan 2025-08-12 131 if (IS_ERR_OR_NULL(pdata->otg_en_gpio)) { This should just be an IS_ERR() check. When a function returns a mix of error pointers and NULL, then the NULL is not an error and shouldn't result in an error message. https://staticthinking.wordpress.com/2022/08/01/mixing-error-pointers-and-null/ Here devm_fwnode_gpiod_get_index() can't actually return NULL so it doesn't matter, I suppose. d6db7dce7cd965 Chris Morgan 2025-08-12 @132 dev_err(&pdev->dev, "Error getting enable gpio: %ld\n", d6db7dce7cd965 Chris Morgan 2025-08-12 133 PTR_ERR(pdata->otg_en_gpio)); d6db7dce7cd965 Chris Morgan 2025-08-12 134 return; d6db7dce7cd965 Chris Morgan 2025-08-12 135 } d6db7dce7cd965 Chris Morgan 2025-08-12 136 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0A12186284 for ; Wed, 20 Aug 2025 20:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755720340; cv=none; b=NxDlU7mIzDymRaJzxXaQZ7gxqDPj0RpDAhDhi50Mq8VWLtAsO6GcA0hGKQdtnEwz0HIH/uj5p+2dtRJ1ue93Rvpen4BCvU+BIv9SYGhoMCnIsFYmZX+glqlcQ0IrClqNVwrWjjNWDi4Wlu6gsDXiGEDWEffn2iTIV68/hHJENiw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755720340; c=relaxed/simple; bh=2RWktT5TDM8Ywl1RSPubvd6fNkTvo/z/55ZEJAp+43U=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=H7TAVL2zthLfnpkLiIwKwv0hahbrqNpoud83RE5kNPfjgR1wpcgmFGmBBbjorlQrtFXgFa8Ec3+mpw1LaGd4+hYAqt/84EVLF71PCLEX8+DJh1kd/S7Z3O656lD6kLC4riryjEY6XvYEkKyYZU4U8yLF+zPBaGiqm7kE5YAepuE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GxNoiCa5; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GxNoiCa5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1755720339; x=1787256339; h=date:from:to:cc:subject:message-id:mime-version; bh=2RWktT5TDM8Ywl1RSPubvd6fNkTvo/z/55ZEJAp+43U=; b=GxNoiCa5R4Ca0yBUrR645WoRd7sbEgj04g9wG1stx1TDwijFsT4/MtxU 2bgTeNEsATtx3BSO7kstAt+GRtm1V4EDyg1TwfRGbaI/BOo4SaMJsjn7u 9uHuRprtaPo7S9VuveyRVLSGuw65BQDCDUKwnJ7vMHpQ3c+uACHR1js1f 1gsny+8byNMB/CqQ6IvvIzhCHSTw/ShScHIFEcuUi43nzP1PtZ9QPHxRm kWmKn6kJIZsz2mfKVoJjFSi/ROZxiCvukzexsJQowSscZML8DhWJnDxGW 1cqJKUC1hZC9d/MFeNXQECNrF4xkZyj4CBgZkhn87HWtdvKTiCG1n0hlB Q==; X-CSE-ConnectionGUID: LhQCqSJ4SAeufvDmhKunTg== X-CSE-MsgGUID: KWpYdUv6Qgq2HEITUUKmzA== X-IronPort-AV: E=McAfee;i="6800,10657,11527"; a="58066014" X-IronPort-AV: E=Sophos;i="6.17,306,1747724400"; d="scan'208";a="58066014" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2025 13:05:38 -0700 X-CSE-ConnectionGUID: 8e68twqfQAqvZU5hVY/lHw== X-CSE-MsgGUID: d3E1dl71Rr2O0VwkUX60Fg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,306,1747724400"; d="scan'208";a="172478742" Received: from lkp-server02.sh.intel.com (HELO 4ea60e6ab079) ([10.239.97.151]) by fmviesa005.fm.intel.com with ESMTP; 20 Aug 2025 13:05:36 -0700 Received: from kbuild by 4ea60e6ab079 with local (Exim 4.96) (envelope-from ) id 1uop3u-000JeN-1t; Wed, 20 Aug 2025 20:05:34 +0000 Date: Thu, 21 Aug 2025 04:05:03 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: Re: [PATCH V6 4/5] regulator: bq257xx: Add bq257xx boost regulator driver Message-ID: <202508210308.Lw2Klipk-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev In-Reply-To: <20250812214300.123129-5-macroalpha82@gmail.com> References: <20250812214300.123129-5-macroalpha82@gmail.com> TO: Chris Morgan TO: linux-rockchip@lists.infradead.org CC: linux-pm@vger.kernel.org CC: devicetree@vger.kernel.org CC: broonie@kernel.org CC: lee@kernel.org CC: lgirdwood@gmail.com CC: sre@kernel.org CC: heiko@sntech.de CC: conor+dt@kernel.org CC: krzk+dt@kernel.org CC: robh@kernel.org CC: Chris Morgan Hi Chris, kernel test robot noticed the following build warnings: [auto build test WARNING on broonie-regulator/for-next] [also build test WARNING on sre-power-supply/for-next rockchip/for-next linus/master v6.17-rc2 next-20250820] [cannot apply to lee-mfd/for-mfd-next lee-mfd/for-mfd-fixes] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Chris-Morgan/dt-bindings-mfd-ti-bq25703a-Add-TI-BQ25703A-Charger/20250813-054704 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next patch link: https://lore.kernel.org/r/20250812214300.123129-5-macroalpha82%40gmail.com patch subject: [PATCH V6 4/5] regulator: bq257xx: Add bq257xx boost regulator driver :::::: branch date: 8 days ago :::::: commit date: 8 days ago config: xtensa-randconfig-r073-20250819 (https://download.01.org/0day-ci/archive/20250821/202508210308.Lw2Klipk-lkp@intel.com/config) compiler: xtensa-linux-gcc (GCC) 9.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202508210308.Lw2Klipk-lkp@intel.com/ smatch warnings: drivers/regulator/bq257xx-regulator.c:132 bq257xx_reg_dt_parse_gpio() warn: passing zero to 'PTR_ERR' vim +/PTR_ERR +132 drivers/regulator/bq257xx-regulator.c d6db7dce7cd965 Chris Morgan 2025-08-12 105 d6db7dce7cd965 Chris Morgan 2025-08-12 106 /* Get optional GPIO for OTG regulator enable. */ d6db7dce7cd965 Chris Morgan 2025-08-12 107 static void bq257xx_reg_dt_parse_gpio(struct platform_device *pdev) d6db7dce7cd965 Chris Morgan 2025-08-12 108 { d6db7dce7cd965 Chris Morgan 2025-08-12 109 struct device_node *child, *subchild; d6db7dce7cd965 Chris Morgan 2025-08-12 110 struct bq257xx_reg_data *pdata = platform_get_drvdata(pdev); d6db7dce7cd965 Chris Morgan 2025-08-12 111 d6db7dce7cd965 Chris Morgan 2025-08-12 112 child = of_get_child_by_name(pdev->dev.of_node, d6db7dce7cd965 Chris Morgan 2025-08-12 113 pdata->desc.regulators_node); d6db7dce7cd965 Chris Morgan 2025-08-12 114 if (!child) d6db7dce7cd965 Chris Morgan 2025-08-12 115 return; d6db7dce7cd965 Chris Morgan 2025-08-12 116 d6db7dce7cd965 Chris Morgan 2025-08-12 117 subchild = of_get_child_by_name(child, pdata->desc.of_match); d6db7dce7cd965 Chris Morgan 2025-08-12 118 if (!subchild) d6db7dce7cd965 Chris Morgan 2025-08-12 119 return; d6db7dce7cd965 Chris Morgan 2025-08-12 120 d6db7dce7cd965 Chris Morgan 2025-08-12 121 of_node_put(child); d6db7dce7cd965 Chris Morgan 2025-08-12 122 d6db7dce7cd965 Chris Morgan 2025-08-12 123 pdata->otg_en_gpio = devm_fwnode_gpiod_get_index(&pdev->dev, d6db7dce7cd965 Chris Morgan 2025-08-12 124 of_fwnode_handle(subchild), d6db7dce7cd965 Chris Morgan 2025-08-12 125 "enable", 0, d6db7dce7cd965 Chris Morgan 2025-08-12 126 GPIOD_OUT_LOW, d6db7dce7cd965 Chris Morgan 2025-08-12 127 pdata->desc.of_match); d6db7dce7cd965 Chris Morgan 2025-08-12 128 d6db7dce7cd965 Chris Morgan 2025-08-12 129 of_node_put(subchild); d6db7dce7cd965 Chris Morgan 2025-08-12 130 d6db7dce7cd965 Chris Morgan 2025-08-12 131 if (IS_ERR_OR_NULL(pdata->otg_en_gpio)) { d6db7dce7cd965 Chris Morgan 2025-08-12 @132 dev_err(&pdev->dev, "Error getting enable gpio: %ld\n", d6db7dce7cd965 Chris Morgan 2025-08-12 133 PTR_ERR(pdata->otg_en_gpio)); d6db7dce7cd965 Chris Morgan 2025-08-12 134 return; d6db7dce7cd965 Chris Morgan 2025-08-12 135 } d6db7dce7cd965 Chris Morgan 2025-08-12 136 } d6db7dce7cd965 Chris Morgan 2025-08-12 137 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C16D9CA0FE5 for ; Thu, 21 Aug 2025 09:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=IITjoLFeoIzL9Y6Kc1Ih4QpHMn1jN/fCPsVkeHuNTmc=; b=3fOo8VrDJs4GS5 IIb6h8dB15sCAvJ9/sXzaruj78Soa0gMZIZKT5PJURvYXlxn0shxaqtTZRFjM80jAc465TQt1982s iIynDRWHS08RplhXA+YEpWKlfKl6kO9mpaSIbbx2vf1wK0XKkkvOdvQ7VpHuL99NCCMw1Eops6+zZ bSRJ8n2nYsGIbHaNoF0bmJw+p9oOaKWIff6U+aAHJ4J3h5mlePvaSVwUs39I80YmkhmLGH3nmWD1+ +Y61c/bgwPXgNUwTsou5lEs4BopDG+H60QcsZblPWd1kTqMU+IIZSCjpsP2S7nWT24qlZ0sIfu8+F XJG2fjUvCdh+h1Od9KvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1up1lo-0000000GQEc-2Nai; Thu, 21 Aug 2025 09:39:44 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uozYa-0000000G4w1-0YKF for linux-rockchip@lists.infradead.org; Thu, 21 Aug 2025 07:17:57 +0000 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3b9e411c820so398680f8f.1 for ; Thu, 21 Aug 2025 00:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755760674; x=1756365474; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=H3tAtOi04xs7pQD42uV+iRrcb/K5gV7/3jestZ8bCUo=; b=l7T+OrLtHo4FODBq8w9K1/326KvhBvYpHik0oUQcU2u4xtSJa+s0FEb43ZKKSKzv3K svr5jhEYMzvlwANYKlzcHRV8Cd2jOXWnknJmowL/vhKOjodHH372cwsFP4LnRPYpPvsD H+LQ9JAlDHkkJ8g8YUynrSJRH7G7YNH1tee9qjNObF0RreQ+fEHkQk+xnkAgMxMIKDwd 6XzqYvO6NeHiJMQmuDQvbsN6R3Tnexa0MSRbze4OrrYGvrUxffRBQjfaKymwdmh4D/g0 fTeLDXtiCzmiBTymgQK/1ZD6xYYzKrpJBt07mO/VeCNHT479r/qn6ysfRhxDrAfPleXQ brlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755760674; x=1756365474; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=H3tAtOi04xs7pQD42uV+iRrcb/K5gV7/3jestZ8bCUo=; b=wPLO+e75CmmXISzPmhk9XEYvCi6t5h62bjR7PBM7radkGgquagaHopF7i59uVQAkxc CgSpiE4Y2W2I7OAlIBYWIKG4VNTMvQ7UJ4SM+4pSxz9mvdJUCPw4SjyPnkawrBIharBD bN59Vex57n1rYC8dxhipnuX93KekyMyriZDgcu7Y+u6twlHyOKT9D/rGZZcNjtTobOuW LjLnZ9Z69i/52nBQ5vlpPJ/FokcnVu60Fap3Tu1O1EYcsGj9MZYLZf5j6pgJLbF6eQii LZXEDuK3LcLV6d7Cl5LlKO+O2ww9FTXP05WS7c1BSHK8tzNjV0niR2bfikAzspwp6fzS NEkg== X-Forwarded-Encrypted: i=1; AJvYcCUB1yYwbzHEQ5hKMADPfERSW6I8hbPW4pjdF/rZeMO1L14WrzrxdFGE13z0xaY2fuoO5hLsnS3fxXSxwRis5g==@lists.infradead.org X-Gm-Message-State: AOJu0Yy5PsgeUuOCsOAz5RON4Q86Dj8bDARCkU/MEIpczPVv2x/w0VOk NzISYbNgiCy9m7vMEJ/moaO6j+vMC9/vE8qmbA3L7fft6LguyHd1vYiOz52fgsN2yGA= X-Gm-Gg: ASbGnct4fSFlYq0ZPQP/ZTyDTN19NIYFpftqoDIsA+trzo+xB01Wzh+WbkXg3VgM9z7 S35aX9LSoIEBEp8SeN22TPIR/7M1xC8a8bSvWM+gxJ5owZ2QfJZtjNA+EmcFawwYErRFzHwU0Iy K0vjA20n3WdBfvYDKi+a3ojIlet7IIZXax1RtRS/+sNFGllaUE297/4ktdomxLNa4DcETXEl05m 4zXlbWBj09iJ2aFqUU2524EGAzQTU+29YyxDPGZQ4DiI5Cc+qwZMVGDqgojRRQlBU5SB7YMk9jp iwSeOggNKUT2l1GtaDDcuJpDSlac75bMQkVdprCI6I0b56gT9gcsy0X9eUhdXlokHtuyc0TysnH 1F4m7F43y/MqPAxfAbjH+v0QeHik= X-Google-Smtp-Source: AGHT+IG63iMqN7wTtRiIXVZbSCze5rPWQlrS04IFAuyrUFZ9haZV4BHRyggzdxUPlHVMATR9Za+YDA== X-Received: by 2002:a05:6000:2411:b0:3b7:8146:4640 with SMTP id ffacd0b85a97d-3c4977414d6mr1081489f8f.56.1755760674518; Thu, 21 Aug 2025 00:17:54 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45b4db29878sm15276145e9.6.2025.08.21.00.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Aug 2025 00:17:53 -0700 (PDT) Date: Thu, 21 Aug 2025 10:17:50 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Chris Morgan , linux-rockchip@lists.infradead.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, broonie@kernel.org, lee@kernel.org, lgirdwood@gmail.com, sre@kernel.org, heiko@sntech.de, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, Chris Morgan Subject: Re: [PATCH V6 4/5] regulator: bq257xx: Add bq257xx boost regulator driver Message-ID: <202508210308.Lw2Klipk-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250812214300.123129-5-macroalpha82@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250821_001756_185655_CC2559D9 X-CRM114-Status: UNSURE ( 8.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Chris, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Chris-Morgan/dt-bindings-mfd-ti-bq25703a-Add-TI-BQ25703A-Charger/20250813-054704 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next patch link: https://lore.kernel.org/r/20250812214300.123129-5-macroalpha82%40gmail.com patch subject: [PATCH V6 4/5] regulator: bq257xx: Add bq257xx boost regulator driver config: xtensa-randconfig-r073-20250819 (https://download.01.org/0day-ci/archive/20250821/202508210308.Lw2Klipk-lkp@intel.com/config) compiler: xtensa-linux-gcc (GCC) 9.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202508210308.Lw2Klipk-lkp@intel.com/ smatch warnings: drivers/regulator/bq257xx-regulator.c:132 bq257xx_reg_dt_parse_gpio() warn: passing zero to 'PTR_ERR' vim +/PTR_ERR +132 drivers/regulator/bq257xx-regulator.c d6db7dce7cd965 Chris Morgan 2025-08-12 107 static void bq257xx_reg_dt_parse_gpio(struct platform_device *pdev) d6db7dce7cd965 Chris Morgan 2025-08-12 108 { d6db7dce7cd965 Chris Morgan 2025-08-12 109 struct device_node *child, *subchild; d6db7dce7cd965 Chris Morgan 2025-08-12 110 struct bq257xx_reg_data *pdata = platform_get_drvdata(pdev); d6db7dce7cd965 Chris Morgan 2025-08-12 111 d6db7dce7cd965 Chris Morgan 2025-08-12 112 child = of_get_child_by_name(pdev->dev.of_node, d6db7dce7cd965 Chris Morgan 2025-08-12 113 pdata->desc.regulators_node); d6db7dce7cd965 Chris Morgan 2025-08-12 114 if (!child) d6db7dce7cd965 Chris Morgan 2025-08-12 115 return; d6db7dce7cd965 Chris Morgan 2025-08-12 116 d6db7dce7cd965 Chris Morgan 2025-08-12 117 subchild = of_get_child_by_name(child, pdata->desc.of_match); d6db7dce7cd965 Chris Morgan 2025-08-12 118 if (!subchild) d6db7dce7cd965 Chris Morgan 2025-08-12 119 return; d6db7dce7cd965 Chris Morgan 2025-08-12 120 d6db7dce7cd965 Chris Morgan 2025-08-12 121 of_node_put(child); d6db7dce7cd965 Chris Morgan 2025-08-12 122 d6db7dce7cd965 Chris Morgan 2025-08-12 123 pdata->otg_en_gpio = devm_fwnode_gpiod_get_index(&pdev->dev, d6db7dce7cd965 Chris Morgan 2025-08-12 124 of_fwnode_handle(subchild), d6db7dce7cd965 Chris Morgan 2025-08-12 125 "enable", 0, d6db7dce7cd965 Chris Morgan 2025-08-12 126 GPIOD_OUT_LOW, d6db7dce7cd965 Chris Morgan 2025-08-12 127 pdata->desc.of_match); d6db7dce7cd965 Chris Morgan 2025-08-12 128 d6db7dce7cd965 Chris Morgan 2025-08-12 129 of_node_put(subchild); d6db7dce7cd965 Chris Morgan 2025-08-12 130 d6db7dce7cd965 Chris Morgan 2025-08-12 131 if (IS_ERR_OR_NULL(pdata->otg_en_gpio)) { This should just be an IS_ERR() check. When a function returns a mix of error pointers and NULL, then the NULL is not an error and shouldn't result in an error message. https://staticthinking.wordpress.com/2022/08/01/mixing-error-pointers-and-null/ Here devm_fwnode_gpiod_get_index() can't actually return NULL so it doesn't matter, I suppose. d6db7dce7cd965 Chris Morgan 2025-08-12 @132 dev_err(&pdev->dev, "Error getting enable gpio: %ld\n", d6db7dce7cd965 Chris Morgan 2025-08-12 133 PTR_ERR(pdata->otg_en_gpio)); d6db7dce7cd965 Chris Morgan 2025-08-12 134 return; d6db7dce7cd965 Chris Morgan 2025-08-12 135 } d6db7dce7cd965 Chris Morgan 2025-08-12 136 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip