From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 974212EFD91 for ; Thu, 21 Aug 2025 08:21:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755764499; cv=none; b=poi81XD8GRawseLgCD+SAP8jn/3BiAc7g1ZFW/ktVMuk+pioOahlvIBVLfVfbvMvXPrnhQtA2rRDINPZUJ002nCp8zcXBIWi4cPCBsZg5G99iiS24pJ7UnxL/nF0SsBwej27Zs3WZ+yGJlt/NZwPYokmguhGg5frt0oQuDM6Ifc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755764499; c=relaxed/simple; bh=JXocULCsBo7/n98cmVoNOqykInxPZnjLVNBTREPdg0Q=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=k1EEZ+6SM1n6lrgHx9yLOGpJ/WwX8iaAtt+3M63vWJ5pzmy+1O6E9xZjyrrbwory1YpoXWKdQkHEJSLPGeriXs7RCbDLC2VP26gWcG5/UArT6YoHkBHooHtk2kykLG6KmI3dzQx+9PeUXZNbsng+yBas8/mIxHcrcoEyX5iKGBQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EvAQtQJR; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EvAQtQJR" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3c44dfa7739so183412f8f.1 for ; Thu, 21 Aug 2025 01:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755764494; x=1756369294; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6F9MVHoGttGvZi9mtKapX8wE+xXVK++WzjAWqNNFy5w=; b=EvAQtQJRBlzT+epmpzEGGEcEY7UGGykjJRQtuStcTnJUSxJpMyfmZSWg7BwV9Dixjo zhHmcj6cB0iJOeQgGrQhHTfJM/pOcpUdpIwwCP+aDM27Gfm2xnNx3VSmtTneSmSON35b VQZP71R5T8y7UPfxm1PDf9Cg1Ij5kOMJvyXLvp6T1is+eiiHzyBVqoS3989so+nlv0dQ sfGdj3T4lOO/+a7qqRHVecwyJh5/jUoToAYbzX4fT2CoGTMFS+hi1PVPdjvZ/hmAkcMs V5re3CDOgQ5uTjKDo5iwm0E0E2M80scVKAy/Om4rWG1RL9joOKf388UTeanSlOCGSdnJ n1oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755764494; x=1756369294; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6F9MVHoGttGvZi9mtKapX8wE+xXVK++WzjAWqNNFy5w=; b=rZsOE5XoAhi7IBze/FjSeRppwniHTK2o+gbbfs0XAyiVyU4bmYC7XY+sV7uM7/vjBG FJyMh5yEeGrDqJYJ3NR6C8WhJeW2eFu8lE+hUF7V9CMZSdseY6c0KOjMKyE1tJHLcIxO P5MvRPSS4GkA0rGdievLbKLwfxU3LwhAszyU3MrEviH1Rr4QLElfK4ed8X8G1qljkJeF G6CiCKZfvHJE6WZV7oXO2o7Mj7zKVlL9Oyg/uQcacmD55o8Vj3zFmkRLnZOVVx5ohyt3 jzN7dGHE/A2EYfx4/LxVRZN/8aqZIz3BlpRDQGt6vWiQeEvm5tM+YUksrT9pPzp0UYpH Pszw== X-Forwarded-Encrypted: i=1; AJvYcCV7rB8k2+8mboFePBA0KVr5VqNkPL0oOifq8l/zY7sTp2p3/gYEMXeRoAe8uFYzfm1rU6w5ddExWadRhA==@vger.kernel.org X-Gm-Message-State: AOJu0YwnLKLeUMgurlJwmOT6BRsrRJNXavSb1Lj8E4CsZPrJ4Eypulqg zR+WfSfIAct7fZXpc+jbbDlWtx7q4JBMpO4ZZ8PiG6eRGE2x2VPuU1tMdnwwXYsYbCw= X-Gm-Gg: ASbGncu8WVyI9GFm88JLfU41iayy2mxLcxX4vMib9gM9qwxmUlrNyHMH0wk5wBedwDp 6/b+TrI/P4fsmyt2UAGJfR6l1vJFj7kxY7m6E+wXm39XJDjsAa57FZdxcdzimCIDaiD5zhg+Qjf L0dO4LWZRsvpJ8+iG5fc8hi5zqLht7vjGWD75ksXYuyhHfxUUtap/Q4Q9Ya8ejp4RXl/d4DwTRC szyqShsL2bfCqu0hwMVU1mH/vhc6rgLYQYq8T9uggbqgfHzFagLZrPIcKYxhmNNMDqbOZ6TnSY+ +JJdHlPwTijYu3A/4Vzc1GOvSNa+3hhtNb76GGOoB2T06dk7yrLy1UMQTWIrifz7/0J9nu5FW1u IspgO/SnsezBvLtS6jWA8CcefUE8= X-Google-Smtp-Source: AGHT+IEEH9J16IEfY7X5Ab8U3awn2/tTG/DyRWYmbtluKFWJrwnSi/zTjuUtoKU2yasvK1jGjM/f0A== X-Received: by 2002:a05:6000:2911:b0:3b7:9d87:9808 with SMTP id ffacd0b85a97d-3c4b0445cbcmr1346807f8f.15.1755764494525; Thu, 21 Aug 2025 01:21:34 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3c07487986fsm11782149f8f.1.2025.08.21.01.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Aug 2025 01:21:34 -0700 (PDT) Date: Thu, 21 Aug 2025 11:21:30 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Sun YangKai , linux-btrfs@vger.kernel.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Sun YangKai Subject: Re: [PATCH] btrfs: more trivial BTRFS_PATH_AUTO_FREE conversions Message-ID: <202508211534.QmDKCbTm-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250819033819.19826-1-sunk67188@gmail.com> Hi Sun, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Sun-YangKai/btrfs-more-trivial-BTRFS_PATH_AUTO_FREE-conversions/20250819-114252 base: v6.17-rc2 patch link: https://lore.kernel.org/r/20250819033819.19826-1-sunk67188%40gmail.com patch subject: [PATCH] btrfs: more trivial BTRFS_PATH_AUTO_FREE conversions config: parisc-randconfig-r071-20250821 (https://download.01.org/0day-ci/archive/20250821/202508211534.QmDKCbTm-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 9.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202508211534.QmDKCbTm-lkp@intel.com/ smatch warnings: fs/btrfs/send.c:931 get_inode_info() warn: missing error code? 'ret' vim +/ret +931 fs/btrfs/send.c 7e93f6dc11d9128 BingJing Chang 2022-08-12 908 static int get_inode_info(struct btrfs_root *root, u64 ino, 7e93f6dc11d9128 BingJing Chang 2022-08-12 909 struct btrfs_inode_info *info) 31db9f7c23fbf7e Alexander Block 2012-07-25 910 { 31db9f7c23fbf7e Alexander Block 2012-07-25 911 int ret; c8ce1e5fe626333 Sun YangKai 2025-08-19 912 BTRFS_PATH_AUTO_FREE(path); 31db9f7c23fbf7e Alexander Block 2012-07-25 913 struct btrfs_inode_item *ii; 31db9f7c23fbf7e Alexander Block 2012-07-25 914 struct btrfs_key key; 31db9f7c23fbf7e Alexander Block 2012-07-25 915 7e93f6dc11d9128 BingJing Chang 2022-08-12 916 path = alloc_path_for_send(); 7e93f6dc11d9128 BingJing Chang 2022-08-12 917 if (!path) 7e93f6dc11d9128 BingJing Chang 2022-08-12 918 return -ENOMEM; 7e93f6dc11d9128 BingJing Chang 2022-08-12 919 31db9f7c23fbf7e Alexander Block 2012-07-25 920 key.objectid = ino; 31db9f7c23fbf7e Alexander Block 2012-07-25 921 key.type = BTRFS_INODE_ITEM_KEY; 31db9f7c23fbf7e Alexander Block 2012-07-25 922 key.offset = 0; 31db9f7c23fbf7e Alexander Block 2012-07-25 923 ret = btrfs_search_slot(NULL, root, &key, path, 0, 0); 31db9f7c23fbf7e Alexander Block 2012-07-25 924 if (ret) { 3f8a18cc53bd1be Josef Bacik 2014-03-28 925 if (ret > 0) 31db9f7c23fbf7e Alexander Block 2012-07-25 926 ret = -ENOENT; c8ce1e5fe626333 Sun YangKai 2025-08-19 927 return ret; 31db9f7c23fbf7e Alexander Block 2012-07-25 928 } 31db9f7c23fbf7e Alexander Block 2012-07-25 929 7e93f6dc11d9128 BingJing Chang 2022-08-12 930 if (!info) c8ce1e5fe626333 Sun YangKai 2025-08-19 @931 return ret; ret is zero, but it should be an error code. 7e93f6dc11d9128 BingJing Chang 2022-08-12 932 31db9f7c23fbf7e Alexander Block 2012-07-25 933 ii = btrfs_item_ptr(path->nodes[0], path->slots[0], 31db9f7c23fbf7e Alexander Block 2012-07-25 934 struct btrfs_inode_item); 7e93f6dc11d9128 BingJing Chang 2022-08-12 935 info->size = btrfs_inode_size(path->nodes[0], ii); 7e93f6dc11d9128 BingJing Chang 2022-08-12 936 info->gen = btrfs_inode_generation(path->nodes[0], ii); -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65A0D296BA6 for ; Thu, 21 Aug 2025 07:59:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755763181; cv=none; b=dp8Jw26DUB3kJPsukno2B6igX7NvDFKJ2h8UTW9MraQnmLIh84D2YW42Jngs14MoKLLT2g03cXqyWoJi7cjA/Ymg9q/HbPTUO7Ltrt77YsgdTqqm+VARack3FtNeepxc8FDO/rBAwDGz0VqCwtwaFj2M+JxX/exbZog8DdSwDt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755763181; c=relaxed/simple; bh=qKdOEmS28tdDhqlXtuaBqaPluUCoqiC0kPrNcvbd5BM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Ho+XYA5aGvLNPfVZKC8ZUaV3dOAE8MxhlG7o9rWRKm35djT84NjLiVHuKZo7afTUDT/NvFtaYsPrit+8poTQHxeyCWxDY2l96ZFGvI+V1kq0BV8ikqRgKqE+l5u+hdgwwu1ARUaOaKTheBUJpJHbo/g0udXV0CZp1103h95Ving= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YhRJMurq; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YhRJMurq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1755763179; x=1787299179; h=date:from:to:cc:subject:message-id:mime-version; bh=qKdOEmS28tdDhqlXtuaBqaPluUCoqiC0kPrNcvbd5BM=; b=YhRJMurqOAjJwjzgbFXcVy7OkwbzdOrwXZ6etgkZh8UxdfyGZLo2w8HT 2nZ58ghfVQA4uqwakC/Ii+yYq+fkKM0R9M+mj0X53piZTxQVebP9IpwHe 6sagzzfKa9AGORB2aBHtaAm1RJCJ+nUM50WB/At207ZHuQcPX9xcWPgSO ix8OaIYDcfd/BEGJQN/NIs5oMhMrU48BlXMi49ey6KJQR4SZsmgrDh6ft zqcVCsVQJPS2BNUxAv6BYtInRJxtubFrJSpvhv2FvH/3Z0xDW1TszpsJa vDDLrVkPC2a9E670T6hP34MBfCjsgxITkd3yKuuon5Xlc7iKr9xA2W4TL A==; X-CSE-ConnectionGUID: lGKPH+KvQQiI9ljSIj8uKw== X-CSE-MsgGUID: FDtc7QwtQDa3dYgvILhFcQ== X-IronPort-AV: E=McAfee;i="6800,10657,11527"; a="60673341" X-IronPort-AV: E=Sophos;i="6.17,306,1747724400"; d="scan'208";a="60673341" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2025 00:59:32 -0700 X-CSE-ConnectionGUID: YR+o06Y9RuaOYtpZ/z+SSw== X-CSE-MsgGUID: Vg7pWIoMScaJxVXhHIgoGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,306,1747724400"; d="scan'208";a="168267346" Received: from lkp-server02.sh.intel.com (HELO 4ea60e6ab079) ([10.239.97.151]) by orviesa007.jf.intel.com with ESMTP; 21 Aug 2025 00:59:29 -0700 Received: from kbuild by 4ea60e6ab079 with local (Exim 4.96) (envelope-from ) id 1up0Cl-000K4F-08; Thu, 21 Aug 2025 07:59:27 +0000 Date: Thu, 21 Aug 2025 15:58:29 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: Re: [PATCH] btrfs: more trivial BTRFS_PATH_AUTO_FREE conversions Message-ID: <202508211534.QmDKCbTm-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev In-Reply-To: <20250819033819.19826-1-sunk67188@gmail.com> References: <20250819033819.19826-1-sunk67188@gmail.com> TO: Sun YangKai TO: linux-btrfs@vger.kernel.org CC: Sun YangKai Hi Sun, kernel test robot noticed the following build warnings: [auto build test WARNING on v6.17-rc2] [also build test WARNING on linus/master next-20250820] [cannot apply to kdave/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Sun-YangKai/btrfs-more-trivial-BTRFS_PATH_AUTO_FREE-conversions/20250819-114252 base: v6.17-rc2 patch link: https://lore.kernel.org/r/20250819033819.19826-1-sunk67188%40gmail.com patch subject: [PATCH] btrfs: more trivial BTRFS_PATH_AUTO_FREE conversions :::::: branch date: 2 days ago :::::: commit date: 2 days ago config: parisc-randconfig-r071-20250821 (https://download.01.org/0day-ci/archive/20250821/202508211534.QmDKCbTm-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 9.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202508211534.QmDKCbTm-lkp@intel.com/ smatch warnings: fs/btrfs/send.c:931 get_inode_info() warn: missing error code? 'ret' vim +/ret +931 fs/btrfs/send.c 7e93f6dc11d9128 BingJing Chang 2022-08-12 904 31db9f7c23fbf7e Alexander Block 2012-07-25 905 /* 31db9f7c23fbf7e Alexander Block 2012-07-25 906 * Helper function to retrieve some fields from an inode item. 31db9f7c23fbf7e Alexander Block 2012-07-25 907 */ 7e93f6dc11d9128 BingJing Chang 2022-08-12 908 static int get_inode_info(struct btrfs_root *root, u64 ino, 7e93f6dc11d9128 BingJing Chang 2022-08-12 909 struct btrfs_inode_info *info) 31db9f7c23fbf7e Alexander Block 2012-07-25 910 { 31db9f7c23fbf7e Alexander Block 2012-07-25 911 int ret; c8ce1e5fe626333 Sun YangKai 2025-08-19 912 BTRFS_PATH_AUTO_FREE(path); 31db9f7c23fbf7e Alexander Block 2012-07-25 913 struct btrfs_inode_item *ii; 31db9f7c23fbf7e Alexander Block 2012-07-25 914 struct btrfs_key key; 31db9f7c23fbf7e Alexander Block 2012-07-25 915 7e93f6dc11d9128 BingJing Chang 2022-08-12 916 path = alloc_path_for_send(); 7e93f6dc11d9128 BingJing Chang 2022-08-12 917 if (!path) 7e93f6dc11d9128 BingJing Chang 2022-08-12 918 return -ENOMEM; 7e93f6dc11d9128 BingJing Chang 2022-08-12 919 31db9f7c23fbf7e Alexander Block 2012-07-25 920 key.objectid = ino; 31db9f7c23fbf7e Alexander Block 2012-07-25 921 key.type = BTRFS_INODE_ITEM_KEY; 31db9f7c23fbf7e Alexander Block 2012-07-25 922 key.offset = 0; 31db9f7c23fbf7e Alexander Block 2012-07-25 923 ret = btrfs_search_slot(NULL, root, &key, path, 0, 0); 31db9f7c23fbf7e Alexander Block 2012-07-25 924 if (ret) { 3f8a18cc53bd1be Josef Bacik 2014-03-28 925 if (ret > 0) 31db9f7c23fbf7e Alexander Block 2012-07-25 926 ret = -ENOENT; c8ce1e5fe626333 Sun YangKai 2025-08-19 927 return ret; 31db9f7c23fbf7e Alexander Block 2012-07-25 928 } 31db9f7c23fbf7e Alexander Block 2012-07-25 929 7e93f6dc11d9128 BingJing Chang 2022-08-12 930 if (!info) c8ce1e5fe626333 Sun YangKai 2025-08-19 @931 return ret; 7e93f6dc11d9128 BingJing Chang 2022-08-12 932 31db9f7c23fbf7e Alexander Block 2012-07-25 933 ii = btrfs_item_ptr(path->nodes[0], path->slots[0], 31db9f7c23fbf7e Alexander Block 2012-07-25 934 struct btrfs_inode_item); 7e93f6dc11d9128 BingJing Chang 2022-08-12 935 info->size = btrfs_inode_size(path->nodes[0], ii); 7e93f6dc11d9128 BingJing Chang 2022-08-12 936 info->gen = btrfs_inode_generation(path->nodes[0], ii); 7e93f6dc11d9128 BingJing Chang 2022-08-12 937 info->mode = btrfs_inode_mode(path->nodes[0], ii); 7e93f6dc11d9128 BingJing Chang 2022-08-12 938 info->uid = btrfs_inode_uid(path->nodes[0], ii); 7e93f6dc11d9128 BingJing Chang 2022-08-12 939 info->gid = btrfs_inode_gid(path->nodes[0], ii); 7e93f6dc11d9128 BingJing Chang 2022-08-12 940 info->rdev = btrfs_inode_rdev(path->nodes[0], ii); 9ed0a72e5b355d4 BingJing Chang 2022-08-12 941 info->nlink = btrfs_inode_nlink(path->nodes[0], ii); 4824735918a1b7f David Sterba 2022-05-18 942 /* 4824735918a1b7f David Sterba 2022-05-18 943 * Transfer the unchanged u64 value of btrfs_inode_item::flags, that's 4824735918a1b7f David Sterba 2022-05-18 944 * otherwise logically split to 32/32 parts. 4824735918a1b7f David Sterba 2022-05-18 945 */ 7e93f6dc11d9128 BingJing Chang 2022-08-12 946 info->fileattr = btrfs_inode_flags(path->nodes[0], ii); 31db9f7c23fbf7e Alexander Block 2012-07-25 947 3f8a18cc53bd1be Josef Bacik 2014-03-28 948 return ret; 3f8a18cc53bd1be Josef Bacik 2014-03-28 949 } 3f8a18cc53bd1be Josef Bacik 2014-03-28 950 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki