Re: [linux-next:master 3382/3950] mm/zswap.c:48:15: sparse: sparse: symbol 'zswap_stored_incompressible_pages' was not declared. Should it be static?

[SeongJae Park <sj@kernel.org>]

On Thu, 21 Aug 2025 17:43:16 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   7fa4d8dc380fbd81a9d702a855c50690c9c6442c
> commit: 6d522abd7b4fc78d51934e6c9a53d8e2349f5d3e [3382/3950] mm/zswap: store <PAGE_SIZE compression failed page as-is
> config: arc-randconfig-r123-20250821 (https://download.01.org/0day-ci/archive/20250821/202508211706.DnJPQQMn-lkp@intel.com/config)
> compiler: arc-linux-gcc (GCC) 13.4.0
> reproduce: (https://download.01.org/0day-ci/archive/20250821/202508211706.DnJPQQMn-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202508211706.DnJPQQMn-lkp@intel.com/
> 
> sparse warnings: (new ones prefixed by >>)
>    mm/zswap.c: note: in included file (through arch/arc/include/asm/cacheflush.h, include/linux/cacheflush.h, include/linux/highmem.h):
>    include/linux/mm.h:80:9: sparse: sparse: preprocessor token PAGES_TO_MB redefined
>    mm/zswap.c: note: in included file (through arch/arc/include/asm/irqflags-compact.h, arch/arc/include/asm/irqflags.h, include/linux/irqflags.h, ...):
>    arch/arc/include/asm/arcregs.h:155:9: sparse: this was the original definition
> >> mm/zswap.c:48:15: sparse: sparse: symbol 'zswap_stored_incompressible_pages' was not declared. Should it be static?
>    mm/zswap.c:1250:23: sparse: sparse: context imbalance in 'shrink_memcg_cb' - unexpected unlock
> 
> vim +/zswap_stored_incompressible_pages +48 mm/zswap.c
> 
>     41	
>     42	/*********************************
>     43	* statistics
>     44	**********************************/
>     45	/* The number of pages currently stored in zswap */
>     46	atomic_long_t zswap_stored_pages = ATOMIC_LONG_INIT(0);
>     47	/* The number of incompressible pages currently stored in zswap */
>   > 48	atomic_long_t zswap_stored_incompressible_pages = ATOMIC_LONG_INIT(0);
>     49	

Thank you for this report!  I just sent a fixup patch:
https://lore.kernel.org/20250821161750.78192-1-sj@kernel.org


Thanks,
SJ

[...]