From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9618CCA0FE8 for ; Fri, 22 Aug 2025 06:39:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 600A680B1C; Fri, 22 Aug 2025 06:39:36 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 4QWoNrt3_YTR; Fri, 22 Aug 2025 06:39:35 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org ACA9880B11 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1755844775; bh=Dy0tliyFN9wVhaq/pkOBUxhXGnHeKaPRJ37R+J7VDEo=; h=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=0qkI/1DXZ4vI1IF5A4OTDin9USTjjc/k0+SbSnObf1rCDdfL+m8nClwA9/bq3/sx1 XYV5a6GMUs77JX0b5xYwBB+mHkkZUmsCNHWjdzVSGfqSOxtQ1z7fPppzsWlvuE+wK8 JbzaPUy6XFmsDs+bsSdWUE4Ng6U15K6iK8s02nAOjmYfDXbIztJ0njAsiSNyFVFRlB eWSDj4q3yEa7N8lM2VcYCGJyA5jRkUdIXgJB9m2E/5kfZXln7Mni17wFr/IaW6OCsd PbqOeSjmhxLXiSU+KDgvsP/GXIXqQ5may4/q9JgmbiqPrezPGWFScgT/NZJFchmqre WY8CAgcqx/GPA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id ACA9880B11; Fri, 22 Aug 2025 06:39:35 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 0E451D8 for ; Fri, 22 Aug 2025 06:39:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5784A80B24 for ; Fri, 22 Aug 2025 06:39:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id O085FlGJKYkh for ; Fri, 22 Aug 2025 06:39:31 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.8; helo=mgamail.intel.com; envelope-from=pavan.kumar.linga@intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org AA57B80B16 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org AA57B80B16 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by smtp1.osuosl.org (Postfix) with ESMTPS id AA57B80B16 for ; Fri, 22 Aug 2025 06:39:31 +0000 (UTC) X-CSE-ConnectionGUID: VkgaQj2aTkuMCBXfZ1Tnbg== X-CSE-MsgGUID: IoB39aXLRT+1XsMQbQvPgQ== X-IronPort-AV: E=McAfee;i="6800,10657,11529"; a="75729047" X-IronPort-AV: E=Sophos;i="6.17,309,1747724400"; d="scan'208";a="75729047" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2025 23:32:24 -0700 X-CSE-ConnectionGUID: vFb2XzQdScmxrRFP3vf8/A== X-CSE-MsgGUID: Uja9YKq/RV+9D0WTYG7ezw== X-ExtLoop1: 1 Received: from unknown (HELO localhost.jf.intel.com) ([10.166.80.55]) by fmviesa003.fm.intel.com with ESMTP; 21 Aug 2025 23:32:24 -0700 From: Pavan Kumar Linga To: intel-wired-lan@lists.osuosl.org Cc: madhu.chittim@intel.com, Pavan Kumar Linga , Anton Nadezhdin Date: Thu, 21 Aug 2025 23:32:11 -0700 Message-ID: <20250822063215.3911-6-pavan.kumar.linga@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822063215.3911-1-pavan.kumar.linga@intel.com> References: <20250822063215.3911-1-pavan.kumar.linga@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1755844772; x=1787380772; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xyHR3CuG4eXawG543Z3HqXx0kmDSqRaXdIvd5RQuLVw=; b=jk6BsVbhCKkwtWq7RpqrJeCRV3xMzwPbxBwbpqQI8Xp5hyxX9hbsMf0R cV5tb8SA/OOJpJyEI5OzrazDGAymxIkMGiOM2RfBPjJKnJ3txmpGV3N1p VtH7okftjbJc1oDuuBAbBEvqICSjplDVB4YO75qPNixZ1ufHVypyw8LY+ Fpz5c4dCuoMO5z+3IoFuP4xVMSHA34OrVWP2kBqog+Ledaul6NDooxV5i T4Y53zlrKxYdACJ99KJlzpcCFagSz2lnJMCaKuDoUXxRUg95Ru8z/9niM YOkPbzSZX2PTXgaR/BqSxYXBnZkxQRKMl+OpNyHS4XLpD4wuuHkZgiSxy Q==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=intel.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=jk6BsVbh Subject: [Intel-wired-lan] [PATCH net-next v7 5/9] idpf: reshuffle idpf_vport struct members to avoid holes X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" The previous refactor of moving queue and vector resources out of the idpf_vport structure, created few holes. Reshuffle the existing members to avoid holes as much as possible. Reviewed-by: Anton Nadezhdin Signed-off-by: Pavan Kumar Linga --- drivers/net/ethernet/intel/idpf/idpf.h | 32 ++++++++++++-------------- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/intel/idpf/idpf.h b/drivers/net/ethernet/intel/idpf/idpf.h index 8e003aea7656..7696c5495cfc 100644 --- a/drivers/net/ethernet/intel/idpf/idpf.h +++ b/drivers/net/ethernet/intel/idpf/idpf.h @@ -333,29 +333,29 @@ struct idpf_q_vec_rsrc { /** * struct idpf_vport - Handle for netdevices and queue resources * @dflt_qv_rsrc: contains default queue and vector resources - * @num_txq: Number of allocated TX queues - * @compln_clean_budget: Work budget for completion clean * @txqs: Used only in hotpath to get to the right queue very fast - * @crc_enable: Enable CRC insertion offload - * @xdpsq_share: whether XDPSQ sharing is enabled + * @num_txq: Number of allocated TX queues * @num_xdp_txq: number of XDPSQs * @xdp_txq_offset: index of the first XDPSQ (== number of regular SQs) + * @xdpsq_share: whether XDPSQ sharing is enabled * @xdp_prog: installed XDP program - * @rx_ptype_lkup: Lookup table for ptypes on RX * @vdev_info: IDC vport device info pointer * @adapter: back pointer to associated adapter * @netdev: Associated net_device. Each vport should have one and only one * associated netdev. * @flags: See enum idpf_vport_flags - * @vport_type: Default SRIOV, SIOV, etc. + * @compln_clean_budget: Work budget for completion clean * @vport_id: Device given vport identifier + * @vport_type: Default SRIOV, SIOV, etc. * @idx: Software index in adapter vports struct - * @default_vport: Use this vport if one isn't specified * @max_mtu: device given max possible MTU * @default_mac_addr: device will give a default MAC to use * @rx_itr_profile: RX profiles for Dynamic Interrupt Moderation * @tx_itr_profile: TX profiles for Dynamic Interrupt Moderation + * @rx_ptype_lkup: Lookup table for ptypes on RX * @port_stats: per port csum, header split, and other offload stats + * @default_vport: Use this vport if one isn't specified + * @crc_enable: Enable CRC insertion offload * @link_up: True if link is up * @tx_tstamp_caps: Capabilities negotiated for Tx timestamping * @tstamp_config: The Tx tstamp config @@ -363,34 +363,32 @@ struct idpf_q_vec_rsrc { */ struct idpf_vport { struct idpf_q_vec_rsrc dflt_qv_rsrc; - u16 num_txq; - u32 compln_clean_budget; struct idpf_tx_queue **txqs; - bool crc_enable; - - bool xdpsq_share; + u16 num_txq; u16 num_xdp_txq; u16 xdp_txq_offset; + bool xdpsq_share; struct bpf_prog *xdp_prog; - struct libeth_rx_pt *rx_ptype_lkup; - struct iidc_rdma_vport_dev_info *vdev_info; struct idpf_adapter *adapter; struct net_device *netdev; DECLARE_BITMAP(flags, IDPF_VPORT_FLAGS_NBITS); - u16 vport_type; + u32 compln_clean_budget; u32 vport_id; + u16 vport_type; u16 idx; - bool default_vport; u16 max_mtu; u8 default_mac_addr[ETH_ALEN]; u16 rx_itr_profile[IDPF_DIM_PROFILE_SLOTS]; u16 tx_itr_profile[IDPF_DIM_PROFILE_SLOTS]; - struct idpf_port_stats port_stats; + struct libeth_rx_pt *rx_ptype_lkup; + struct idpf_port_stats port_stats; + bool default_vport; + bool crc_enable; bool link_up; struct idpf_ptp_vport_tx_tstamp_caps *tx_tstamp_caps; -- 2.43.0