All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: Wang Liang <wangliang74@huawei.com>,
	pablo@netfilter.org, kadlec@netfilter.org, razor@blackwall.org,
	idosch@nvidia.com, davem@davemloft.net, edumazet@google.com,
	pabeni@redhat.com, horms@kernel.org, yuehaibing@huawei.com,
	zhangchangzhong@huawei.com, netfilter-devel@vger.kernel.org,
	coreteam@netfilter.org, bridge@lists.linux.dev,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] netfilter: br_netfilter: do not check confirmed bit in br_nf_local_in() after confirm
Date: Fri, 22 Aug 2025 07:13:30 -0700	[thread overview]
Message-ID: <20250822071330.4168f0db@kernel.org> (raw)
In-Reply-To: <aKghV0FQDXa0qodb@strlen.de>

On Fri, 22 Aug 2025 09:50:58 +0200 Florian Westphal wrote:
> Wang Liang <wangliang74@huawei.com> wrote:
> > When send a broadcast packet to a tap device, which was added to a bridge,
> > br_nf_local_in() is called to confirm the conntrack. If another conntrack
> > with the same hash value is added to the hash table, which can be
> > triggered by a normal packet to a non-bridge device, the below warning
> > may happen.  
> 
> I placed this in nf.git:testing.

👍️

> In case netdev maintainers want to take it directly:

Unrelated, but while I have you -- nft_flowtable.sh is one of the most
flake-atious test for netdev CI currently :( Could you TAL whenever you
have some spare cycles?

https://netdev.bots.linux.dev/contest.html?test=nft-flowtable-sh

  reply	other threads:[~2025-08-22 14:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22  3:52 [PATCH net v2] netfilter: br_netfilter: do not check confirmed bit in br_nf_local_in() after confirm Wang Liang
2025-08-22  7:50 ` Florian Westphal
2025-08-22 14:13   ` Jakub Kicinski [this message]
2025-08-22 14:47     ` Florian Westphal
2025-08-28 10:59       ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250822071330.4168f0db@kernel.org \
    --to=kuba@kernel.org \
    --cc=bridge@lists.linux.dev \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kadlec@netfilter.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=razor@blackwall.org \
    --cc=wangliang74@huawei.com \
    --cc=yuehaibing@huawei.com \
    --cc=zhangchangzhong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.