From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: airoha: Add airoha_ppe_dev struct definition
Date: Fri, 22 Aug 2025 07:38:38 -0700 [thread overview]
Message-ID: <20250822073838.7da185f9@kernel.org> (raw)
In-Reply-To: <aKh9_g7mgvFxMdAz@lore-rh-laptop>
On Fri, 22 Aug 2025 16:26:06 +0200 Lorenzo Bianconi wrote:
> > > I moved the of_node_put() here (and in the if branch) in order to fix a similar
> > > issue fixed by Alok for airoha_npu.
> >
> > Ah, didn't notice it in the print..
> > maybe remove the empty line between the of_find_device.. and the null
> > check on pdev then?
>
> I am fine with it. I did it this way just to be consistent with NPU code:
> https://github.com/torvalds/linux/blob/master/drivers/net/ethernet/airoha/airoha_npu.c#L403
> Do you want me to post v3?
Nah, it's fine.
next prev parent reply other threads:[~2025-08-23 6:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 12:21 [PATCH net-next 0/3] net: airoha: Add PPE support for RX wlan offload Lorenzo Bianconi
2025-08-19 12:21 ` [PATCH net-next 1/3] net: airoha: Rely on airoha_eth struct in airoha_ppe_flow_offload_cmd signature Lorenzo Bianconi
2025-08-19 12:21 ` [PATCH net-next 2/3] net: airoha: Add airoha_ppe_dev struct definition Lorenzo Bianconi
2025-08-22 1:34 ` Jakub Kicinski
2025-08-22 6:58 ` Lorenzo Bianconi
2025-08-22 14:04 ` Jakub Kicinski
2025-08-22 14:26 ` Lorenzo Bianconi
2025-08-22 14:38 ` Jakub Kicinski [this message]
2025-08-19 12:21 ` [PATCH net-next 3/3] net: airoha: Introduce check_skb callback in ppe_dev ops Lorenzo Bianconi
2025-08-22 1:34 ` [PATCH net-next 0/3] net: airoha: Add PPE support for RX wlan offload Jakub Kicinski
2025-08-22 7:00 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250822073838.7da185f9@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.