Re: [Buildroot] [PATCH 4/4 v2] package/cups-filters: bump to version 2.0.1

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Angelo,

On Wed, 20 Aug 2025 18:39:21 +0200
Angelo Compagnucci <angelo.compagnucci@gmail.com> wrote:

> diff --git a/package/cups-filters/Config.in b/package/cups-filters/Config.in
> index ded99a4774..89f4b4d08d 100644
> --- a/package/cups-filters/Config.in
> +++ b/package/cups-filters/Config.in
> @@ -2,19 +2,15 @@ config BR2_PACKAGE_CUPS_FILTERS
>  	bool "cups-filters"
>  	# needs fork()
>  	depends on BR2_USE_MMU
> -	depends on BR2_INSTALL_LIBSTDCPP # qpdf
> +	depends on BR2_TOOLCHAIN_HAS_ATOMIC
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_USE_WCHAR

Make sure to indicate from which package those dependencies are
inherited.

>  	depends on !BR2_STATIC_LIBS
> -	depends on BR2_USE_WCHAR # libglib2
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
>  	depends on BR2_PACKAGE_CUPS
> +	depends on BR2_PACKAGE_LIBCUPSFILTERS
> +	depends on BR2_PACKAGE_LIBPPD
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # qpdf

You're no longer selecting qpdf, so the comment here is no longer
accurate.


>  CUPS_FILTERS_CONF_OPTS = \

[...]

> +	CFLAGS="$(TARGET_CFLAGS) -std=gnu17"

By convention, this should go in CUPS_FILTERS_CONF_ENV

>  
>  define CUPS_FILTERS_INSTALL_INIT_SYSV
>  	$(INSTALL) -D -m 0755 package/cups-filters/S82cups-browsed \

Shouldn't this be dropped, now that libcupsfilters does it?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot