All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,409411716@gms.tku.edu.tw,akpm@linux-foundation.org
Subject: + btree-fix-merge-logic-to-use-btree_last-return-value.patch added to mm-nonmm-unstable branch
Date: Fri, 22 Aug 2025 17:29:23 -0700	[thread overview]
Message-ID: <20250823002924.8144BC4CEED@smtp.kernel.org> (raw)


The patch titled
     Subject: btree: fix merge logic to use btree_last() return value
has been added to the -mm mm-nonmm-unstable branch.  Its filename is
     btree-fix-merge-logic-to-use-btree_last-return-value.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/btree-fix-merge-logic-to-use-btree_last-return-value.patch

This patch will later appear in the mm-nonmm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: "Guan-Chun.Wu" <409411716@gms.tku.edu.tw>
Subject: btree: fix merge logic to use btree_last() return value
Date: Fri, 22 Aug 2025 16:58:51 +0800

Previously btree_merge() called btree_last() only to test existence, then
performed an extra btree_lookup() to fetch the value.  This patch changes
it to directly use the value returned by btree_last(), avoiding redundant
lookups and simplifying the merge loop.

Link: https://lkml.kernel.org/r/20250822085851.566303-1-409411716@gms.tku.edu.tw
Signed-off-by: Guan-Chun.Wu <409411716@gms.tku.edu.tw>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 lib/btree.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/lib/btree.c~btree-fix-merge-logic-to-use-btree_last-return-value
+++ a/lib/btree.c
@@ -653,9 +653,9 @@ int btree_merge(struct btree_head *targe
 	 * walks to remove a single object from the victim.
 	 */
 	for (;;) {
-		if (!btree_last(victim, geo, key))
+		val = btree_last(victim, geo, key);
+		if (!val)
 			break;
-		val = btree_lookup(victim, geo, key);
 		err = btree_insert(target, geo, key, val, gfp);
 		if (err)
 			return err;
_

Patches currently in -mm which might be from 409411716@gms.tku.edu.tw are

btree-fix-merge-logic-to-use-btree_last-return-value.patch


                 reply	other threads:[~2025-08-23  0:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250823002924.8144BC4CEED@smtp.kernel.org \
    --to=akpm@linux-foundation.org \
    --cc=409411716@gms.tku.edu.tw \
    --cc=mm-commits@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.