From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH 3/4] staging: rtl8723bs: remove REG_EFUSE_ACCESS_8723 and EFUSE_ACCESS_ON_8723
Date: Sun, 24 Aug 2025 11:58:29 +0200 [thread overview]
Message-ID: <20250824095830.79233-4-straube.linux@gmail.com> (raw)
In-Reply-To: <20250824095830.79233-1-straube.linux@gmail.com>
The macros REG_EFUSE_ACCESS_8723 and EFUSE_ACCESS_ON_8723 are redundant,
both are already defined in header files without the _8723 suffix. Remove
them and use the marcos from the header files.
rtl8723b_hal.h:138:
#define EFUSE_ACCESS_ON 0x69 /* For RTL8723 only. */
hal_com_reg.h:35:
#define REG_EFUSE_ACCESS 0x00CF /* Efuse access protection for RTL8723 */
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 36680ecb5897..45cd2291f83d 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -568,13 +568,6 @@ void Hal_GetEfuseDefinition(
}
}
-/* */
-/* The following is for compile ok */
-/* That should be merged with the original in the future */
-/* */
-#define EFUSE_ACCESS_ON_8723 0x69 /* For RTL8723 only. */
-#define REG_EFUSE_ACCESS_8723 0x00CF /* Efuse access protection for RTL8723 */
-
void Hal_EfusePowerSwitch(
struct adapter *padapter, u8 PwrState
)
@@ -609,7 +602,7 @@ void Hal_EfusePowerSwitch(
} while (1);
}
- rtw_write8(padapter, REG_EFUSE_ACCESS_8723, EFUSE_ACCESS_ON_8723);
+ rtw_write8(padapter, REG_EFUSE_ACCESS, EFUSE_ACCESS_ON);
/* Reset: 0x0000h[28], default valid */
tmpV16 = rtw_read16(padapter, REG_SYS_FUNC_EN);
--
2.51.0
next prev parent reply other threads:[~2025-08-24 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-24 9:58 [PATCH 0/4] staging: rtl8723bs: more efuse cleanups Michael Straube
2025-08-24 9:58 ` [PATCH 1/4] staging: rtl8723bs: remove wrapper Efuse_PowerSwitch Michael Straube
2025-08-24 9:58 ` [PATCH 2/4] staging: rtl8723bs: remove bWrite from Hal_EfusePowerSwitch Michael Straube
2025-08-24 9:58 ` Michael Straube [this message]
2025-08-24 9:58 ` [PATCH 4/4] staging: rtl8723bs: Hal_EfuseParseAntennaDiversity_8723B is empty Michael Straube
2025-08-29 21:06 ` [PATCH 0/4] staging: rtl8723bs: more efuse cleanups philipp hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250824095830.79233-4-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.