From: Christoph Hellwig <hch@lst.de>
To: Nick Chan <towinchenmi@gmail.com>
Cc: Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Neal Gompa <neal@gompa.dev>,
Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Hector Martin <marcan@marcan.st>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
iommu@lists.linux.dev, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v3 7/9] nvme: apple: Add Apple A11 support
Date: Mon, 25 Aug 2025 10:07:10 +0200 [thread overview]
Message-ID: <20250825080710.GA23193@lst.de> (raw)
In-Reply-To: <20250821-t8015-nvme-v3-7-14a4178adf68@gmail.com>
On Thu, Aug 21, 2025 at 11:56:44PM +0800, Nick Chan wrote:
> + writel(anv->hw->max_queue_depth | (anv->hw->max_queue_depth << 16),
One long line left here.
Otherwise this looks fine to me.
Do you want to merge this through the apple SOC tree? If so:
Acked-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-08-25 8:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 15:56 [PATCH v3 0/9] Add support ANS2 NVMe on Apple A11 Nick Chan
2025-08-21 15:56 ` [PATCH v3 1/9] dt-bindings: mailbox: apple,mailbox: Add ASC mailboxes on Apple A11 and T2 Nick Chan
2025-08-21 15:56 ` [PATCH v3 2/9] soc: apple: mailbox: Add Apple A11 and T2 mailbox support Nick Chan
2025-08-21 15:56 ` [PATCH v3 3/9] dt-bindings: iommu: apple,sart: Add Apple A11 Nick Chan
2025-08-21 15:56 ` [PATCH v3 4/9] soc: apple: sart: Make allow flags SART version dependent Nick Chan
2025-08-21 15:56 ` [PATCH v3 5/9] soc: apple: sart: Add SARTv0 support Nick Chan
2025-08-21 15:56 ` [PATCH v3 6/9] dt-bindings: nvme: apple,nvme-ans: Add Apple A11 Nick Chan
2025-08-22 8:19 ` Krzysztof Kozlowski
2025-08-21 15:56 ` [PATCH v3 7/9] nvme: apple: Add Apple A11 support Nick Chan
2025-08-25 8:07 ` Christoph Hellwig [this message]
2025-08-27 15:56 ` Sven Peter
2025-09-02 5:26 ` Christoph Hellwig
2025-09-03 9:53 ` Janne Grunau
2025-09-04 19:30 ` Sven Peter
2025-08-21 15:56 ` [PATCH v3 8/9] arm64: dts: apple: t8015: Fix PCIE power domains dependencies Nick Chan
2025-08-21 15:56 ` [PATCH v3 9/9] arm64: dts: apple: t8015: Add NVMe nodes Nick Chan
2025-08-23 7:28 ` (subset) [PATCH v3 0/9] Add support ANS2 NVMe on Apple A11 Sven Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250825080710.GA23193@lst.de \
--to=hch@lst.de \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=axboe@kernel.dk \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=j@jannau.net \
--cc=jassisinghbrar@gmail.com \
--cc=joro@8bytes.org \
--cc=kbusch@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marcan@marcan.st \
--cc=neal@gompa.dev \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sagi@grimberg.me \
--cc=sven@kernel.org \
--cc=towinchenmi@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.