From: Jason Gunthorpe <jgg@nvidia.com>
To: Michael Margolin <mrgolin@amazon.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org, sleybo@amazon.com,
matua@amazon.com, gal.pressman@linux.dev,
Yonatan Nachum <ynachum@amazon.com>
Subject: Re: [PATCH for-next v2] RDMA/efa: Extend admin timeout error print
Date: Mon, 25 Aug 2025 11:56:22 -0300 [thread overview]
Message-ID: <20250825145622.GA2072201@nvidia.com> (raw)
In-Reply-To: <20250703182314.16442-1-mrgolin@amazon.com>
On Thu, Jul 03, 2025 at 06:23:14PM +0000, Michael Margolin wrote:
> Add command id to the printed message for additional debug information.
>
> Reviewed-by: Yonatan Nachum <ynachum@amazon.com>
> Signed-off-by: Michael Margolin <mrgolin@amazon.com>
> ---
> drivers/infiniband/hw/efa/efa_com.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
I picked this up, I think we can debate what level of debug prints or
traces are appropriate next someone adds them, but tweaking an
existing one seems fine to me.
Jason
prev parent reply other threads:[~2025-08-25 14:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 18:23 [PATCH for-next v2] RDMA/efa: Extend admin timeout error print Michael Margolin
2025-07-06 7:25 ` Leon Romanovsky
2025-07-06 16:32 ` Margolin, Michael
2025-07-07 6:28 ` Leon Romanovsky
2025-07-07 9:51 ` Margolin, Michael
2025-07-07 10:28 ` Leon Romanovsky
2025-07-07 11:18 ` Margolin, Michael
2025-08-18 7:55 ` Margolin, Michael
2025-07-07 11:30 ` Gal Pressman
2025-08-25 14:56 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250825145622.GA2072201@nvidia.com \
--to=jgg@nvidia.com \
--cc=gal.pressman@linux.dev \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.