From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38146CA0EFA for ; Tue, 26 Aug 2025 08:05:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C452810E5D6; Tue, 26 Aug 2025 08:05:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Yspa5uCi"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 35A4310E5D6 for ; Tue, 26 Aug 2025 08:05:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1756195532; x=1787731532; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=h7bMDprU1rOwcKzavss0z5IHz9GmluY8HDfei2Y/Jug=; b=Yspa5uCiWH88wpqpuvLNsAituUWlfzdWu4Uc041Q4xohmLNR6vGDDU88 FbHT7/L51Jb6JW2mlCh8Vvu8d6Xx11SEOXpRLUlHNL2tt1ruBqx7Fivk0 sgMCfy9splW8uL/h99FcqvflZtxWxhQsYb+h3h7ZfzAXqZtyw1ygTD5Bk XosEstLzScFzgA3bPBUo4uaymYJQNU44GgJyB6kcJjagsaztW3qJ/yRhL aIFg4S2UYZaE5YQI2vp0u7PdAEahfQY1N37fvJzb89zpBInS34rTrg0m9 GHK6MaI7o6BP2KfD8/FzttJXzUD0HcFlzwmG9G9L9Edz1vkU5sXsDFOnA w==; X-CSE-ConnectionGUID: 5z+OWnx8QcW6XVO5JWjbRw== X-CSE-MsgGUID: CT8G/pMpSFGqi3f76i0y4Q== X-IronPort-AV: E=McAfee;i="6800,10657,11533"; a="45998092" X-IronPort-AV: E=Sophos;i="6.18,214,1751266800"; d="scan'208";a="45998092" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2025 01:05:31 -0700 X-CSE-ConnectionGUID: Qgf4FxZMQ+qA/meDQ1NJ9Q== X-CSE-MsgGUID: /zSmjvFKQTCe2FFJ0/3VQw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,214,1751266800"; d="scan'208";a="169680473" Received: from shawnle1-i9-build-machine.itwn.intel.com ([10.225.64.200]) by orviesa008.jf.intel.com with ESMTP; 26 Aug 2025 01:05:29 -0700 From: Lee Shawn C To: intel-gfx@lists.freedesktop.org Cc: Lee Shawn C , Shankar Uma , Jani Nikula , Imre Deak , Vidya Srinivas Subject: [v4] drm/i915/hdmi: add debugfs to contorl HDMI bpc Date: Tue, 26 Aug 2025 08:01:17 +0000 Message-Id: <20250826080117.151587-1-shawn.c.lee@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250806042053.3570558-1-shawn.c.lee@intel.com> References: <20250806042053.3570558-1-shawn.c.lee@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" While performing HDMI compliance testing, test equipment may request different bpc output for signal measurement. However, display driver typically determines the maximum available bpc based on HW bandwidth. This change leverages the existing debugfs (intel_force_link_bpp) to manage HDMI bpc, and making it easier to pass HDMI CTS. v2: Using exist variable max_requested_bpc. v3: Extend intel_force_link_bpp to support HDMI as suggested by Imre. v4: Update commit message suggested by Jani. Cc: Shankar Uma Cc: Jani Nikula Cc: Imre Deak Cc: Vidya Srinivas Signed-off-by: Lee Shawn C --- drivers/gpu/drm/i915/display/g4x_hdmi.c | 5 +---- drivers/gpu/drm/i915/display/intel_hdmi.c | 4 ++++ drivers/gpu/drm/i915/display/intel_link_bw.c | 6 +----- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/g4x_hdmi.c b/drivers/gpu/drm/i915/display/g4x_hdmi.c index 108ebd97f9e4..b31fb1e4bc1a 100644 --- a/drivers/gpu/drm/i915/display/g4x_hdmi.c +++ b/drivers/gpu/drm/i915/display/g4x_hdmi.c @@ -136,11 +136,8 @@ static int g4x_hdmi_compute_config(struct intel_encoder *encoder, struct intel_atomic_state *state = to_intel_atomic_state(crtc_state->uapi.state); struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc); - if (HAS_PCH_SPLIT(display)) { + if (HAS_PCH_SPLIT(display)) crtc_state->has_pch_encoder = true; - if (!intel_fdi_compute_pipe_bpp(crtc_state)) - return -EINVAL; - } if (display->platform.g4x) crtc_state->has_hdmi_sink = g4x_compute_has_hdmi_sink(state, crtc); diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index cbee628eb26b..027e8ed0cea8 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -55,6 +55,7 @@ #include "intel_display_regs.h" #include "intel_display_types.h" #include "intel_dp.h" +#include "intel_fdi.h" #include "intel_gmbus.h" #include "intel_hdcp.h" #include "intel_hdcp_regs.h" @@ -2345,6 +2346,9 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder, if (adjusted_mode->flags & DRM_MODE_FLAG_DBLCLK) pipe_config->pixel_multiplier = 2; + if (!intel_fdi_compute_pipe_bpp(pipe_config)) + return -EINVAL; + pipe_config->has_audio = intel_hdmi_has_audio(encoder, pipe_config, conn_state) && intel_audio_compute_config(encoder, pipe_config, conn_state); diff --git a/drivers/gpu/drm/i915/display/intel_link_bw.c b/drivers/gpu/drm/i915/display/intel_link_bw.c index 3caef7f9c7c4..d194a366ff10 100644 --- a/drivers/gpu/drm/i915/display/intel_link_bw.c +++ b/drivers/gpu/drm/i915/display/intel_link_bw.c @@ -449,6 +449,7 @@ void intel_link_bw_connector_debugfs_add(struct intel_connector *connector) switch (connector->base.connector_type) { case DRM_MODE_CONNECTOR_DisplayPort: case DRM_MODE_CONNECTOR_eDP: + case DRM_MODE_CONNECTOR_HDMIA: break; case DRM_MODE_CONNECTOR_VGA: case DRM_MODE_CONNECTOR_SVIDEO: @@ -457,11 +458,6 @@ void intel_link_bw_connector_debugfs_add(struct intel_connector *connector) if (HAS_FDI(display)) break; - return; - case DRM_MODE_CONNECTOR_HDMIA: - if (HAS_FDI(display) && !HAS_DDI(display)) - break; - return; default: return; -- 2.34.1