From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22063343D9B; Tue, 26 Aug 2025 13:15:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756214113; cv=none; b=E3itKMNWNAzrHX+wrXneJa7nCj1GaQD7EYj3yFR0fsTsCKr/pJLLu3Fd/u29BaqIzD9wLcGY8aWhlFY3FokJA4qznDgjmbsb6jmXu1hs87kSGudo2UX2o0Fbl8+y/gYCCsCOGENAREh5oVuEX7AQ3lqU0B6yKodnX6/iLkFmu20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756214113; c=relaxed/simple; bh=RCMceva2qw1U7mJsC32xO9HpYkNXKXG2uviIRyfbFZ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zy3Khsgn2J4ubZumpPvu1oRl2zMVa4FyzlbU/TzR0sIi30e8C5BZqL3wrQ9rTuIkk061FkIZbG7K7xGFfGP3lxb8zaZYL0NUPeP0X+YQFdvx0q+K7rG1NKfLMz8LtBnOh3MOpai7l0NLRvF+eSAtSTCNavrIv6S9WeWhwjyMeEI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=O99RLpu4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="O99RLpu4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7450C4CEF1; Tue, 26 Aug 2025 13:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756214113; bh=RCMceva2qw1U7mJsC32xO9HpYkNXKXG2uviIRyfbFZ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O99RLpu4jgvFYldjeYlvEes+IFoKcPzsmQ49zoVdUHEn/d8F3+bnQftK5F4elSlxB kyHA/fRm/UXhZNrz5xipuMkQKA0KwTW9F28rZN2oIVjEPlYs7pFBDyDwUew3zE+6wV NdZBxs598woA05mlTzgU2R9VoXrqPqbMkCqBdjn8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Harald Mommer , Viresh Kumar , Bartosz Golaszewski Subject: [PATCH 6.1 008/482] gpio: virtio: Fix config space reading. Date: Tue, 26 Aug 2025 13:04:21 +0200 Message-ID: <20250826110930.987444824@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110930.769259449@linuxfoundation.org> References: <20250826110930.769259449@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Harald Mommer commit 4740e1e2f320061c2f0dbadc0dd3dfb58df986d5 upstream. Quote from the virtio specification chapter 4.2.2.2: "For the device-specific configuration space, the driver MUST use 8 bit wide accesses for 8 bit wide fields, 16 bit wide and aligned accesses for 16 bit wide fields and 32 bit wide and aligned accesses for 32 and 64 bit wide fields." Signed-off-by: Harald Mommer Cc: stable@vger.kernel.org Fixes: 3a29355a22c0 ("gpio: Add virtio-gpio driver") Acked-by: Viresh Kumar Link: https://lore.kernel.org/r/20250724143718.5442-2-harald.mommer@oss.qualcomm.com Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpio-virtio.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) --- a/drivers/gpio/gpio-virtio.c +++ b/drivers/gpio/gpio-virtio.c @@ -539,7 +539,6 @@ static const char **virtio_gpio_get_name static int virtio_gpio_probe(struct virtio_device *vdev) { - struct virtio_gpio_config config; struct device *dev = &vdev->dev; struct virtio_gpio *vgpio; u32 gpio_names_size; @@ -551,9 +550,11 @@ static int virtio_gpio_probe(struct virt return -ENOMEM; /* Read configuration */ - virtio_cread_bytes(vdev, 0, &config, sizeof(config)); - gpio_names_size = le32_to_cpu(config.gpio_names_size); - ngpio = le16_to_cpu(config.ngpio); + gpio_names_size = + virtio_cread32(vdev, offsetof(struct virtio_gpio_config, + gpio_names_size)); + ngpio = virtio_cread16(vdev, offsetof(struct virtio_gpio_config, + ngpio)); if (!ngpio) { dev_err(dev, "Number of GPIOs can't be zero\n"); return -EINVAL;