From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C06EF3431E9; Tue, 26 Aug 2025 13:18:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756214339; cv=none; b=mPMggCH9rJb7ZPs1H59LBuRbYn9SYahsGBL7DMI22Cb5ld9D1ykKDiRSqHAZJut30N5I5emzqvqRvp9dgYMkzBhsJUWccrC0y5WMqKHbFKEExvoDO0fGMUT6P3UlMK3Pclgjm7kdGZ4ogAvF4I8HrldM9nOEldoQDEcin1KL6fA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756214339; c=relaxed/simple; bh=ocudBeZNDUtRNuyjRIbREox0eMoYJCdC1J/yrZQTH0w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WeYtTkHM4QII7wWj5RCQlkKyTXGT7mrj2dgJyYOuni/FXXs/6sBceaIJrQ616ZLkuv4yGBMb+BH1lsZoScEm+2FdC6bX+G8C6ZvrTcAB6TUMzaDEE5CiMxzLgdWTmP1MymUInjuBtdQwIJJuZdGKxuV9Ja6v4psm4s+Z6Su0G9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yqzobsps; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yqzobsps" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05FA7C4CEF1; Tue, 26 Aug 2025 13:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756214339; bh=ocudBeZNDUtRNuyjRIbREox0eMoYJCdC1J/yrZQTH0w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yqzobspsAsvx6xHUsoW/LmdtUaFXMnu3PvFHKHch8Ut459U5k8/Dda5284vrdDLfX 2iOoTF64BGOLD6cvfeR+zzWxVsI7TZADViKCjG8ntY8oAoz6MOpD0I6Mv9PMdAxPWf uXE0dU06fSxH09fESmCdjcuLL6wod0rntlvOxoxk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alok Tiwari , Takashi Iwai , Sasha Levin Subject: [PATCH 6.1 101/482] ALSA: intel8x0: Fix incorrect codec index usage in mixer for ICH4 Date: Tue, 26 Aug 2025 13:05:54 +0200 Message-ID: <20250826110933.323377227@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110930.769259449@linuxfoundation.org> References: <20250826110930.769259449@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alok Tiwari [ Upstream commit 87aafc8580acf87fcaf1a7e30ed858d8c8d37d81 ] code mistakenly used a hardcoded index (codec[1]) instead of iterating, over the codec array using the loop variable i. Use codec[i] instead of codec[1] to match the loop iteration. Signed-off-by: Alok Tiwari Link: https://patch.msgid.link/20250621185233.4081094-1-alok.a.tiwari@oracle.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/pci/intel8x0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c index ae285c0a629c..f3df6fe2b7f1 100644 --- a/sound/pci/intel8x0.c +++ b/sound/pci/intel8x0.c @@ -2252,7 +2252,7 @@ static int snd_intel8x0_mixer(struct intel8x0 *chip, int ac97_clock, tmp |= chip->ac97_sdin[0] << ICH_DI1L_SHIFT; for (i = 1; i < 4; i++) { if (pcm->r[0].codec[i]) { - tmp |= chip->ac97_sdin[pcm->r[0].codec[1]->num] << ICH_DI2L_SHIFT; + tmp |= chip->ac97_sdin[pcm->r[0].codec[i]->num] << ICH_DI2L_SHIFT; break; } } -- 2.39.5