From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59B3213FD86; Tue, 26 Aug 2025 13:38:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756215504; cv=none; b=LItufnj/uyS9CWgH7WUPARstae4t4Dcly83zqYOWa5sIKPDTWwF2MRblCqWE2LO4qZv8hR9ybe3FQ0C2+1FO5hWZqeNr8LBUM2xF/jUDTdmSEd9TZ3gwDdlvhBE/q3YKq55LOC9ew+iCj6qFAMO54l/UVhHsuHNLH+w9wY+rYnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756215504; c=relaxed/simple; bh=hPR40qDZ1PFzUKCbwgq6CHm95tbepHI+/in1xfQmT0E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ep25S4ItEb7emwU5rqXX+ZxrMymgUgiJQq+qd90KpdxWrGhACHgykv2sqFL27wz7vWM8QU8f6W0SSlcwrn15dDshFbQNDQRgeHL5CpiKCn+mtSpDkldwyHzxxVodBrBgu1fhM12pKwMVfruFzWEWOEniRC5tj9t1QgQ8qjQqCOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=U7OIKkUx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="U7OIKkUx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC8D8C4CEF1; Tue, 26 Aug 2025 13:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756215504; bh=hPR40qDZ1PFzUKCbwgq6CHm95tbepHI+/in1xfQmT0E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U7OIKkUxaJpL7ftBocJCMR0cSik2eAtNDF8+AG+JZJah98fhwEBEzYN8jDsKAcZPo iy3dOp8eeja4XskHE2Z7vugsHkzR5W5XcajQ5lLEd1JaJLiy4ofHFFz+PVjnhhp4Z8 X/1iriZFFNg6u4wJRujBgVFLQBkGIV10WcAcJNN4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joseph Huang , Nikolay Aleksandrov , Ido Schimmel , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 057/644] net: bridge: Do not offload IGMP/MLD messages Date: Tue, 26 Aug 2025 13:02:28 +0200 Message-ID: <20250826110947.915505619@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110946.507083938@linuxfoundation.org> References: <20250826110946.507083938@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Joseph Huang [ Upstream commit 683dc24da8bf199bb7446e445ad7f801c79a550e ] Do not offload IGMP/MLD messages as it could lead to IGMP/MLD Reports being unintentionally flooded to Hosts. Instead, let the bridge decide where to send these IGMP/MLD messages. Consider the case where the local host is sending out reports in response to a remote querier like the following: mcast-listener-process (IP_ADD_MEMBERSHIP) \ br0 / \ swp1 swp2 | | QUERIER SOME-OTHER-HOST In the above setup, br0 will want to br_forward() reports for mcast-listener-process's group(s) via swp1 to QUERIER; but since the source hwdom is 0, the report is eligible for tx offloading, and is flooded by hardware to both swp1 and swp2, reaching SOME-OTHER-HOST as well. (Example and illustration provided by Tobias.) Fixes: 472111920f1c ("net: bridge: switchdev: allow the TX data plane forwarding to be offloaded") Signed-off-by: Joseph Huang Acked-by: Nikolay Aleksandrov Reviewed-by: Ido Schimmel Link: https://patch.msgid.link/20250716153551.1830255-1-Joseph.Huang@garmin.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/bridge/br_switchdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c index 6bf518d78f029..44ae2068045b1 100644 --- a/net/bridge/br_switchdev.c +++ b/net/bridge/br_switchdev.c @@ -16,6 +16,9 @@ static bool nbp_switchdev_can_offload_tx_fwd(const struct net_bridge_port *p, if (!static_branch_unlikely(&br_switchdev_tx_fwd_offload)) return false; + if (br_multicast_igmp_type(skb)) + return false; + return (p->flags & BR_TX_FWD_OFFLOAD) && (p->hwdom != BR_INPUT_SKB_CB(skb)->src_hwdom); } -- 2.39.5