From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 653D61E5710; Tue, 26 Aug 2025 13:48:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756216129; cv=none; b=Kwxldgwq0VgKPYQ6DGz0XjlIvTnoK9fbFuY/yj2ZaXLp5dJ9GS7AZwKRk+TDLB4hItV/M/kZ4n1y8z9RGhfZov+LrmVqSfDQXWOaSFG2eSyLaSeFfiFOG7FoYsM+htLV9qygrccQcvfSNbgNLhcT+H1dlL07bQEnY+fcdjqdk2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756216129; c=relaxed/simple; bh=sGhVW17/jfp32+r3t2eLC12SiL5BUCNYIj9QQZOVUiU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VWITk9hQhxczWwQvx2oGQwrCSBFO1Feoom2l5CEPfpUPm9VZAkxdGX1CA0VERNFlmZzf1o3wXiFOy6OTannXI9xh53jTPOxjD0mU55U6ulgnqXA6t2kmTQOxsJGJIHboPollxFuXsUZHzj6adsioSvO+qyaBiWZ4X0sgKLMANmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RBuFBfVG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RBuFBfVG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECCF4C4CEF1; Tue, 26 Aug 2025 13:48:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756216129; bh=sGhVW17/jfp32+r3t2eLC12SiL5BUCNYIj9QQZOVUiU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RBuFBfVGTcFEyAVh+47iYd4jzipJ4rlw2QqS9CQNkkDJxdo6zMY6T0XyqmiMlgRzY CP3sK3tD40j4folcktTjuVzKtDO7eEyV9uy2TM9pV+pbrbNHrvvs74t+yna/tgET0v lkXFZe/VWMCuf37zdF9cBC5uCTQNNyyrhd1yOheA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Al Viro , Sasha Levin Subject: [PATCH 5.15 294/644] securityfs: dont pin dentries twice, once is enough... Date: Tue, 26 Aug 2025 13:06:25 +0200 Message-ID: <20250826110953.667481713@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110946.507083938@linuxfoundation.org> References: <20250826110946.507083938@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Al Viro [ Upstream commit 27cd1bf1240d482e4f02ca4f9812e748f3106e4f ] incidentally, securityfs_recursive_remove() is broken without that - it leaks dentries, since simple_recursive_removal() does not expect anything of that sort. It could be worked around by dput() in remove_one() callback, but it's easier to just drop that double-get stuff. Signed-off-by: Al Viro Signed-off-by: Sasha Levin --- security/inode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/security/inode.c b/security/inode.c index 6c326939750d..e6e07787eec9 100644 --- a/security/inode.c +++ b/security/inode.c @@ -159,7 +159,6 @@ static struct dentry *securityfs_create_dentry(const char *name, umode_t mode, inode->i_fop = fops; } d_instantiate(dentry, inode); - dget(dentry); inode_unlock(dir); return dentry; @@ -306,7 +305,6 @@ void securityfs_remove(struct dentry *dentry) simple_rmdir(dir, dentry); else simple_unlink(dir, dentry); - dput(dentry); } inode_unlock(dir); simple_release_fs(&mount, &mount_count); -- 2.39.5