From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CFD5350D43; Tue, 26 Aug 2025 13:51:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756216271; cv=none; b=L6sGou7Ia7jlfFfCGfYDYM2ZbC249W4yidKEmdCR0SDD8tDTtlja+LE0OzSjaETXE7c73N256RNrSKVQ/8d2crJ2hQEcGIYP26UWiYgBmApCvfV695JDy3gh1+B5Y+OZoSacC8j7qxS3sIAyYPFhd8kULfVInVcmpZoPnGjMEmA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756216271; c=relaxed/simple; bh=HEMPYH/8N8EI+01pImVl/U74Pek+cT6SkGvlqJu8zWg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ll/PKMv7vJqtcXhEVCRgeKqcuJzuRXGq/nXwb2NDhcLAJQK5oRuExinote2kl0aaXrnjPlSKRNWTi8GF7LIouptZMX4ciVnJ8fpN7/hKKPvYRNairG4mi7ovHaI7TTV2DBsvXlkbUSOrmi/pd/eCFlSfBtrQOQQAL3lduTTvn3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hhxChlug; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hhxChlug" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B4E3C4CEF1; Tue, 26 Aug 2025 13:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756216271; bh=HEMPYH/8N8EI+01pImVl/U74Pek+cT6SkGvlqJu8zWg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hhxChluglbuWY32obVL6Nhni1UMNE1/OmfsrnSXprqCK/2TnUE788p1p4JNcuo7Qb qWRbz8L4vOrYP7Jkd936NS/zLHaktLJWeYe6nQ2BS8X12Z3h15Hk/sroQr0EAws13i pmOFF/5YOscRQ9b/0wJiTZEMXoi2wjv+RalUYFjU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bartosz Golaszewski , Sasha Levin Subject: [PATCH 5.15 302/644] gpio: wcd934x: check the return value of regmap_update_bits() Date: Tue, 26 Aug 2025 13:06:33 +0200 Message-ID: <20250826110953.870013519@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110946.507083938@linuxfoundation.org> References: <20250826110946.507083938@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bartosz Golaszewski [ Upstream commit ff0f0d7c6587e38c308be9905e36f86e98fb9c1f ] regmap_update_bits() can fail so check its return value in wcd_gpio_direction_output() for consistency with the rest of the code and propagate any errors. Link: https://lore.kernel.org/r/20250709-gpiochip-set-rv-gpio-remaining-v1-2-b8950f69618d@linaro.org Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-wcd934x.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-wcd934x.c b/drivers/gpio/gpio-wcd934x.c index 97e6caedf1f3..c00968ce7a56 100644 --- a/drivers/gpio/gpio-wcd934x.c +++ b/drivers/gpio/gpio-wcd934x.c @@ -45,9 +45,12 @@ static int wcd_gpio_direction_output(struct gpio_chip *chip, unsigned int pin, int val) { struct wcd_gpio_data *data = gpiochip_get_data(chip); + int ret; - regmap_update_bits(data->map, WCD_REG_DIR_CTL_OFFSET, - WCD_PIN_MASK(pin), WCD_PIN_MASK(pin)); + ret = regmap_update_bits(data->map, WCD_REG_DIR_CTL_OFFSET, + WCD_PIN_MASK(pin), WCD_PIN_MASK(pin)); + if (ret) + return ret; return regmap_update_bits(data->map, WCD_REG_VAL_CTL_OFFSET, WCD_PIN_MASK(pin), -- 2.39.5