From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2F6E34AB15; Tue, 26 Aug 2025 13:51:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756216295; cv=none; b=X+DtyC9R4VRhokD7w4vjTFB4Q3xadJmUFS0j5Id6amwDeXGSfuuMtAzvaMurkMJzuvZzwrwvtyqjrq1kLnHSQxA2NCF2m6ZoJC+6CwJhcMw3NLv6Wo0/h961Yl4VkYbahLIBzO1GsXvsiBr20MwW42PE9uSfVCKvyIVsqMaHTYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756216295; c=relaxed/simple; bh=e6bQ8cCEbO9nYL1raF/jhYyKNC3DpkwnnY1flQpoYtY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FCCspBcP+ROKvudIhRZk+vJrGFipsQyizQDSEO7NLVP1D5cQt/D48oZfzkDeiine4GOMWsDmwTXeL82dXNAUj7IMSjNwaQcu1KkCRen6SuO/D4po5Tg2tJWWeTqqMjlLHO9MUmoHbAEk+mBqBcrS99g5qFGxmGhYD935VkN32J0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UZ5hgo3i; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UZ5hgo3i" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84F4DC4CEF1; Tue, 26 Aug 2025 13:51:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756216294; bh=e6bQ8cCEbO9nYL1raF/jhYyKNC3DpkwnnY1flQpoYtY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UZ5hgo3ihjGs7ms80ilJM2/L26mWdggcIlO55Vxqbmg8fcjWbR+UKTxh43oCAACeJ AwApL8OZLmU0QjM5UuihWjlts8sPv2DtHfLLAuBkv7RvgEojlYtHRKXEFLMhuxcZ/k QGa65UgB6re0bu4p4wRHY/Kbw9jpiLNfNbj+XEvM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mika Westerberg , zhangjianrong , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 358/644] net: thunderbolt: Fix the parameter passing of tb_xdomain_enable_paths()/tb_xdomain_disable_paths() Date: Tue, 26 Aug 2025 13:07:29 +0200 Message-ID: <20250826110955.277608655@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110946.507083938@linuxfoundation.org> References: <20250826110946.507083938@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: zhangjianrong [ Upstream commit 8ec31cb17cd355cea25cdb8496d9b3fbf1321647 ] According to the description of tb_xdomain_enable_paths(), the third parameter represents the transmit ring and the fifth parameter represents the receive ring. tb_xdomain_disable_paths() is the same case. [Jakub] Mika says: it works now because both rings ->hop is the same Acked-by: Mika Westerberg Link: https://lore.kernel.org/20250625051149.GD2824380@black.fi.intel.com Signed-off-by: zhangjianrong Link: https://patch.msgid.link/20250628094920.656658-1-zhangjianrong5@huawei.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/thunderbolt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/thunderbolt.c b/drivers/net/thunderbolt.c index 470852f7a64d..ba9f7062f5a7 100644 --- a/drivers/net/thunderbolt.c +++ b/drivers/net/thunderbolt.c @@ -380,9 +380,9 @@ static void tbnet_tear_down(struct tbnet *net, bool send_logout) ret = tb_xdomain_disable_paths(net->xd, net->local_transmit_path, - net->rx_ring.ring->hop, + net->tx_ring.ring->hop, net->remote_transmit_path, - net->tx_ring.ring->hop); + net->rx_ring.ring->hop); if (ret) netdev_warn(net->dev, "failed to disable DMA paths\n"); @@ -631,9 +631,9 @@ static void tbnet_connected_work(struct work_struct *work) goto err_free_rx_buffers; ret = tb_xdomain_enable_paths(net->xd, net->local_transmit_path, - net->rx_ring.ring->hop, + net->tx_ring.ring->hop, net->remote_transmit_path, - net->tx_ring.ring->hop); + net->rx_ring.ring->hop); if (ret) { netdev_err(net->dev, "failed to enable DMA paths\n"); goto err_free_tx_buffers; -- 2.39.5