From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06C7E1A23BE; Tue, 26 Aug 2025 12:55:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756212915; cv=none; b=gGwOYU5GPpoRMV/wMg9xtt4uGoTGudTa97agJ4soM1Lg7u3ZHztO+Y5Es1GSd2JPkMsr3AtcLnBlzJ6bBeg3xBM44N0thFhCA8zbs4tpejme06u5ETxicxO6Z6A/+UMfmDjblngvPuLKUkZRXkC0Ef+88QYICgKdcuO7JgvN9Mk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756212915; c=relaxed/simple; bh=jOmkZv92U8eu/nyV122hLh/VVU5vOHHDXKAc/2Y+5dk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TUTHZIQ+XNE0sSHkr7KlfRmSVPkyHth1cKyvX5zXChKFoJ/bIOK5NF+vRoxHTlk2hbKXVhSNLbpRlBxGFJR3dGmMKz3TyqRumAVkPYVmW1bfU7pu26uiiWCASpBHp8a14Ea2WGdEqRhuVeNDuySIeqBxZqBrBWfaO2DxKlWcTg8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iW1+8QF/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iW1+8QF/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89B3EC4CEF1; Tue, 26 Aug 2025 12:55:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756212914; bh=jOmkZv92U8eu/nyV122hLh/VVU5vOHHDXKAc/2Y+5dk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iW1+8QF/ulcNgmx0ghaeC6Ts3O3nA+68sxoHtf8QKl7Sxx+bFt+3Qb3uoW8bc8xVG 1yvdO4nq/AWo3GuuvJCwa9tZU3b1hbQeYJ/xfzKsAfssJZJD28qCHvljVJ9m3xanoY OMbMk+IJICAkVQUWxx+iBtnjEEopWLb+m7NNV9z8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thomas Fourier , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.6 150/587] net: ag71xx: Add missing check after DMA map Date: Tue, 26 Aug 2025 13:04:59 +0200 Message-ID: <20250826110956.765081272@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110952.942403671@linuxfoundation.org> References: <20250826110952.942403671@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Fourier [ Upstream commit 96a1e15e60216b52da0e6da5336b6d7f5b0188b0 ] The DMA map functions can fail and should be tested for errors. Signed-off-by: Thomas Fourier Reviewed-by: Simon Horman Link: https://patch.msgid.link/20250716095733.37452-3-fourier.thomas@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/atheros/ag71xx.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c index 009e0b3066fa..baf12ae0b8c4 100644 --- a/drivers/net/ethernet/atheros/ag71xx.c +++ b/drivers/net/ethernet/atheros/ag71xx.c @@ -1234,6 +1234,11 @@ static bool ag71xx_fill_rx_buf(struct ag71xx *ag, struct ag71xx_buf *buf, buf->rx.rx_buf = data; buf->rx.dma_addr = dma_map_single(&ag->pdev->dev, data, ag->rx_buf_size, DMA_FROM_DEVICE); + if (dma_mapping_error(&ag->pdev->dev, buf->rx.dma_addr)) { + skb_free_frag(data); + buf->rx.rx_buf = NULL; + return false; + } desc->data = (u32)buf->rx.dma_addr + offset; return true; } @@ -1532,6 +1537,10 @@ static netdev_tx_t ag71xx_hard_start_xmit(struct sk_buff *skb, dma_addr = dma_map_single(&ag->pdev->dev, skb->data, skb->len, DMA_TO_DEVICE); + if (dma_mapping_error(&ag->pdev->dev, dma_addr)) { + netif_dbg(ag, tx_err, ndev, "DMA mapping error\n"); + goto err_drop; + } i = ring->curr & ring_mask; desc = ag71xx_ring_desc(ring, i); -- 2.39.5