From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11EF118DB0D; Tue, 26 Aug 2025 13:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756213332; cv=none; b=ltQRj6l+m92WzOnrBmUdvDQen/8gwpopt4aV3vIwI5t3DX12FR/6TzQYO9WEb4yx6suCJntvmWOE8lWL56XnFO7DZKdPlShh+xdmPvaXWVbr6VxLcjRzkgwj7xZWoD84EZvnSOMupnst1aA2ttXdLXJIZtzQ18bim0sTeTePBjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756213332; c=relaxed/simple; bh=ijCaDVG4RUx9SAhZKyqWoMdgWvDAg0PHu+N/aRuOGcc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AKuIA/J1Hg5+cNt7Sm5wczymJis+f6KytA8x/6uGtwxZK6q7NosGVqPJNxp6XoddBl6uB4YHo2eS6D2RqSBXk94tDT5YAl2VNMMsNrmIMaJBEQ8Chy7rU93nWAzotieT7duO9dWqS+6vwk3DbPM8bt67jKc2nqkdnarRG/ZCgas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KWxS8GTB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KWxS8GTB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54859C4CEF1; Tue, 26 Aug 2025 13:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756213330; bh=ijCaDVG4RUx9SAhZKyqWoMdgWvDAg0PHu+N/aRuOGcc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KWxS8GTBVp2ZXZ7ubWvce1PSIdo8zhZ8I3iyZH3GCA+7EKufZl6FOEEt7Ku/LoF8B Xl78AeuKtFczRPwMf0BG5W/bJgTJojqXJuWWEoUuDbJDnzFvlHIWZzyOr7Kb3hZisa XGxx3YKSbk0ZGriftRiZRE2lqx7qdigmMjkjkPfU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Oliver Neukum Subject: [PATCH 6.6 308/587] cdc-acm: fix race between initial clearing halt and open Date: Tue, 26 Aug 2025 13:07:37 +0200 Message-ID: <20250826111000.755411226@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110952.942403671@linuxfoundation.org> References: <20250826110952.942403671@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Oliver Neukum commit 64690a90cd7c6db16d3af8616be1f4bf8d492850 upstream. On the devices that need their endpoints to get an initial clear_halt, this needs to be done before the devices can be opened. That means it needs to be before the devices are registered. Fixes: 15bf722e6f6c0 ("cdc-acm: Add support of ATOL FPrint fiscal printers") Cc: stable Signed-off-by: Oliver Neukum Link: https://lore.kernel.org/r/20250717141259.2345605-1-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/class/cdc-acm.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1520,6 +1520,12 @@ skip_countries: goto err_remove_files; } + if (quirks & CLEAR_HALT_CONDITIONS) { + /* errors intentionally ignored */ + usb_clear_halt(usb_dev, acm->in); + usb_clear_halt(usb_dev, acm->out); + } + tty_dev = tty_port_register_device(&acm->port, acm_tty_driver, minor, &control_interface->dev); if (IS_ERR(tty_dev)) { @@ -1527,11 +1533,6 @@ skip_countries: goto err_release_data_interface; } - if (quirks & CLEAR_HALT_CONDITIONS) { - usb_clear_halt(usb_dev, acm->in); - usb_clear_halt(usb_dev, acm->out); - } - dev_info(&intf->dev, "ttyACM%d: USB ACM device\n", minor); return 0;