From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C8BF350D70; Tue, 26 Aug 2025 14:02:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756216946; cv=none; b=FdqV/WMGbaCqwF1kKh08ad7jrCGm9yN2H/sFgmM22pNtLi3lekTamCfoxDEcKTWrZVd2Z/khZCauWPqZRGiGXSBzaQLv5aoi3xv8FLissiaDSUuFAezz9eVDwut2Bf1rLwItlJRbXl1l79bHTqokUW5dyALKQz018UElx9SzKHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756216946; c=relaxed/simple; bh=Ejh3w/2OcGSpZ3GjbsfW8Xyfqgp9Zgsovc0mM0s7tcQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c6NiLovlYih8z4iQjpvKBstdJx5CBqcWqDo7LSCi7zyNHj6OCzjMLDwBCyvvXNSgN2mhy33P3EMxzNjwZPOnfqpej8OsS+0vzXi0iy2VZEGeImipc5ROJ96hic24RKiDc2OW8sSiZlMlmdOc3crL+z8MJ6K5Xsh0oZr0xJFdTYc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ycJcf1hp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ycJcf1hp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A185C4CEF1; Tue, 26 Aug 2025 14:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756216945; bh=Ejh3w/2OcGSpZ3GjbsfW8Xyfqgp9Zgsovc0mM0s7tcQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ycJcf1hpJ6krbGMIo6a3cC2+P0Nj96JrtRE5iJWz45phbIYDQoHXZ93aqT7fZ7J+U a9VXXUhfiPE9uPVC2IzkUcW1vHOjo0DVnGENWbRqpqqJQ6D9qp8dMa1m7XP17yyA2p yVDQmrea170GHAfthZJBBS9psMTc9tIU179PjGaE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jorge Ramirez-Ortiz , Bryan ODonoghue , Vikash Garodia , Dikshita Agarwal , Bryan ODonoghue , Hans Verkuil , Sasha Levin Subject: [PATCH 5.15 599/644] media: venus: protect against spurious interrupts during probe Date: Tue, 26 Aug 2025 13:11:30 +0200 Message-ID: <20250826111001.388287244@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110946.507083938@linuxfoundation.org> References: <20250826110946.507083938@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jorge Ramirez-Ortiz [ Upstream commit 3200144a2fa4209dc084a19941b9b203b43580f0 ] Make sure the interrupt handler is initialized before the interrupt is registered. If the IRQ is registered before hfi_create(), it's possible that an interrupt fires before the handler setup is complete, leading to a NULL dereference. This error condition has been observed during system boot on Rb3Gen2. Fixes: af2c3834c8ca ("[media] media: venus: adding core part and helper functions") Cc: stable@vger.kernel.org Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Bryan O'Donoghue Reviewed-by: Vikash Garodia Reviewed-by: Dikshita Agarwal Tested-by: Dikshita Agarwal # RB5 Signed-off-by: Bryan O'Donoghue Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/qcom/venus/core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/drivers/media/platform/qcom/venus/core.c +++ b/drivers/media/platform/qcom/venus/core.c @@ -332,13 +332,13 @@ static int venus_probe(struct platform_d mutex_init(&core->lock); INIT_DELAYED_WORK(&core->work, venus_sys_error_handler); - ret = devm_request_threaded_irq(dev, core->irq, hfi_isr, venus_isr_thread, - IRQF_TRIGGER_HIGH | IRQF_ONESHOT, - "venus", core); + ret = hfi_create(core, &venus_core_ops); if (ret) goto err_core_put; - ret = hfi_create(core, &venus_core_ops); + ret = devm_request_threaded_irq(dev, core->irq, hfi_isr, venus_isr_thread, + IRQF_TRIGGER_HIGH | IRQF_ONESHOT, + "venus", core); if (ret) goto err_core_put;