From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D8E0CA0FE7 for ; Tue, 26 Aug 2025 13:49:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id DD71E6F8F9; Tue, 26 Aug 2025 13:49:00 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WZtw-Fd6JcIE; Tue, 26 Aug 2025 13:49:00 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 26CC56F8BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1756216140; bh=tLw3YRDXSxieAEUkQih90MyR4d5TxwOlKQ0gYxIPleg=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GUlnaIqwiVRZ8xoYE2Cee8TmJC11DlCksCsRInsf8VJVCXPUcMxlTIZGrCjS5tHXE R+xn3CNlBZaAxydSHvOlX4b6Ac/p4y/PN+vdrRkWGGb8Xisj5mtymYsHE5qmi7rdqw Af5k6yw77kxCMySLViL2xXrAdr3hmikEofzolgu1xHX5Caw6BHeOb6SbVuYWEFvV2y VdcWBcMRXv4UiOmpUJ2iCv9/GhAC6G9xOSppL5Yu+ZjqMcfobH9NOkzY9hPPVdisza uvOjLEUaVbHz/eJzHsB4upIqxXAWhjE+wpRdw+06OHo5R+8Dh9tsD9q9hFUA4WO3xU lMPZYskX4bXdA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 26CC56F8BE; Tue, 26 Aug 2025 13:49:00 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists1.osuosl.org (Postfix) with ESMTP id C45C3B0B for ; Tue, 26 Aug 2025 13:48:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id B49258529C for ; Tue, 26 Aug 2025 13:48:58 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id HVb-d0JSViqC for ; Tue, 26 Aug 2025 13:48:56 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org C53328529A DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C53328529A Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp1.osuosl.org (Postfix) with ESMTPS id C53328529A for ; Tue, 26 Aug 2025 13:48:56 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 4118C602B0; Tue, 26 Aug 2025 13:48:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C97D0C4CEF1; Tue, 26 Aug 2025 13:48:53 +0000 (UTC) Date: Tue, 26 Aug 2025 14:48:51 +0100 From: Simon Horman To: Michal Swiatkowski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, przemyslaw.kitszel@intel.com, dawid.osuchowski@linux.intel.com Message-ID: <20250826134851.GA5892@horms.kernel.org> References: <20250812042337.1356907-1-michal.swiatkowski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250812042337.1356907-1-michal.swiatkowski@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756216135; bh=XGiRH+1trpEwpUcqcmaqq2E7b01zJv0ChUBF1gJeF4Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mKEiW9a0GV2oQv268spDXPs54Scu4EjEUieeaLwcUXa6H4u/pp6g6xJ8SNH6r+pSs PFpkXMn6B2/ruJD9zUclcwYoanrGe3ffPoHCUne8nETzJq4c6/Sy+dqgkENbxs/qiQ fP8hNLuAZyTS9Y8O54WNEIyy5IG0evknX3lLI4lPhQpFZfa2s57/Opc3Zwf8D+i9LA 2ycXxWZluVbQFj3DWAyYX6BKSgFS6l2TBXwjVSIKeakvvaHp5vyjwYu0uGhD5pnjAC xrDEirpGwgiRYlJuVrPr7MRdxufkCgNfaYdy7tCZDwLGbAtUN2NE52PeTprpwZ/yTQ s6ziis6N7lI7Q== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=mKEiW9a0 Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 00/15] Fwlog support in ixgbe X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Aug 12, 2025 at 06:23:21AM +0200, Michal Swiatkowski wrote: > Hi, > > Firmware logging is a feature that allow user to dump firmware log using > debugfs interface. It is supported on device that can handle specific > firmware ops. It is true for ice and ixgbe driver. > > Prepare code from ice driver to be moved to the library code and reuse > it in ixgbe driver. > > v1 --> v2: [1] > * fix building issue in patch 9 > > [1] https://lore.kernel.org/netdev/20250722104600.10141-1-michal.swiatkowski@linux.intel.com/ > > Michal Swiatkowski (15): > ice: make fwlog functions static > ice: move get_fwlog_data() to fwlog file > ice: drop ice_pf_fwlog_update_module() > ice: introduce ice_fwlog structure > ice: add pdev into fwlog structure and use it for logging > ice: allow calling custom send function in fwlog > ice: move out debugfs init from fwlog > ice: check for PF number outside the fwlog code nit: I think that patch 8/15 updates ice_fwlog_init() such that it begins with a blank line. I would delete it. > ice: drop driver specific structure from fwlog code > libie, ice: move fwlog admin queue to libie > ice: move debugfs code to fwlog > ice: prepare for moving file to libie > ice: reregister fwlog after driver reinit > ice, libie: move fwlog code to libie > ixgbe: fwlog support for e610 ... The nit above notwithstanding, this looks good to me. Please feel free to add: Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26A3E345726 for ; Tue, 26 Aug 2025 13:48:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756216135; cv=none; b=XKUd8bjmSDK34ytsDe1XSaOytcw5DlYC/08sLw34wO0Iz9FqTFO2xMfyqIB5NfeJuA8aFEW5/XGeymU+0DlDV2zghMN/zs5lPHQZteW2yy9zuVaj9iqhrYP/HBqtgJGLYrTJXIdWUqOhAmJC/LddFGx6FVX+d2nvUqz+mI+PIfk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756216135; c=relaxed/simple; bh=XGiRH+1trpEwpUcqcmaqq2E7b01zJv0ChUBF1gJeF4Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K/gZXpEKPclU4JJZ597fvR05RBO23eSBMb8cDEcYqjt2qvKRLrCSKRrs4+RdYW6eh99jn66bLZm/5SbosmaMMTrEHcudD5x4qqNeDEq4YsbZvtZoJvf+cxODZf6PBOdgcfdBMY5J3E5K9bAk7HCfEaDkFXl48hSIZDhBegy0lbU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mKEiW9a0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mKEiW9a0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C97D0C4CEF1; Tue, 26 Aug 2025 13:48:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756216135; bh=XGiRH+1trpEwpUcqcmaqq2E7b01zJv0ChUBF1gJeF4Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mKEiW9a0GV2oQv268spDXPs54Scu4EjEUieeaLwcUXa6H4u/pp6g6xJ8SNH6r+pSs PFpkXMn6B2/ruJD9zUclcwYoanrGe3ffPoHCUne8nETzJq4c6/Sy+dqgkENbxs/qiQ fP8hNLuAZyTS9Y8O54WNEIyy5IG0evknX3lLI4lPhQpFZfa2s57/Opc3Zwf8D+i9LA 2ycXxWZluVbQFj3DWAyYX6BKSgFS6l2TBXwjVSIKeakvvaHp5vyjwYu0uGhD5pnjAC xrDEirpGwgiRYlJuVrPr7MRdxufkCgNfaYdy7tCZDwLGbAtUN2NE52PeTprpwZ/yTQ s6ziis6N7lI7Q== Date: Tue, 26 Aug 2025 14:48:51 +0100 From: Simon Horman To: Michal Swiatkowski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, przemyslaw.kitszel@intel.com, dawid.osuchowski@linux.intel.com Subject: Re: [PATCH iwl-next v2 00/15] Fwlog support in ixgbe Message-ID: <20250826134851.GA5892@horms.kernel.org> References: <20250812042337.1356907-1-michal.swiatkowski@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250812042337.1356907-1-michal.swiatkowski@linux.intel.com> On Tue, Aug 12, 2025 at 06:23:21AM +0200, Michal Swiatkowski wrote: > Hi, > > Firmware logging is a feature that allow user to dump firmware log using > debugfs interface. It is supported on device that can handle specific > firmware ops. It is true for ice and ixgbe driver. > > Prepare code from ice driver to be moved to the library code and reuse > it in ixgbe driver. > > v1 --> v2: [1] > * fix building issue in patch 9 > > [1] https://lore.kernel.org/netdev/20250722104600.10141-1-michal.swiatkowski@linux.intel.com/ > > Michal Swiatkowski (15): > ice: make fwlog functions static > ice: move get_fwlog_data() to fwlog file > ice: drop ice_pf_fwlog_update_module() > ice: introduce ice_fwlog structure > ice: add pdev into fwlog structure and use it for logging > ice: allow calling custom send function in fwlog > ice: move out debugfs init from fwlog > ice: check for PF number outside the fwlog code nit: I think that patch 8/15 updates ice_fwlog_init() such that it begins with a blank line. I would delete it. > ice: drop driver specific structure from fwlog code > libie, ice: move fwlog admin queue to libie > ice: move debugfs code to fwlog > ice: prepare for moving file to libie > ice: reregister fwlog after driver reinit > ice, libie: move fwlog code to libie > ixgbe: fwlog support for e610 ... The nit above notwithstanding, this looks good to me. Please feel free to add: Reviewed-by: Simon Horman