From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FE8BCA0FE7 for ; Tue, 26 Aug 2025 15:52:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2332F60035; Tue, 26 Aug 2025 15:52:33 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id gukK2NHSfBWI; Tue, 26 Aug 2025 15:52:32 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org A79BF60586 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1756223552; bh=xn2QVJFsj4HJ+90OP93aEyUZIkHET4micAEgf76DaQI=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=6/Rm8+tdSs29AhdvwBR4242Xailq5L++9pvozpJT9GlqOAClesHEYh+2jENvTZqIN Q5AML++TSf2u8qj9I1ttsTnfgQdL2VVPLwJWeej6p9d1twXNYxuLPr4h8yA7PnY8cx YVOpIhaGKqwnIIzgGLOvttHKZKK0i0zUA7g7xXQIQrtrhkb+wsJhU7oCTyfLwr8veR scuJZGB7PJo8yydJ4J4y2P76FQQNN0X9uxS4pKoiAw6WfPm3FxCKVBgz0jdEUhsdVM ghY9OWI6qaUuG87Cw+NHUJ/V4F8Wu73Zq79Ia0N6BAqifnKEBtR9bSvtU38wrPrUB3 w4Oow7dbP8NaA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id A79BF60586; Tue, 26 Aug 2025 15:52:32 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id 66BFFB0B for ; Tue, 26 Aug 2025 15:52:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 5859A401FF for ; Tue, 26 Aug 2025 15:52:31 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id KSFDcLLdP9m5 for ; Tue, 26 Aug 2025 15:52:31 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org D1D57401FC DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D1D57401FC Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by smtp4.osuosl.org (Postfix) with ESMTPS id D1D57401FC for ; Tue, 26 Aug 2025 15:52:30 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 839DA42BA2; Tue, 26 Aug 2025 15:52:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1301DC113CF; Tue, 26 Aug 2025 15:52:27 +0000 (UTC) Date: Tue, 26 Aug 2025 16:52:25 +0100 From: Simon Horman To: Kohei Enju Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , kohei.enju@gmail.com Message-ID: <20250826155225.GC5892@horms.kernel.org> References: <20250813075206.70114-1-enjuk@amazon.com> <20250813075206.70114-3-enjuk@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250813075206.70114-3-enjuk@amazon.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756223550; bh=uDBeTmPv8qUYnsaeZ6TQuJA23FxviL4Fghpbh0NN7H0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RU/r9Sund3xTkuhzXlsz26/E/R4O9PNZ55Tn1GMiDSKHLmR99Ol6YPFWTZjI5FJqE bDbkq+eNy2l+nLHRcJ9cTsCi8FZb1YByUp5OHOcqg9wKRx3qDz6sukonGTOpnLM2Zn yFuji07uxovAaXITbxGjY+AlaztCS9b/wpe14rtxd47QScdAcz9hhSGw3uknrLr/AC azurJFt84j+V0sYz9U+33vwZsaulP0X9KAZhAbw6A60jilpq+iRxQ/F7hKBRzQMPhW CKpLQyeyy0AxMSNPXu2fNlogGe20Ik5dbGs/10vo8AoGqFlsociW4k9/JX7P0R9OiW rPyWxzt/w0Qtg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=RU/r9Sun Subject: Re: [Intel-wired-lan] [PATCH v1 iwl-next 2/2] igbvf: remove duplicated counter rx_long_byte_count from ethtool statistics X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Aug 13, 2025 at 04:50:51PM +0900, Kohei Enju wrote: > rx_long_byte_count shows the value of the GORC (Good Octets Received > Count) register. However, the register value is already shown as > rx_bytes and they always show the same value. > > Remove rx_long_byte_count as the Intel ethernet driver e1000e did in > commit 0a939912cf9c ("e1000e: cleanup redundant statistics counter"). > > Tested on Intel Corporation I350 Gigabit Network Connection. > > Tested-by: Kohei Enju > Signed-off-by: Kohei Enju Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BED6136C085; Tue, 26 Aug 2025 15:52:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756223550; cv=none; b=f82cPyOzuP3vY9pNnLQoaQpEiS4p9xiy9xPMoPQ9Yb+gIaRZnXvVoSeIjQXRwJ/Vlf4rpRB/BEBBXHJOlGcEkzY/+dzwc4EGAmm8ZwSD2mjDfBZKcKvZ2kMD3CBJaJO3NMK5IYpf93bJz0NtXrE4La55qZy8lDHYy0S28A1KSH0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756223550; c=relaxed/simple; bh=uDBeTmPv8qUYnsaeZ6TQuJA23FxviL4Fghpbh0NN7H0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EJCSmg2akczdoB7Zd1uKKRvpNf2KWqVSxAHl4igYXXlc7ui0uEJT6yYIHvH8DKJ/a8Yy01WqHhwfzXUnJBVBdpX/U65y0giZqMUcNiottNbeiHcDAv2jJxLeGuoUUp3gNn7yiMC5354qYP7yI4DK3p1mbsMXz3sBHCzLN8j8o40= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RU/r9Sun; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RU/r9Sun" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1301DC113CF; Tue, 26 Aug 2025 15:52:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756223550; bh=uDBeTmPv8qUYnsaeZ6TQuJA23FxviL4Fghpbh0NN7H0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RU/r9Sund3xTkuhzXlsz26/E/R4O9PNZ55Tn1GMiDSKHLmR99Ol6YPFWTZjI5FJqE bDbkq+eNy2l+nLHRcJ9cTsCi8FZb1YByUp5OHOcqg9wKRx3qDz6sukonGTOpnLM2Zn yFuji07uxovAaXITbxGjY+AlaztCS9b/wpe14rtxd47QScdAcz9hhSGw3uknrLr/AC azurJFt84j+V0sYz9U+33vwZsaulP0X9KAZhAbw6A60jilpq+iRxQ/F7hKBRzQMPhW CKpLQyeyy0AxMSNPXu2fNlogGe20Ik5dbGs/10vo8AoGqFlsociW4k9/JX7P0R9OiW rPyWxzt/w0Qtg== Date: Tue, 26 Aug 2025 16:52:25 +0100 From: Simon Horman To: Kohei Enju Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , kohei.enju@gmail.com Subject: Re: [PATCH v1 iwl-next 2/2] igbvf: remove duplicated counter rx_long_byte_count from ethtool statistics Message-ID: <20250826155225.GC5892@horms.kernel.org> References: <20250813075206.70114-1-enjuk@amazon.com> <20250813075206.70114-3-enjuk@amazon.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250813075206.70114-3-enjuk@amazon.com> On Wed, Aug 13, 2025 at 04:50:51PM +0900, Kohei Enju wrote: > rx_long_byte_count shows the value of the GORC (Good Octets Received > Count) register. However, the register value is already shown as > rx_bytes and they always show the same value. > > Remove rx_long_byte_count as the Intel ethernet driver e1000e did in > commit 0a939912cf9c ("e1000e: cleanup redundant statistics counter"). > > Tested on Intel Corporation I350 Gigabit Network Connection. > > Tested-by: Kohei Enju > Signed-off-by: Kohei Enju Reviewed-by: Simon Horman