From: David Aguilar <davvid@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Ezekiel Newren <ezekielnewren@gmail.com>,
Josh Steadmon <steadmon@google.com>,
Calvin Wan <calvinwan@google.com>,
Kyle Lippincott <spectral@google.com>
Subject: [PATCH] Makefile: build libgit-rs and libgit-sys serially
Date: Tue, 26 Aug 2025 09:04:37 -0700 [thread overview]
Message-ID: <20250826160437.2539113-1-davvid@gmail.com> (raw)
The "cargo build" invocations in contrib/ cannot be run in parallel.
"make -JN" with INCLUDE_LIBGIT_RS enabled causes cargo lock warnings
and can trigger ld errors during the build.
The build errors are caused by two inner "make" invocations getting
triggered concurrently: once inside of libgit-sys and another inside of
libgit-rs.
Signed-off-by: David Aguilar <davvid@gmail.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 29a53520fd..286d3ba3b2 100644
--- a/Makefile
+++ b/Makefile
@@ -3989,7 +3989,7 @@ libgit-sys libgit-rs:
cargo build \
)
ifdef INCLUDE_LIBGIT_RS
-all:: libgit-sys libgit-rs
+all:: libgit-sys .WAIT libgit-rs
endif
LIBGIT_PUB_OBJS += contrib/libgit-sys/public_symbol_export.o
--
2.50.0.7.gec2f25360c
next reply other threads:[~2025-08-26 16:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 16:04 David Aguilar [this message]
2025-08-26 16:46 ` [PATCH] Makefile: build libgit-rs and libgit-sys serially Junio C Hamano
2025-08-26 23:35 ` [PATCH v2] " David Aguilar
2025-08-26 23:48 ` Kyle Lippincott
2025-08-27 0:01 ` Junio C Hamano
2025-08-26 17:44 ` [PATCH] " Kyle Lippincott
2025-08-26 17:53 ` rsbecker
2025-08-26 18:02 ` Kyle Lippincott
2025-08-26 18:05 ` rsbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250826160437.2539113-1-davvid@gmail.com \
--to=davvid@gmail.com \
--cc=calvinwan@google.com \
--cc=ezekielnewren@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spectral@google.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.