From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77249CA0FF2 for ; Tue, 26 Aug 2025 16:33:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 39A5560643; Tue, 26 Aug 2025 16:33:25 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id HmpuQI8MADjL; Tue, 26 Aug 2025 16:33:23 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org BA3EF6062C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1756226003; bh=9fOsLYCRQRscd5NddJCtAO5qNFjVd28uOTLJKfsIYc8=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pC0I0e1Glxd9NXphdLWPSUxvWP5R8Wwfh+xdeHLXj4iA9tz1MC6G55EcICwSz2RxG FwDPBJu0xmvZ2vNob8dRYJ8JV66BXJNXhtM3DrGdmQcBAXwbWYZHwWucrR5lJJyuad 4IlMNRTDG2Z3p1kNaZyLDPI6wu8MupaZjhs4kA+xFFry1eFameomcWrzOzVYwlnTNo 9aPaqshRItUPo3aKtW+M3ucuGpryllaKtCCiRxOyDxWwAuVJhxYgcf/EqP1tl6BkiK 94xoqNf8N0Gy5Pd2/wo10fP6/9FqRHL16nvV1ng+Nr9qYMwM+bZPXJKmiH+JnofnZx mNFNi99MuiT6w== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id BA3EF6062C; Tue, 26 Aug 2025 16:33:23 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists1.osuosl.org (Postfix) with ESMTP id C0A4CB0B for ; Tue, 26 Aug 2025 16:33:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B2CC840080 for ; Tue, 26 Aug 2025 16:33:21 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id nBOu5oqR5GZm for ; Tue, 26 Aug 2025 16:33:21 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 29C4740062 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 29C4740062 Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by smtp2.osuosl.org (Postfix) with ESMTPS id 29C4740062 for ; Tue, 26 Aug 2025 16:33:21 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id DBD8741A22; Tue, 26 Aug 2025 16:33:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB6A0C4CEF1; Tue, 26 Aug 2025 16:33:18 +0000 (UTC) Date: Tue, 26 Aug 2025 17:33:16 +0100 From: Simon Horman To: Przemek Kitszel Cc: intel-wired-lan@lists.osuosl.org, Tony Nguyen , netdev@vger.kernel.org, Greg KH , jeremiah.kyle@intel.com, leszek.pepiak@intel.com, Lukasz Czapnik , Aleksandr Loktionov Message-ID: <20250826163316.GD5892@horms.kernel.org> References: <20250813104552.61027-1-przemyslaw.kitszel@intel.com> <20250813104552.61027-6-przemyslaw.kitszel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250813104552.61027-6-przemyslaw.kitszel@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756226000; bh=dCH9BJfNTHmofJpgfaBZCatTRuktCGZASw5OEhzVx0o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XLtREdGXKfQyf5MLxXbhJ8ZTQVzhZyRcM1k+iO/2FfIqX+yIzdZdO1789kRrvmZmx LKt7Fn2EiHAZaHqyc+v9Iw09dzUbuZXKCHVhGon0RSWWdcvTulNxK+oUjeGZlr3QnG ixuh8AVZTIOVdaTJquEMpxPYzvy3ZZgCxu0P1wJBPq3aGVilD0MnouFOhMI9Gi6rEg 8gnKUeiJkm0v0YHxQ1dHjiOJV31JEn6qK+HswducYkhK1nza8fwq4ywt9NZqrhvpPE WGmWNKFMbQc/+HyIzzxTYKUFIJBeXl6syZN8zxiXIiWyowR6UkJ5LeehvWZqCcjzIC ixPr3bajF2ysQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=XLtREdGX Subject: Re: [Intel-wired-lan] [PATCH iwl-net 5/8] i40e: fix validation of VF state in get resources X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Aug 13, 2025 at 12:45:15PM +0200, Przemek Kitszel wrote: > From: Lukasz Czapnik > > VF state I40E_VF_STATE_ACTIVE is not the only state in which > VF is actually active so it should not be used to determine > if a VF is allowed to obtain resources. > > Use I40E_VF_STATE_RESOURCES_LOADED that is set only in > i40e_vc_get_vf_resources_msg() and cleared during reset. > > Fixes: 61125b8be85d ("i40e: Fix failed opcode appearing if handling messages from VF") I suspect this could be Fixes: 5c3c48ac6bf5 ("i40e: implement virtual device interface") But I guess that either way is fine. > Cc: stable@vger.kernel.org > Signed-off-by: Lukasz Czapnik > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Przemek Kitszel Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D7792D2390 for ; Tue, 26 Aug 2025 16:33:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756226001; cv=none; b=gSwR4Q4FNLumyF9+tltfSRoYW2g7uMjZD5PsRh3h8JFPWbMiBVoZReYGiahHyXB6HkXbG1KOgonsB3XiCLZ7WMKv8bw2z9ou0WuJaRRPbO/C5HKm8w7GRtkOn24DKMsnD91sJkIjiNJ1RHLxY5p49OaA3FrHvNLGvPI8/U74lrE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756226001; c=relaxed/simple; bh=dCH9BJfNTHmofJpgfaBZCatTRuktCGZASw5OEhzVx0o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AFwkzU251zVrglUcyGJwvW8mFC+38pluNvq+fkgC/mX9bAfJ01dS4IRobGNXKOuqkCYdQ9jGtp0gLoqXYCpqvA/ikwg7r9OVAGvtfvZ4QNKwj5q+ZcshD/WrHjr5GedNmX98cFm5EgN+FB+HBNWjQDkAs82DbWCyaz4ZpRfgxQY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XLtREdGX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XLtREdGX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB6A0C4CEF1; Tue, 26 Aug 2025 16:33:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756226000; bh=dCH9BJfNTHmofJpgfaBZCatTRuktCGZASw5OEhzVx0o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XLtREdGXKfQyf5MLxXbhJ8ZTQVzhZyRcM1k+iO/2FfIqX+yIzdZdO1789kRrvmZmx LKt7Fn2EiHAZaHqyc+v9Iw09dzUbuZXKCHVhGon0RSWWdcvTulNxK+oUjeGZlr3QnG ixuh8AVZTIOVdaTJquEMpxPYzvy3ZZgCxu0P1wJBPq3aGVilD0MnouFOhMI9Gi6rEg 8gnKUeiJkm0v0YHxQ1dHjiOJV31JEn6qK+HswducYkhK1nza8fwq4ywt9NZqrhvpPE WGmWNKFMbQc/+HyIzzxTYKUFIJBeXl6syZN8zxiXIiWyowR6UkJ5LeehvWZqCcjzIC ixPr3bajF2ysQ== Date: Tue, 26 Aug 2025 17:33:16 +0100 From: Simon Horman To: Przemek Kitszel Cc: intel-wired-lan@lists.osuosl.org, Tony Nguyen , netdev@vger.kernel.org, Greg KH , jeremiah.kyle@intel.com, leszek.pepiak@intel.com, Lukasz Czapnik , Aleksandr Loktionov Subject: Re: [PATCH iwl-net 5/8] i40e: fix validation of VF state in get resources Message-ID: <20250826163316.GD5892@horms.kernel.org> References: <20250813104552.61027-1-przemyslaw.kitszel@intel.com> <20250813104552.61027-6-przemyslaw.kitszel@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250813104552.61027-6-przemyslaw.kitszel@intel.com> On Wed, Aug 13, 2025 at 12:45:15PM +0200, Przemek Kitszel wrote: > From: Lukasz Czapnik > > VF state I40E_VF_STATE_ACTIVE is not the only state in which > VF is actually active so it should not be used to determine > if a VF is allowed to obtain resources. > > Use I40E_VF_STATE_RESOURCES_LOADED that is set only in > i40e_vc_get_vf_resources_msg() and cleared during reset. > > Fixes: 61125b8be85d ("i40e: Fix failed opcode appearing if handling messages from VF") I suspect this could be Fixes: 5c3c48ac6bf5 ("i40e: implement virtual device interface") But I guess that either way is fine. > Cc: stable@vger.kernel.org > Signed-off-by: Lukasz Czapnik > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Przemek Kitszel Reviewed-by: Simon Horman