From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A175CA0FE7 for ; Tue, 26 Aug 2025 16:36:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 73A42404ED; Tue, 26 Aug 2025 16:36:16 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id kb2S6u8djHVF; Tue, 26 Aug 2025 16:36:16 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 0067D404EF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1756226176; bh=kQhrFgAVYjLH2NbTC+e5Itm42CqDknGpI7jbkYJ1yac=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=4I3uHqiuBKGotuotEl/KkCTLmhS+k7d4a22yVlj8KAaV4Bbz0TVyFlobZLYJOgmbV 9Q1Qy7euf3ecLfz0IjmUWlrjk+sAbGF8no/UinchxONu6FHTfky9k/lPS9IYa/XGX5 BEBO/V13I8v1BsarNDKlHlMjjgwGZi7hqHW8kT8pAEWjmc3gLq3w4gTTAJJSQZmsii T379N6AXwTW2eQPSG+BM30/AeZQF/EwQ0ylkqRR2c9FCiMMZGCD5ManJ89chXQidOo cuYvxwoo4jqtbF7Iapvfeeed3gf0bzl2RhkThejeTsrMZfrzVrUPJaUwXTAP3gSVPR 9lw99aJTTTr8g== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 0067D404EF; Tue, 26 Aug 2025 16:36:15 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id 41496B0B for ; Tue, 26 Aug 2025 16:36:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 27C2D4008A for ; Tue, 26 Aug 2025 16:36:14 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 8Tbk_aEP9eoR for ; Tue, 26 Aug 2025 16:36:13 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 8DB1140080 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 8DB1140080 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp2.osuosl.org (Postfix) with ESMTPS id 8DB1140080 for ; Tue, 26 Aug 2025 16:36:13 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 9D9CF601E9; Tue, 26 Aug 2025 16:36:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28523C4CEF1; Tue, 26 Aug 2025 16:36:08 +0000 (UTC) Date: Tue, 26 Aug 2025 17:36:06 +0100 From: Simon Horman To: Przemek Kitszel Cc: intel-wired-lan@lists.osuosl.org, Tony Nguyen , netdev@vger.kernel.org, Greg KH , jeremiah.kyle@intel.com, leszek.pepiak@intel.com, Lukasz Czapnik , Aleksandr Loktionov Message-ID: <20250826163606.GJ5892@horms.kernel.org> References: <20250813104552.61027-1-przemyslaw.kitszel@intel.com> <20250813104552.61027-6-przemyslaw.kitszel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250813104552.61027-6-przemyslaw.kitszel@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756226171; bh=EJ98GjaezkjirbUv6wCZyS8npF4TyMEdwhhAxJrJCOo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZpB6Jgm0sLzZHvpEcduIawO+NsugFIOKapOChDSoXIquWEWUU8JXrW372q0bnYprL +/vyFz3DunFXxHXkEFbbRSZssbZsc+mLuChpzs4HYdRj69ulYrKausBJme6DYyq4GL GVFEY4rsjdv3pfivdlrOYp7hCerK49IZ0gIvFCpI5HcHCR2cvqts941xMl6kz+Tfue cdtLEZEL2yknRDHfcSTDfsaqe8d0StuJzPhIwKiJlW5JLLm1w1mTQA3eKw92C3fgPr BEZahZl9ZivuKaDpCjB3gruALkG93WfOYQJOubYPmsbBZkxfTR916y3AkcKLp2whtV pIU/tUr+S5pqg== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ZpB6Jgm0 Subject: Re: [Intel-wired-lan] [PATCH iwl-net 5/8] i40e: fix validation of VF state in get resources X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Aug 13, 2025 at 12:45:15PM +0200, Przemek Kitszel wrote: > From: Lukasz Czapnik > > VF state I40E_VF_STATE_ACTIVE is not the only state in which > VF is actually active so it should not be used to determine > if a VF is allowed to obtain resources. > > Use I40E_VF_STATE_RESOURCES_LOADED that is set only in > i40e_vc_get_vf_resources_msg() and cleared during reset. > > Fixes: 61125b8be85d ("i40e: Fix failed opcode appearing if handling messages from VF") > Cc: stable@vger.kernel.org > Signed-off-by: Lukasz Czapnik > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Przemek Kitszel Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75CB8196C7C for ; Tue, 26 Aug 2025 16:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756226172; cv=none; b=mFuQgWGH6Xd3cWpsUnje+S8Indq8YOR0M95prLSLN49W47iiQ08qMgf4o3vxz2nnpWYB+x6mxKqEBsjpGCyHiTWsGbwvZ7s0c82EBlThOfW5mYLlbd7ITbFrFEP4rdSc4nVc1oEDtJ7b/sTtTNNx4/pLVl7w61Q9zvpgubGFBAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756226172; c=relaxed/simple; bh=EJ98GjaezkjirbUv6wCZyS8npF4TyMEdwhhAxJrJCOo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u+7Mn4fOV1u5RvEJKpuOV36Wh5oqZUQ+a1fknf0RAZINiM5bxmPfgVnguklO9y6TBXALaQlh0bQhyuR9qFq697R0CaSuxQ8PEFGylET0httNXCHWUfC2x6Z4uv/0VXJjaqC/idFLt+iGtQVXk3AOxu5S21a3NOopNQNixa3oukk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZpB6Jgm0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZpB6Jgm0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28523C4CEF1; Tue, 26 Aug 2025 16:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756226171; bh=EJ98GjaezkjirbUv6wCZyS8npF4TyMEdwhhAxJrJCOo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZpB6Jgm0sLzZHvpEcduIawO+NsugFIOKapOChDSoXIquWEWUU8JXrW372q0bnYprL +/vyFz3DunFXxHXkEFbbRSZssbZsc+mLuChpzs4HYdRj69ulYrKausBJme6DYyq4GL GVFEY4rsjdv3pfivdlrOYp7hCerK49IZ0gIvFCpI5HcHCR2cvqts941xMl6kz+Tfue cdtLEZEL2yknRDHfcSTDfsaqe8d0StuJzPhIwKiJlW5JLLm1w1mTQA3eKw92C3fgPr BEZahZl9ZivuKaDpCjB3gruALkG93WfOYQJOubYPmsbBZkxfTR916y3AkcKLp2whtV pIU/tUr+S5pqg== Date: Tue, 26 Aug 2025 17:36:06 +0100 From: Simon Horman To: Przemek Kitszel Cc: intel-wired-lan@lists.osuosl.org, Tony Nguyen , netdev@vger.kernel.org, Greg KH , jeremiah.kyle@intel.com, leszek.pepiak@intel.com, Lukasz Czapnik , Aleksandr Loktionov Subject: Re: [PATCH iwl-net 5/8] i40e: fix validation of VF state in get resources Message-ID: <20250826163606.GJ5892@horms.kernel.org> References: <20250813104552.61027-1-przemyslaw.kitszel@intel.com> <20250813104552.61027-6-przemyslaw.kitszel@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250813104552.61027-6-przemyslaw.kitszel@intel.com> On Wed, Aug 13, 2025 at 12:45:15PM +0200, Przemek Kitszel wrote: > From: Lukasz Czapnik > > VF state I40E_VF_STATE_ACTIVE is not the only state in which > VF is actually active so it should not be used to determine > if a VF is allowed to obtain resources. > > Use I40E_VF_STATE_RESOURCES_LOADED that is set only in > i40e_vc_get_vf_resources_msg() and cleared during reset. > > Fixes: 61125b8be85d ("i40e: Fix failed opcode appearing if handling messages from VF") > Cc: stable@vger.kernel.org > Signed-off-by: Lukasz Czapnik > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Przemek Kitszel Reviewed-by: Simon Horman