From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21655CA0FE7 for ; Tue, 26 Aug 2025 16:36:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id EBFB7404FE; Tue, 26 Aug 2025 16:36:57 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id M3cZt5ROsr5a; Tue, 26 Aug 2025 16:36:57 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 757724050B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1756226217; bh=jkOswG6qieN/shBoOaHyFGLLe6NB1PyA4m8HjLcbLBg=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=yVjr9MYw0vuxO8IYY9QjAGTXaem7ybRv0E6/gAHhuvY+BI8h97Ot+AsYnE/3WoEZd 8W+h65DOQjZ/aRsagAfOU90STfqbp7o4cg06EZnh3aa1Bhhu4N4NoZ8DzcLS9W3kuk oIFj3rDXUdWMzuGZ+3ZLYC5tQ/j3UfVFPOWKt0D072+GfYKvDWtjztlvxMgFgDIlEg hfrHsCIHNTYA8bloZTZC2e+ixlDG5ItOwERaWBPdNZSj1fbuPKE7/nqjReRL/4tnlz /7RqRxXknxGPCUh4FS66VDKakheH8Eia9YKNQqX5XXoI+nIvKGDNGpTun8cuCnqKlP VSoYq1DBAZTGg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 757724050B; Tue, 26 Aug 2025 16:36:57 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 3D390114 for ; Tue, 26 Aug 2025 16:36:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2E2D580A64 for ; Tue, 26 Aug 2025 16:36:56 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id wJoUF3L5nZi8 for ; Tue, 26 Aug 2025 16:36:55 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org A3D5980A61 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A3D5980A61 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp1.osuosl.org (Postfix) with ESMTPS id A3D5980A61 for ; Tue, 26 Aug 2025 16:36:55 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 7572C447B2; Tue, 26 Aug 2025 16:36:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D2DDC4CEF1; Tue, 26 Aug 2025 16:36:52 +0000 (UTC) Date: Tue, 26 Aug 2025 17:36:50 +0100 From: Simon Horman To: Przemek Kitszel Cc: intel-wired-lan@lists.osuosl.org, Tony Nguyen , netdev@vger.kernel.org, Greg KH , jeremiah.kyle@intel.com, leszek.pepiak@intel.com, Lukasz Czapnik , Aleksandr Loktionov Message-ID: <20250826163650.GL5892@horms.kernel.org> References: <20250813104552.61027-1-przemyslaw.kitszel@intel.com> <20250813104552.61027-9-przemyslaw.kitszel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250813104552.61027-9-przemyslaw.kitszel@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756226214; bh=RUebI+LLPCOnHLuFhlypq+cjnus+GGm+ptjDxaXfbq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IQjC0POhP2Jf52omzRG8r/pqXyD3uR+hdK4nF8NXRDiufluqzJrkrV24HLIxfl8NK Q39VyyxGu+Z2QrrZZ9kevhZxdJ1W+ROdFqn12LGeq6IjazSRxkg5kK0x+ExkW4HQcw DfXX8qShi0ttEwM2JGii5VNL+oMeRn82ZIEegIRp/+nPhdkCEnTKWd1NmiE00K38So 3APgFrD2kyk21EPSIg2SGJwwKy7p12LKoRVoBqEal/TcaIgC+6UxxKIn5ooJU72OPz t5mOKcvdGDjWz9R9xMQ4yRkuFZsrB2aIeAaPPXG/rh+KhRNRIItr8tvdFjTn2KsBOP DsFZIEOhr4Ltw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=IQjC0POh Subject: Re: [Intel-wired-lan] [PATCH iwl-net 8/8] i40e: improve VF MAC filters accounting X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Aug 13, 2025 at 12:45:18PM +0200, Przemek Kitszel wrote: > From: Lukasz Czapnik > > When adding new VM MAC, driver checks only *active* filters in > vsi->mac_filter_hash. Each MAC, even in non-active state is using resources. > > To determine number of MACs VM uses, count VSI filters in *any* state. > > Add i40e_count_all_filters() to simply count all filters, and rename > i40e_count_filters() to i40e_count_active_filters() to avoid ambiguity. > > Fixes: cfb1d572c986 ("i40e: Add ensurance of MacVlan resources for every trusted VF") > Cc: stable@vger.kernel.org > Signed-off-by: Lukasz Czapnik > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Przemek Kitszel Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71F7530BBA9 for ; Tue, 26 Aug 2025 16:36:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756226214; cv=none; b=MvDfi+a/U22csMtaEDXHlt4AsENkaMjmpqyuqKsEaNHm74Gtes5IAGPpBdudLVRYtdiYTZIF90hTjUQe6r+s0Rgfiz9fCsKF+RJgIp2Iaw1/fsJP13D62Z1wPWObgyDPeoyfnNz3e/lIopLfLEWoE6F0NVrgaPSdetiTeKO4CRs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756226214; c=relaxed/simple; bh=RUebI+LLPCOnHLuFhlypq+cjnus+GGm+ptjDxaXfbq4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gvTEPgy2LVFN8SGRsqjvqY+o5Sn1TUYCcHj1z5lPHPU9mGcsXIJxpD2ImY1Q++M9BEcg1FqRHvqYzQcFEmRGLkzvWSwW2sGvXWAtn3J/CWQBlXcLMgWFxsU1z2nEemzLxvY7liVa0WL4lZQcQpOdy7hVmH4KTwB9TX8rOQl+m2w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IQjC0POh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IQjC0POh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D2DDC4CEF1; Tue, 26 Aug 2025 16:36:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756226214; bh=RUebI+LLPCOnHLuFhlypq+cjnus+GGm+ptjDxaXfbq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IQjC0POhP2Jf52omzRG8r/pqXyD3uR+hdK4nF8NXRDiufluqzJrkrV24HLIxfl8NK Q39VyyxGu+Z2QrrZZ9kevhZxdJ1W+ROdFqn12LGeq6IjazSRxkg5kK0x+ExkW4HQcw DfXX8qShi0ttEwM2JGii5VNL+oMeRn82ZIEegIRp/+nPhdkCEnTKWd1NmiE00K38So 3APgFrD2kyk21EPSIg2SGJwwKy7p12LKoRVoBqEal/TcaIgC+6UxxKIn5ooJU72OPz t5mOKcvdGDjWz9R9xMQ4yRkuFZsrB2aIeAaPPXG/rh+KhRNRIItr8tvdFjTn2KsBOP DsFZIEOhr4Ltw== Date: Tue, 26 Aug 2025 17:36:50 +0100 From: Simon Horman To: Przemek Kitszel Cc: intel-wired-lan@lists.osuosl.org, Tony Nguyen , netdev@vger.kernel.org, Greg KH , jeremiah.kyle@intel.com, leszek.pepiak@intel.com, Lukasz Czapnik , Aleksandr Loktionov Subject: Re: [PATCH iwl-net 8/8] i40e: improve VF MAC filters accounting Message-ID: <20250826163650.GL5892@horms.kernel.org> References: <20250813104552.61027-1-przemyslaw.kitszel@intel.com> <20250813104552.61027-9-przemyslaw.kitszel@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250813104552.61027-9-przemyslaw.kitszel@intel.com> On Wed, Aug 13, 2025 at 12:45:18PM +0200, Przemek Kitszel wrote: > From: Lukasz Czapnik > > When adding new VM MAC, driver checks only *active* filters in > vsi->mac_filter_hash. Each MAC, even in non-active state is using resources. > > To determine number of MACs VM uses, count VSI filters in *any* state. > > Add i40e_count_all_filters() to simply count all filters, and rename > i40e_count_filters() to i40e_count_active_filters() to avoid ambiguity. > > Fixes: cfb1d572c986 ("i40e: Add ensurance of MacVlan resources for every trusted VF") > Cc: stable@vger.kernel.org > Signed-off-by: Lukasz Czapnik > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Przemek Kitszel Reviewed-by: Simon Horman