From: Jason Andryuk <jason.andryuk@amd.com>
To: <xen-devel@lists.xenproject.org>
Cc: Jason Andryuk <jason.andryuk@amd.com>,
Anthony PERARD <anthony.perard@vates.tech>
Subject: [PATCH v3 4/8] tools/init-dom0less: Switch domain_exists to check xenstore name
Date: Tue, 26 Aug 2025 17:08:43 -0400 [thread overview]
Message-ID: <20250826210847.126015-5-jason.andryuk@amd.com> (raw)
In-Reply-To: <20250826210847.126015-1-jason.andryuk@amd.com>
Previously, the xenstore "introduced" state was used to avoid running
init-dom0less twice on the same domain. With xenstored
auto-introduction, that can no longer be used. Instead check of the
domain's name has been set and use that to determine whether or not to
bail out.
Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
---
v3:
Move xenstore reading into domain_exists()
Reorder
---
tools/helpers/init-dom0less.c | 21 ++++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c
index 3906c4b61a..eb793c7aab 100644
--- a/tools/helpers/init-dom0less.c
+++ b/tools/helpers/init-dom0less.c
@@ -60,6 +60,19 @@ static int get_xs_page(libxl_dominfo *info, uint64_t *xenstore_pfn)
return 0;
}
+static char *do_xs_read_dom(struct xs_handle *xsh, xs_transaction_t t,
+ domid_t domid, char *path)
+{
+ char full_path[STR_MAX_LENGTH];
+ int rc;
+
+ rc = snprintf(full_path, STR_MAX_LENGTH,
+ "/local/domain/%u/%s", domid, path);
+ if (rc < 0 || rc >= STR_MAX_LENGTH)
+ return NULL;
+ return xs_read(xsh, t, full_path, NULL);
+}
+
static bool do_xs_write_dom(struct xs_handle *xsh, xs_transaction_t t,
domid_t domid, char *path, char *val)
{
@@ -332,7 +345,13 @@ static int init_domain(libxl_dominfo *info)
/* Check if domain has been configured in XS */
static bool domain_exists(int domid)
{
- return xs_is_domain_introduced(xsh, domid);
+ char *name = do_xs_read_dom(xsh, XBT_NULL, domid, "name");
+ if (name) {
+ free(name);
+ return true;
+ }
+
+ return false;
}
int main(int argc, char **argv)
--
2.50.1
next prev parent reply other threads:[~2025-08-26 21:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 21:08 [PATCH v3 0/8] init-dom0less and dom0less xenstore evtchn Jason Andryuk
2025-08-26 21:08 ` [PATCH v3 1/8] tools/init-dom0less: Make handles global Jason Andryuk
2025-08-27 15:12 ` Jürgen Groß
2025-08-26 21:08 ` [PATCH v3 2/8] tools/init-dom0less: Factor out xenstore setup Jason Andryuk
2025-08-26 21:08 ` [PATCH v3 3/8] tools/init-dom0less: Only introduce un-introduced domains Jason Andryuk
2025-08-26 21:08 ` Jason Andryuk [this message]
2025-08-26 21:08 ` [PATCH v3 5/8] tools/init-dom0less: Use introduced to determine no-enhanced Jason Andryuk
2025-08-26 21:08 ` [PATCH v3 6/8] tools/init-dom0less: Remove use of err() Jason Andryuk
2025-08-26 21:08 ` [PATCH v3 7/8] tools/init-dom0less: Continue on error Jason Andryuk
2025-08-26 21:08 ` [PATCH v3 8/8] xen/dom0less: store xenstore event channel in page Jason Andryuk
2025-08-27 7:58 ` Jan Beulich
2025-08-27 13:19 ` Jason Andryuk
2025-08-27 14:00 ` Jan Beulich
2025-08-27 8:03 ` Orzel, Michal
2025-08-27 13:24 ` Jason Andryuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250826210847.126015-5-jason.andryuk@amd.com \
--to=jason.andryuk@amd.com \
--cc=anthony.perard@vates.tech \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.