diff for duplicates of <202508270603.MDqIVFss-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index f4a2022..b0d33f2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,22 +1,13 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -CC: linux-media@vger.kernel.org -TO: "André Apitzsch" <git@apitzsch.eu> -CC: Sakari Ailus <sakari.ailus@linux.intel.com> -CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com> - tree: git://linuxtv.org/sailus/media_tree.git cleanup head: 9a8e7210e8e21ebba263affd0d7481ef0d6c323e commit: 7407c0acdb2ff0c1e3a962543db7d775b3b611c8 [30/54] media: i2c: imx214: Move imx214_pll_update to imx214_ctrls_init -:::::: branch date: 5 days ago -:::::: commit date: 5 days ago config: i386-randconfig-141-20250827 (https://download.01.org/0day-ci/archive/20250827/202508270603.MDqIVFss-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> -| Reported-by: Dan Carpenter <error27@gmail.com> +| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> | Closes: https://lore.kernel.org/r/202508270603.MDqIVFss-lkp@intel.com/ smatch warnings: @@ -24,7 +15,6 @@ drivers/media/i2c/imx214.c:1109 imx214_ctrls_init() error: we previously assumed vim +1109 drivers/media/i2c/imx214.c -7407c0acdb2ff0 André Apitzsch 2025-06-30 986 4f302d004bd0fc André Apitzsch 2023-12-06 987 static int imx214_ctrls_init(struct imx214 *imx214) 4f302d004bd0fc André Apitzsch 2023-12-06 988 { 4f302d004bd0fc André Apitzsch 2023-12-06 989 static const struct v4l2_area unit_size = { @@ -56,6 +46,9 @@ b9b359662952ff André Apitzsch 2025-05-24 1011 INT_MAX, 1, 1); b9b359662952ff André Apitzsch 2025-05-24 1015 imx214->bus_cfg.nr_of_link_frequencies - 1, b9b359662952ff André Apitzsch 2025-05-24 1016 0, imx214->bus_cfg.link_frequencies); 4f302d004bd0fc André Apitzsch 2023-12-06 @1017 if (imx214->link_freq) + ^^^^^^^^^^^^^^^^^ +This assumes ->link_freq can be NULL. + 4f302d004bd0fc André Apitzsch 2023-12-06 1018 imx214->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY; 4f302d004bd0fc André Apitzsch 2023-12-06 1019 4f302d004bd0fc André Apitzsch 2023-12-06 1020 /* @@ -148,6 +141,9 @@ a5bd42aafb0684 Hans Verkuil 2025-02-03 1098 v4l2_ctrl_ptr_create(NULL)); 4f302d004bd0fc André Apitzsch 2023-12-06 1107 } 4f302d004bd0fc André Apitzsch 2023-12-06 1108 7407c0acdb2ff0 André Apitzsch 2025-06-30 @1109 ret = imx214_pll_update(imx214); + ^^^^^^ +This adds an unchecked dereference. + 7407c0acdb2ff0 André Apitzsch 2025-06-30 1110 if (ret < 0) { 7407c0acdb2ff0 André Apitzsch 2025-06-30 1111 v4l2_ctrl_handler_free(ctrl_hdlr); 7407c0acdb2ff0 André Apitzsch 2025-06-30 1112 dev_err(imx214->dev, "failed to update PLL\n"); @@ -158,7 +154,6 @@ a5bd42aafb0684 Hans Verkuil 2025-02-03 1098 v4l2_ctrl_ptr_create(NULL)); 4f302d004bd0fc André Apitzsch 2023-12-06 1117 4f302d004bd0fc André Apitzsch 2023-12-06 1118 return 0; 4f302d004bd0fc André Apitzsch 2023-12-06 1119 }; -4f302d004bd0fc André Apitzsch 2023-12-06 1120 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 9a80043..451bdfd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,30 +1,25 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@linaro.org>\0" "Subject\0[sailus-media-tree:cleanup 30/54] drivers/media/i2c/imx214.c:1109 imx214_ctrls_init() error: we previously assumed 'imx214->link_freq' could be null (see line 1017)\0" - "Date\0Wed, 27 Aug 2025 06:08:45 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Wed, 27 Aug 2025 10:17:26 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Andr\303\251 Apitzsch <git@apitzsch.eu>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + oe-kbuild-all@lists.linux.dev + linux-media@vger.kernel.org + Sakari Ailus <sakari.ailus@linux.intel.com> + " Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "CC: linux-media@vger.kernel.org\n" - "TO: \"Andr\303\251 Apitzsch\" <git@apitzsch.eu>\n" - "CC: Sakari Ailus <sakari.ailus@linux.intel.com>\n" - "CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n" - "\n" "tree: git://linuxtv.org/sailus/media_tree.git cleanup\n" "head: 9a8e7210e8e21ebba263affd0d7481ef0d6c323e\n" "commit: 7407c0acdb2ff0c1e3a962543db7d775b3b611c8 [30/54] media: i2c: imx214: Move imx214_pll_update to imx214_ctrls_init\n" - ":::::: branch date: 5 days ago\n" - ":::::: commit date: 5 days ago\n" "config: i386-randconfig-141-20250827 (https://download.01.org/0day-ci/archive/20250827/202508270603.MDqIVFss-lkp@intel.com/config)\n" "compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0\n" "\n" "If you fix the issue in a separate patch/commit (i.e. not just a new version of\n" "the same patch/commit), kindly add following tags\n" "| Reported-by: kernel test robot <lkp@intel.com>\n" - "| Reported-by: Dan Carpenter <error27@gmail.com>\n" + "| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>\n" "| Closes: https://lore.kernel.org/r/202508270603.MDqIVFss-lkp@intel.com/\n" "\n" "smatch warnings:\n" @@ -32,7 +27,6 @@ "\n" "vim +1109 drivers/media/i2c/imx214.c\n" "\n" - "7407c0acdb2ff0 Andr\303\251 Apitzsch 2025-06-30 986 \n" "4f302d004bd0fc Andr\303\251 Apitzsch 2023-12-06 987 static int imx214_ctrls_init(struct imx214 *imx214)\n" "4f302d004bd0fc Andr\303\251 Apitzsch 2023-12-06 988 {\n" "4f302d004bd0fc Andr\303\251 Apitzsch 2023-12-06 989 \tstatic const struct v4l2_area unit_size = {\n" @@ -64,6 +58,9 @@ "b9b359662952ff Andr\303\251 Apitzsch 2025-05-24 1015 \t\t\t\t\t\t imx214->bus_cfg.nr_of_link_frequencies - 1,\n" "b9b359662952ff Andr\303\251 Apitzsch 2025-05-24 1016 \t\t\t\t\t\t 0, imx214->bus_cfg.link_frequencies);\n" "4f302d004bd0fc Andr\303\251 Apitzsch 2023-12-06 @1017 \tif (imx214->link_freq)\n" + " ^^^^^^^^^^^^^^^^^\n" + "This assumes ->link_freq can be NULL.\n" + "\n" "4f302d004bd0fc Andr\303\251 Apitzsch 2023-12-06 1018 \t\timx214->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;\n" "4f302d004bd0fc Andr\303\251 Apitzsch 2023-12-06 1019 \n" "4f302d004bd0fc Andr\303\251 Apitzsch 2023-12-06 1020 \t/*\n" @@ -156,6 +153,9 @@ "4f302d004bd0fc Andr\303\251 Apitzsch 2023-12-06 1107 \t}\n" "4f302d004bd0fc Andr\303\251 Apitzsch 2023-12-06 1108 \n" "7407c0acdb2ff0 Andr\303\251 Apitzsch 2025-06-30 @1109 \tret = imx214_pll_update(imx214);\n" + " ^^^^^^\n" + "This adds an unchecked dereference.\n" + "\n" "7407c0acdb2ff0 Andr\303\251 Apitzsch 2025-06-30 1110 \tif (ret < 0) {\n" "7407c0acdb2ff0 Andr\303\251 Apitzsch 2025-06-30 1111 \t\tv4l2_ctrl_handler_free(ctrl_hdlr);\n" "7407c0acdb2ff0 Andr\303\251 Apitzsch 2025-06-30 1112 \t\tdev_err(imx214->dev, \"failed to update PLL\\n\");\n" @@ -166,10 +166,9 @@ "4f302d004bd0fc Andr\303\251 Apitzsch 2023-12-06 1117 \n" "4f302d004bd0fc Andr\303\251 Apitzsch 2023-12-06 1118 \treturn 0;\n" "4f302d004bd0fc Andr\303\251 Apitzsch 2023-12-06 1119 };\n" - "4f302d004bd0fc Andr\303\251 Apitzsch 2023-12-06 1120 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -3c540b555080b4ed185d09a4c539c646e029c7d72e8a0544211a6989edb47935 +b59682a493d3bdb30d951dbd48880c3c9495944183e01c8c3ea4843bf7fd5160
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.