From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jakub Acs <acsjakub@amazon.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Fernando Fernandez Mancera <ffmancera@riseup.net>,
Taehee Yoo <ap420073@gmail.com>
Subject: Re: [PATCH net] hsr: use netdev_master_upper_dev_link() when linking lower ports
Date: Wed, 27 Aug 2025 18:06:03 -0700 [thread overview]
Message-ID: <20250827180603.001b85b3@kernel.org> (raw)
In-Reply-To: <20250826013352.425997-1-liuhangbin@gmail.com>
On Tue, 26 Aug 2025 01:33:52 +0000 Hangbin Liu wrote:
> Unlike VLAN devices, HSR changes the lower device’s rx_handler, which
> prevents the lower device from being attached to another master.
> Switch to using netdev_master_upper_dev_link() when setting up the lower
> device.
>
> This also improves user experience, since ip link will now display the
^^^^
Why this "also" here? You haven't mentioned any benefit of this change
up to this point. AFAIK having the master link is the only one?
> HSR device as the master for its ports.
>
> Fixes: e0a4b99773d3 ("hsr: use upper/lower device infrastructure")
The current behavior is 5 years old, AFAICT. We need a reason to treat
this as a fix, right now this looks like net-next material..
--
pw-bot: cr
next prev parent reply other threads:[~2025-08-28 1:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 1:33 [PATCH net] hsr: use netdev_master_upper_dev_link() when linking lower ports Hangbin Liu
2025-08-28 1:06 ` Jakub Kicinski [this message]
2025-08-28 4:04 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250827180603.001b85b3@kernel.org \
--to=kuba@kernel.org \
--cc=acsjakub@amazon.de \
--cc=ap420073@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ffmancera@riseup.net \
--cc=horms@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.