From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16589CA0EFF for ; Wed, 27 Aug 2025 18:26:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D066210E882; Wed, 27 Aug 2025 18:26:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="IEB9Wyp4"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id BF71210E0A0 for ; Wed, 27 Aug 2025 18:26:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1756319176; x=1787855176; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=doJRTwFFr15BPxQ/4Lv1HD5pKpwv17NsL3OgMBP3cJQ=; b=IEB9Wyp4vcTMV/Vm6UTE8tlEpo20yYJhQgX8KB8r7vfj70sUTfhwyYoT 3vHSdW/zVSwrSccKPvOs9t0h6QKMkWBcy2za/1osVK9Eex/rff7AGGDmX QLhen3pilIJPgZ/cfhrwUorLmrpS99ZXdNEqeFi6asSDCzXAwFdqK3GKi FYteY9VUFtI3/jN63ZSYK6W2ncX5fWGnXbByh1sfRojbGKdHLeYY6JsPk e9Sc6Qln3PwRpnI23WK1DYUdE51dSWkOl05TVnY7sSUcTTwB9PnO1361X 1Y5Xe6Oym3cNe2CajaGI8d8gxsNNw34nKuFX5pXFzFn9+Do/MVf84+2dE w==; X-CSE-ConnectionGUID: prqgZOw4SaGoocT7bftgcw== X-CSE-MsgGUID: ahdKkacpQGCPEOprfFDVBw== X-IronPort-AV: E=McAfee;i="6800,10657,11535"; a="69949633" X-IronPort-AV: E=Sophos;i="6.18,217,1751266800"; d="scan'208";a="69949633" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2025 11:26:15 -0700 X-CSE-ConnectionGUID: PS5v1pYcQiiy6/oIteIFpA== X-CSE-MsgGUID: 34KiotFpS4y6YsVpXCyCjw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,217,1751266800"; d="scan'208";a="169158798" Received: from dut4086lnl.fm.intel.com ([10.105.10.138]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2025 11:26:15 -0700 From: Jonathan Cavitt To: intel-xe@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, john.c.harrison@intel.com, matthew.brost@intel.com, michal.wajdeczko@intel.com Subject: [PATCH v4 0/3] drm/xe/xe_vm: Add error injection support to lock and prep Date: Wed, 27 Aug 2025 18:26:13 +0000 Message-ID: <20250827182612.106364-5-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Error injection should use the error injection interface, and should be decoupled from CONFIG_DRM_XE_DEBUG. Remove TEST_VM_OPS_ERROR from the code, and add error injection support to the function vm_bind_ioctl_ops_lock_and_prep. This necessitates marking the function as noinline. v2: Only noinline vm_bind_ioctl_ops_lock_and_prep when function error injection is enabled (Brost) v3: Add error_injectable function attribute (Brost, Harrison) v4: Modify where error_injectable is defined and used (Brost, Wajdeczko) Jonathan Cavitt (3): drm/xe: Add error_injectable define Revert "drm/xe: Add VM bind IOCTL error injection" drm/xe/xe_vm: Add error injection support to lock and prep drivers/gpu/drm/xe/xe_device.c | 3 ++ drivers/gpu/drm/xe/xe_device_types.h | 12 -------- drivers/gpu/drm/xe/xe_exec_queue.c | 2 ++ drivers/gpu/drm/xe/xe_ggtt.c | 1 + drivers/gpu/drm/xe/xe_guc.c | 1 + drivers/gpu/drm/xe/xe_guc_ads.c | 1 + drivers/gpu/drm/xe/xe_guc_ct.c | 20 ++++--------- drivers/gpu/drm/xe/xe_guc_log.c | 1 + drivers/gpu/drm/xe/xe_guc_relay.c | 1 + drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c | 2 ++ drivers/gpu/drm/xe/xe_hw_engine_group.c | 1 + drivers/gpu/drm/xe/xe_macros.h | 6 ++++ drivers/gpu/drm/xe/xe_mmio.c | 1 + drivers/gpu/drm/xe/xe_oa.c | 1 + drivers/gpu/drm/xe/xe_pcode.c | 2 ++ drivers/gpu/drm/xe/xe_pm.c | 1 + drivers/gpu/drm/xe/xe_pt.c | 15 ++-------- drivers/gpu/drm/xe/xe_sriov.c | 2 ++ drivers/gpu/drm/xe/xe_sync.c | 1 + drivers/gpu/drm/xe/xe_tile.c | 1 + drivers/gpu/drm/xe/xe_tuning.c | 2 ++ drivers/gpu/drm/xe/xe_uc_fw.c | 1 + drivers/gpu/drm/xe/xe_vm.c | 30 +++++-------------- drivers/gpu/drm/xe/xe_vm_types.h | 14 --------- drivers/gpu/drm/xe/xe_wa.c | 2 ++ drivers/gpu/drm/xe/xe_wopcm.c | 1 + 26 files changed, 50 insertions(+), 75 deletions(-) -- 2.43.0