All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Daniel Tang <danielzgtg.opensource@gmail.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH v2] acpi: TAD: Add missing sysfs_remove_group for ACPI_TAD_RT
Date: Thu, 28 Aug 2025 10:13:45 +0200	[thread overview]
Message-ID: <20250828081345.GV476609@black.igk.intel.com> (raw)
In-Reply-To: <2881298.hMirdbgypa@daniel-desktop3>

On Thu, Aug 28, 2025 at 01:38:14AM -0400, Daniel Tang wrote:
> Previously, after `rmmod acpi_tad`, `modprobe acpi_tad` would fail
> with this dmesg:
> 
> sysfs: cannot create duplicate filename '/devices/platform/ACPI000E:00/time'
> Call Trace:
>  <TASK>
>  dump_stack_lvl+0x6c/0x90
>  dump_stack+0x10/0x20
>  sysfs_warn_dup+0x8b/0xa0
>  sysfs_add_file_mode_ns+0x122/0x130
>  internal_create_group+0x1dd/0x4c0
>  sysfs_create_group+0x13/0x20
>  acpi_tad_probe+0x147/0x1f0 [acpi_tad]
>  platform_probe+0x42/0xb0
>  </TASK>
> acpi-tad ACPI000E:00: probe with driver acpi-tad failed with error -17
> 
> Fixes: 3230b2b3c1ab ("ACPI: TAD: Add low-level support for real time capability")
> Signed-off-by: Daniel Tang <danielzgtg.opensource@gmail.com>

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

  reply	other threads:[~2025-08-28  8:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-27 22:51 [PATCH] acpi: TAD: Add missing sysfs_remove_group for ACPI_TAD_RT Daniel Tang
2025-08-28  5:12 ` Mika Westerberg
2025-08-28  5:38   ` [PATCH v2] " Daniel Tang
2025-08-28  8:13     ` Mika Westerberg [this message]
2025-09-04 18:20       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250828081345.GV476609@black.igk.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=danielzgtg.opensource@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.