From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86E53C8303F for ; Thu, 28 Aug 2025 09:38:35 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1098016.1452162 (Exim 4.92) (envelope-from ) id 1urZ5Q-0004Qa-EL; Thu, 28 Aug 2025 09:38:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1098016.1452162; Thu, 28 Aug 2025 09:38:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1urZ5Q-0004QT-BW; Thu, 28 Aug 2025 09:38:28 +0000 Received: by outflank-mailman (input) for mailman id 1098016; Thu, 28 Aug 2025 09:38:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1urZ5P-0004Jm-FN for xen-devel@lists.xenproject.org; Thu, 28 Aug 2025 09:38:27 +0000 Received: from na1pdmzitismtp01.tibco.com (na1pdmzitismtp01.tibco.com [160.101.131.8]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bf3b23a7-83f2-11f0-aeb2-fb57b961d000; Thu, 28 Aug 2025 11:38:27 +0200 (CEST) Received: from mewpvdipd1010.corp.cloud.com (unknown [10.113.40.46]) by na1pdmzitismtp01.tibco.com (Postfix) with ESMTP id B641840C75C8; Thu, 28 Aug 2025 05:37:46 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf3b23a7-83f2-11f0-aeb2-fb57b961d000 From: Mark Syms To: jgross@suse.com, roger.pau@citrix.com, andrew.cooper3@citrix.com, xen-devel@lists.xenproject.org Cc: Mark Syms Subject: [PATCH] Clarify the cases where BLKIF_RSP_EOPNOTSUPP can be returned. Date: Thu, 28 Aug 2025 10:38:21 +0100 Message-ID: <20250828093821.372024-1-mark.syms@cloud.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Previously this said it would only happen on barrier writes. Except the documentation blocks for * feature-flush-cache * feature-discard Also say that they can return this error. Signed-off-by: Mark Syms --- xen/include/public/io/blkif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h index 8407453324..5e617b0c67 100644 --- a/xen/include/public/io/blkif.h +++ b/xen/include/public/io/blkif.h @@ -710,7 +710,7 @@ typedef struct blkif_response blkif_response_t; /* * STATUS RETURN CODES. */ - /* Operation not supported (only happens on barrier writes). */ + /* Operation not supported, see feature-barrier, feature-flush-cache, feature-discard. */ #define BLKIF_RSP_EOPNOTSUPP -2 /* Operation failed for some unspecified reason (-EIO). */ #define BLKIF_RSP_ERROR -1 -- 2.50.1