Re: [PATCH v2 4/5] LoongArch/kexec_file: Add crash dump support

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250820055700.24344-5-youling.tang@linux.dev>
References: <20250820055700.24344-5-youling.tang@linux.dev>
TO: Youling Tang <youling.tang@linux.dev>
TO: Huacai Chen <chenhuacai@kernel.org>
CC: WANG Xuerui <kernel@xen0n.name>
CC: Baoquan He <bhe@redhat.com>
CC: Yao Zi <ziyao@disroot.org>
CC: kexec@lists.infradead.org
CC: loongarch@lists.linux.dev
CC: linux-kernel@vger.kernel.org
CC: youling.tang@linux.dev
CC: Youling Tang <tangyouling@kylinos.cn>

Hi Youling,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.17-rc3 next-20250827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Youling-Tang/LoongArch-Add-struct-loongarch_image_header-for-kernel-image/20250820-140025
base:   linus/master
patch link:    https://lore.kernel.org/r/20250820055700.24344-5-youling.tang%40linux.dev
patch subject: [PATCH v2 4/5] LoongArch/kexec_file: Add crash dump support
:::::: branch date: 8 days ago
:::::: commit date: 8 days ago
config: loongarch-randconfig-r072-20250825 (https://download.01.org/0day-ci/archive/20250828/202508281014.9xPatJD8-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 15.1.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202508281014.9xPatJD8-lkp@intel.com/

smatch warnings:
arch/loongarch/kernel/machine_kexec_file.c:58 prepare_elf_headers() warn: iterator 'i' not incremented

vim +/i +58 arch/loongarch/kernel/machine_kexec_file.c

11aec169182e3a Youling Tang 2025-08-20  39  
11aec169182e3a Youling Tang 2025-08-20  40  static int prepare_elf_headers(void **addr, unsigned long *sz)
11aec169182e3a Youling Tang 2025-08-20  41  {
11aec169182e3a Youling Tang 2025-08-20  42  	struct crash_mem *cmem;
11aec169182e3a Youling Tang 2025-08-20  43  	unsigned int nr_ranges;
11aec169182e3a Youling Tang 2025-08-20  44  	int ret;
11aec169182e3a Youling Tang 2025-08-20  45  	u64 i;
11aec169182e3a Youling Tang 2025-08-20  46  	phys_addr_t start, end;
11aec169182e3a Youling Tang 2025-08-20  47  
11aec169182e3a Youling Tang 2025-08-20  48  	nr_ranges = 2; /* for exclusion of crashkernel region */
11aec169182e3a Youling Tang 2025-08-20  49  	for_each_mem_range(i, &start, &end)
11aec169182e3a Youling Tang 2025-08-20  50  		nr_ranges++;
11aec169182e3a Youling Tang 2025-08-20  51  
11aec169182e3a Youling Tang 2025-08-20  52  	cmem = kmalloc(struct_size(cmem, ranges, nr_ranges), GFP_KERNEL);
11aec169182e3a Youling Tang 2025-08-20  53  	if (!cmem)
11aec169182e3a Youling Tang 2025-08-20  54  		return -ENOMEM;
11aec169182e3a Youling Tang 2025-08-20  55  
11aec169182e3a Youling Tang 2025-08-20  56  	cmem->max_nr_ranges = nr_ranges;
11aec169182e3a Youling Tang 2025-08-20  57  	cmem->nr_ranges = 0;
11aec169182e3a Youling Tang 2025-08-20 @58  	for_each_mem_range(i, &start, &end) {
11aec169182e3a Youling Tang 2025-08-20  59  		cmem->ranges[cmem->nr_ranges].start = start;
11aec169182e3a Youling Tang 2025-08-20  60  		cmem->ranges[cmem->nr_ranges].end = end - 1;
11aec169182e3a Youling Tang 2025-08-20  61  		cmem->nr_ranges++;
11aec169182e3a Youling Tang 2025-08-20  62  	}
11aec169182e3a Youling Tang 2025-08-20  63  
11aec169182e3a Youling Tang 2025-08-20  64  	/* Exclude crashkernel region */
11aec169182e3a Youling Tang 2025-08-20  65  	ret = crash_exclude_mem_range(cmem, crashk_res.start, crashk_res.end);
11aec169182e3a Youling Tang 2025-08-20  66  	if (ret)
11aec169182e3a Youling Tang 2025-08-20  67  		goto out;
11aec169182e3a Youling Tang 2025-08-20  68  
11aec169182e3a Youling Tang 2025-08-20  69  	if (crashk_low_res.end) {
11aec169182e3a Youling Tang 2025-08-20  70  		ret = crash_exclude_mem_range(cmem, crashk_low_res.start, crashk_low_res.end);
11aec169182e3a Youling Tang 2025-08-20  71  		if (ret)
11aec169182e3a Youling Tang 2025-08-20  72  			goto out;
11aec169182e3a Youling Tang 2025-08-20  73  	}
11aec169182e3a Youling Tang 2025-08-20  74  
11aec169182e3a Youling Tang 2025-08-20  75  	ret = crash_prepare_elf64_headers(cmem, true, addr, sz);
11aec169182e3a Youling Tang 2025-08-20  76  
11aec169182e3a Youling Tang 2025-08-20  77  out:
11aec169182e3a Youling Tang 2025-08-20  78  	kfree(cmem);
11aec169182e3a Youling Tang 2025-08-20  79  	return ret;
11aec169182e3a Youling Tang 2025-08-20  80  }
11aec169182e3a Youling Tang 2025-08-20  81  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki