All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb+git@google.com>
To: linux-kernel@vger.kernel.org
Cc: linux-efi@vger.kernel.org, x86@kernel.org,
	 Ard Biesheuvel <ardb@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Ingo Molnar <mingo@kernel.org>,
	 Kevin Loughlin <kevinloughlin@google.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	 Josh Poimboeuf <jpoimboe@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	 Nikunj A Dadhania <nikunj@amd.com>
Subject: [PATCH v7 04/22] x86/sev: Run RMPADJUST on SVSM calling area page to test VMPL
Date: Thu, 28 Aug 2025 12:22:07 +0200	[thread overview]
Message-ID: <20250828102202.1849035-28-ardb+git@google.com> (raw)
In-Reply-To: <20250828102202.1849035-24-ardb+git@google.com>

From: Ard Biesheuvel <ardb@kernel.org>

Determining the VMPL at which the kernel runs involves performing a
RMPADJUST operation on an arbitrary page of memory, and observing whether
it succeeds.

The use of boot_ghcb_page in the core kernel in this case is completely
arbitrary, but results in the need to provide a PIC alias for it. So use
boot_svsm_ca_page instead, which already needs this alias for other
reasons.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
---
 arch/x86/boot/compressed/sev.c      | 2 +-
 arch/x86/boot/startup/sev-shared.c  | 5 +++--
 arch/x86/boot/startup/sev-startup.c | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
index b71c1ab6a282..3628e9bddc6a 100644
--- a/arch/x86/boot/compressed/sev.c
+++ b/arch/x86/boot/compressed/sev.c
@@ -327,7 +327,7 @@ static bool early_snp_init(struct boot_params *bp)
 	 * running at VMPL0. The CA will be used to communicate with the
 	 * SVSM and request its services.
 	 */
-	svsm_setup_ca(cc_info);
+	svsm_setup_ca(cc_info, rip_rel_ptr(&boot_ghcb_page));
 
 	/*
 	 * Pass run-time kernel a pointer to CC info via boot_params so EFI
diff --git a/arch/x86/boot/startup/sev-shared.c b/arch/x86/boot/startup/sev-shared.c
index 7bd73462c11e..83c222a4f1fa 100644
--- a/arch/x86/boot/startup/sev-shared.c
+++ b/arch/x86/boot/startup/sev-shared.c
@@ -801,7 +801,8 @@ static void __head pvalidate_4k_page(unsigned long vaddr, unsigned long paddr,
  * Maintain the GPA of the SVSM Calling Area (CA) in order to utilize the SVSM
  * services needed when not running in VMPL0.
  */
-static bool __head svsm_setup_ca(const struct cc_blob_sev_info *cc_info)
+static bool __head svsm_setup_ca(const struct cc_blob_sev_info *cc_info,
+				 void *page)
 {
 	struct snp_secrets_page *secrets_page;
 	struct snp_cpuid_table *cpuid_table;
@@ -824,7 +825,7 @@ static bool __head svsm_setup_ca(const struct cc_blob_sev_info *cc_info)
 	 * routine is running identity mapped when called, both by the decompressor
 	 * code and the early kernel code.
 	 */
-	if (!rmpadjust((unsigned long)rip_rel_ptr(&boot_ghcb_page), RMP_PG_SIZE_4K, 1))
+	if (!rmpadjust((unsigned long)page, RMP_PG_SIZE_4K, 1))
 		return false;
 
 	/*
diff --git a/arch/x86/boot/startup/sev-startup.c b/arch/x86/boot/startup/sev-startup.c
index 8412807a865c..3da04a715831 100644
--- a/arch/x86/boot/startup/sev-startup.c
+++ b/arch/x86/boot/startup/sev-startup.c
@@ -302,7 +302,7 @@ static __head void svsm_setup(struct cc_blob_sev_info *cc_info)
 	 * running at VMPL0. The CA will be used to communicate with the
 	 * SVSM to perform the SVSM services.
 	 */
-	if (!svsm_setup_ca(cc_info))
+	if (!svsm_setup_ca(cc_info, rip_rel_ptr(&boot_svsm_ca_page)))
 		return;
 
 	/*
-- 
2.51.0.268.g9569e192d0-goog


  parent reply	other threads:[~2025-08-28 10:22 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28 10:22 [PATCH v7 00/22] x86: strict separation of startup code Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 01/22] x86/sev: Separate MSR and GHCB based snp_cpuid() via a callback Ard Biesheuvel
2025-08-28 15:33   ` Borislav Petkov
2025-08-28 16:14     ` Ard Biesheuvel
2025-09-09 21:45       ` Tom Lendacky
2025-09-09 21:44     ` Tom Lendacky
2025-09-09 22:20       ` Borislav Petkov
2025-09-10 13:57         ` Tom Lendacky
2025-09-04 11:21   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 02/22] x86/sev: Use MSR protocol for remapping SVSM calling area Ard Biesheuvel
2025-09-04 11:21   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 03/22] x86/sev: Use MSR protocol only for early SVSM PVALIDATE call Ard Biesheuvel
2025-09-04 11:21   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` Ard Biesheuvel [this message]
2025-09-04 11:21   ` [tip: x86/sev] x86/sev: Run RMPADJUST on SVSM calling area page to test VMPL tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 05/22] x86/sev: Move GHCB page based HV communication out of startup code Ard Biesheuvel
2025-08-31 10:49   ` Borislav Petkov
2025-08-31 10:52     ` Ard Biesheuvel
2025-08-31 10:56       ` Ard Biesheuvel
2025-08-31 11:15         ` Borislav Petkov
2025-08-31 12:30           ` Ard Biesheuvel
2025-08-31 13:11             ` Ard Biesheuvel
2025-09-01 13:54               ` Borislav Petkov
2025-09-01 14:02                 ` Ard Biesheuvel
2025-09-01 14:25                   ` Borislav Petkov
2025-09-01 14:26                     ` Ard Biesheuvel
2025-09-04 11:21   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 06/22] x86/sev: Avoid global variable to store virtual address of SVSM area Ard Biesheuvel
2025-09-04 11:21   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 07/22] x86/sev: Share implementation of MSR-based page state change Ard Biesheuvel
2025-09-04 11:21   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 08/22] x86/sev: Pass SVSM calling area down to early page state change API Ard Biesheuvel
2025-09-04 11:21   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 09/22] x86/sev: Use boot SVSM CA for all startup and init code Ard Biesheuvel
2025-09-04 11:21   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 10/22] x86/boot: Drop redundant RMPADJUST in SEV SVSM presence check Ard Biesheuvel
2025-09-02 12:02   ` Borislav Petkov
2025-09-02 13:50     ` Ard Biesheuvel
2025-09-04 11:20   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 11/22] x86/boot: Provide PIC aliases for 5-level paging related constants Ard Biesheuvel
2025-09-04 11:20   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 12/22] x86/sev: Provide PIC aliases for SEV related data objects Ard Biesheuvel
2025-09-02 12:06   ` Borislav Petkov
2025-09-02 12:24     ` Ard Biesheuvel
2025-09-02 16:24       ` Borislav Petkov
2025-09-04 11:20   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 13/22] x86/sev: Move __sev_[get|put]_ghcb() into separate noinstr object Ard Biesheuvel
2025-09-04 11:20   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 14/22] x86/sev: Export startup routines for later use Ard Biesheuvel
2025-09-04 11:20   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 15/22] objtool: Add action to check for absence of absolute relocations Ard Biesheuvel
2025-09-04 11:20   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-10-13  9:40   ` [PATCH v7 15/22] " Andreas Schwab
2025-08-28 10:22 ` [PATCH v7 16/22] x86/boot: Check startup code " Ard Biesheuvel
2025-09-04 11:20   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 17/22] x86/boot: Revert "Reject absolute references in .head.text" Ard Biesheuvel
2025-09-04 11:20   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 18/22] x86/kbuild: Incorporate boot/startup/ via Kbuild makefile Ard Biesheuvel
2025-09-04 11:20   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 19/22] x86/boot: Create a confined code area for startup code Ard Biesheuvel
2025-09-04 11:20   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 20/22] efistub/x86: Remap inittext read-execute when needed Ard Biesheuvel
2025-09-04 11:20   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 21/22] x86/boot: Move startup code out of __head section Ard Biesheuvel
2025-09-03  9:20   ` Ard Biesheuvel
2025-09-04 11:20   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-08-28 10:22 ` [PATCH v7 22/22] x86/boot: Get rid of the .head.text section Ard Biesheuvel
2025-09-04 11:20   ` [tip: x86/sev] " tip-bot2 for Ard Biesheuvel
2025-09-03 16:22 ` [PATCH v7 00/22] x86: strict separation of startup code Borislav Petkov
2025-09-04  6:29   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250828102202.1849035-28-ardb+git@google.com \
    --to=ardb+git@google.com \
    --cc=ardb@kernel.org \
    --cc=bp@alien8.de \
    --cc=jpoimboe@kernel.org \
    --cc=kevinloughlin@google.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=nikunj@amd.com \
    --cc=peterz@infradead.org \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.